Re: Review Request: Change KIO::DeleteJob to use KIO::http_delete for HTTP protocol

2011-11-04 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103038/#review7946 --- This review has been submitted with commit 2423a03608722f16dffa

Re: Review Request: Change KIO::DeleteJob to use KIO::http_delete for HTTP protocol

2011-11-04 Thread Dawit Alemayehu
> On Nov. 4, 2011, 11:20 a.m., David Faure wrote: > > kio/kio/deletejob.cpp, line 100 > > > > > > Could be file-static instead of class-static, so that it doesn't > > generate a symbol at all. True, will do that.

Re: Review Request: Change KIO::DeleteJob to use KIO::http_delete for HTTP protocol

2011-11-04 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103038/#review7939 --- Ship it! kio/kio/deletejob.cpp

Review Request: Change KIO::DeleteJob to use KIO::http_delete for HTTP protocol

2011-11-03 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103038/ --- Review request for kdelibs and David Faure. Description --- The attac