Re: Review Request: Avoid terminating a QThread in kio/kio/hostinfo.cpp

> On Aug. 20, 2011, 9:31 a.m., David Faure wrote: > > Starting and stopping threads all the time is much more wasteful than > > Albert's approach (which Thiago and I designed) where a single thread is > > being reused for all queries. And waiting 250ms doesn't seem efficient > > either. > > >

Re: Review Request: Avoid terminating a QThread in kio/kio/hostinfo.cpp

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102238/#review5846 --- Starting and stopping threads all the time is much more wasteful

Re: Review Request: Avoid terminating a QThread in kio/kio/hostinfo.cpp

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102238/#review5823 --- Can't find any other obvious problem. I still think that waiting

Re: Review Request: Avoid terminating a QThread in kio/kio/hostinfo.cpp

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102238/ --- (Updated Aug. 18, 2011, 9:45 p.m.) Review request for kdelibs, David Faure

Re: Review Request: Avoid terminating a QThread in kio/kio/hostinfo.cpp

> On Aug. 18, 2011, 8:39 p.m., Albert Astals Cid wrote: > > kio/kio/hostinfo.cpp, line 406 > > > > > > You are connecting thread finished to lookupFinished to try to reuse > > the thread and then in the constructor

Re: Review Request: Avoid terminating a QThread in kio/kio/hostinfo.cpp

> On Aug. 14, 2011, 11:02 p.m., Albert Astals Cid wrote: > > When using your code with my simple test program > > > > #include "hostinfo_p.h" > > #include > > #include > > #include > > > > int main(int a, char **b) > > { > > QApplication app(a, b); > > QTime t; > > t.

Re: Review Request: Avoid terminating a QThread in kio/kio/hostinfo.cpp

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102238/#review5799 --- kio/kio/hostinfo.cpp

Re: Review Request: Avoid terminating a QThread in kio/kio/hostinfo.cpp

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102238/ --- (Updated Aug. 17, 2011, 5:40 a.m.) Review request for kdelibs, David Faure