Re: Review Request: Avoid possible null pointer dereferences in khtml

2011-10-07 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102794/#review7170 --- This review has been submitted with commit 4eb2bb4b9b5fc206f88e

Re: Review Request: Avoid possible null pointer dereferences in khtml

2011-10-07 Thread Thiago Macieira
On Friday, 7 de October de 2011 15:49:59 Ruurd Pels wrote: > > On Oct. 7, 2011, 2:35 p.m., Ruurd Pels wrote: > > > Revert the whitespace changes with git. Other than that I dislike > > > multiple exit points even in trivially short functions. It really does > > > not hurt to create a local variable

Re: Review Request: Avoid possible null pointer dereferences in khtml

2011-10-07 Thread Ruurd Pels
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102794/#review7169 --- Ship it! Ship It! - Ruurd Pels On Oct. 7, 2011, 4:25 p.m., J

Re: Review Request: Avoid possible null pointer dereferences in khtml

2011-10-07 Thread Jaime Torres Amate
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102794/ --- (Updated Oct. 7, 2011, 4:25 p.m.) Review request for kdelibs. Changes --

Re: Review Request: Avoid possible null pointer dereferences in khtml

2011-10-07 Thread Ruurd Pels
> On Oct. 7, 2011, 2:35 p.m., Ruurd Pels wrote: > > Revert the whitespace changes with git. Other than that I dislike multiple > > exit points even in trivially short functions. It really does not hurt to > > create a local variable holding the result of the function and then return > > that a

Re: Review Request: Avoid possible null pointer dereferences in khtml

2011-10-07 Thread Ruurd Pels
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102794/#review7166 --- Revert the whitespace changes with git. Other than that I dislik

Re: Review Request: Avoid possible null pointer dereferences in khtml

2011-10-07 Thread Christoph Feck
> On Oct. 7, 2011, 2:35 p.m., Ruurd Pels wrote: > > Revert the whitespace changes with git. Other than that I dislike multiple > > exit points even in trivially short functions. It really does not hurt to > > create a local variable holding the result of the function and then return > > that a

Re: Review Request: Avoid possible null pointer dereferences in khtml

2011-10-07 Thread Ruurd Pels
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102794/#review7165 --- Revert the whitespace changes with git. Other than that I dislik

Re: Review Request: Avoid possible null pointer dereferences in khtml

2011-10-07 Thread Thiago Macieira
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102794/#review7164 --- You can configure kate not to remove trailing whitespaces in the

Review Request: Avoid possible null pointer dereferences in khtml

2011-10-07 Thread Jaime Torres Amate
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102794/ --- Review request for kdelibs. Description --- The real changes are: Avo