Re: Review Request: Avoid creating an empty .tbcache for bookmarks

2012-10-01 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106563/#review19704 --- Ship it! Ship It! - David Faure On Sept. 30, 2012, 8:47 p.m

Re: Review Request: Avoid creating an empty .tbcache for bookmarks

2012-09-30 Thread Stefan Brüns
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106563/ --- (Updated Sept. 30, 2012, 8:47 p.m.) Review request for kdelibs and David F

Re: Review Request: Avoid creating an empty .tbcache for bookmarks

2012-09-29 Thread David Faure
> On Sept. 29, 2012, 8:25 a.m., David Faure wrote: > > Ah, thanks, now I understand. Please commit. The speedup idea is good too, feel free to switch to that solution. - David --- This is an automatically generated e-mail. To reply, vis

Re: Review Request: Avoid creating an empty .tbcache for bookmarks

2012-09-29 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106563/#review19561 --- Ship it! Ah, thanks, now I understand. Please commit. - David

Re: Review Request: Avoid creating an empty .tbcache for bookmarks

2012-09-28 Thread Stefan Brüns
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106563/ --- (Updated Sept. 28, 2012, 8:30 p.m.) Review request for kdelibs and David F

Re: Review Request: Avoid creating an empty .tbcache for bookmarks

2012-09-28 Thread Stefan Brüns
> On Sept. 28, 2012, 5:32 p.m., David Faure wrote: > > Why did the original code fail? It already checks for rootIsToolbarGroup(), > > which should be true in the case you describe, right? So the saving was > > supposed to be skipped then... If a new bookmark file is created, no folder has the

Re: Review Request: Avoid creating an empty .tbcache for bookmarks

2012-09-28 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106563/#review19523 --- Why did the original code fail? It already checks for rootIsToo

Review Request: Avoid creating an empty .tbcache for bookmarks

2012-09-25 Thread Stefan Brüns
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106563/ --- Review request for kdelibs. Description --- Currently, an empty tbcac