Re: Review Request: Allow protocol-specialized ThumbCreators to be used for folder previews

2012-02-13 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103882/#review10607 --- This review has been submitted with commit 3487ca03f0e6a88a604

Re: Review Request: Allow protocol-specialized ThumbCreators to be used for folder previews

2012-02-13 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103882/#review10598 --- This review has been submitted with commit 92e8ec0bf91ceead579

Re: Review Request: Allow protocol-specialized ThumbCreators to be used for folder previews

2012-02-13 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103882/#review10585 --- Ship it! OK I understand. This should actually replace m_remot

Re: Review Request: Allow protocol-specialized ThumbCreators to be used for folder previews

2012-02-08 Thread Sebastian Trueg
> On Feb. 8, 2012, 8:43 p.m., David Faure wrote: > > I don't understand, why didn't m_remoteProtocolPlugins do the job? Because it does not include the services, only the supported protocols and mimetypes. We could merge the two - sure. I just wanted to change as little code as possible to avo

Re: Review Request: Allow protocol-specialized ThumbCreators to be used for folder previews

2012-02-08 Thread Sebastian Trueg
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103882/ --- (Updated Feb. 8, 2012, 9:56 p.m.) Review request for kdelibs. Changes --

Re: Review Request: Allow protocol-specialized ThumbCreators to be used for folder previews

2012-02-08 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103882/#review10429 --- I don't understand, why didn't m_remoteProtocolPlugins do the j

Review Request: Allow protocol-specialized ThumbCreators to be used for folder previews

2012-02-07 Thread Sebastian Trueg
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103882/ --- Review request for kdelibs. Description --- The problem is fairly sim