Re: Review Request: Add urlChanged signal to ReadOnlyPart

2012-08-23 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106116/#review17910 --- This review has been submitted with commit a4eab98d0e56c99dce7

Re: Review Request: Add urlChanged signal to ReadOnlyPart

2012-08-23 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106116/#review17892 --- Ship it! Ah, yes, you're right. Reviewboard fooled me a little

Re: Review Request: Add urlChanged signal to ReadOnlyPart

2012-08-22 Thread Albert Astals Cid
> On Aug. 22, 2012, 11:18 a.m., David Faure wrote: > > kparts/part.cpp, line 996 > > > > > > If it didn't change, why emit urlChanged() here? > > i.e. I think this line should be kept as m_url = m_originalURL.

Re: Review Request: Add urlChanged signal to ReadOnlyPart

2012-08-22 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106116/#review17858 --- Looks good, please add @since 4.10 to the signal definition, an

Review Request: Add urlChanged signal to ReadOnlyPart

2012-08-21 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106116/ --- Review request for kdelibs and David Faure. Description --- Add this