Re: Review Request: Add support for building libplasma with GLES2

2011-02-28 Thread Sebastian Kügler
On Friday, February 25, 2011 04:29:36 Jammy Zhou wrote: > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/100705/ > --- > Update the p

Re: Review Request: Add support for building libplasma with GLES2

2011-02-28 Thread Marco Martin
On Monday 28 February 2011, Jammy Zhou wrote: > Hi Macro, > > I have updated the patch to remove direct OpenGL dependency for libplasma. > Could you please review the patch? (It seems that my mails to > kde-core-devel list were moderated by the server, so I send mail directly > to you here) Hi Ja

Re: Review Request: Add support for building libplasma with GLES2

2011-02-28 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100705/#review1693 --- Ship it! to me seems good. filling the background of black is s

Re: Review Request: Add support for building libplasma with GLES2

2011-02-28 Thread Jammy Zhou
Hi Macro, I have updated the patch to remove direct OpenGL dependency for libplasma. Could you please review the patch? (It seems that my mails to kde-core-devel list were moderated by the server, so I send mail directly to you here) Regards, Jammy On Fri, Feb 25, 2011 at 8:33 PM, Marco Martin

Re: Review Request: Add support for building libplasma with GLES2

2011-02-25 Thread Marco Martin
On Thursday 24 February 2011, Martin Gräßlin wrote: > > > > I also considered to remove glClear in GLApplet, but I'm not sure if > > it will cause some regressions, so I prepared this change. > > > > Anyway, waiting for inputs from plasma-devs to make final decision. > > > >

Re: Review Request: Add support for building libplasma with GLES2

2011-02-25 Thread Jammy Zhou
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100705/ --- (Updated Feb. 25, 2011, 3:29 a.m.) Review request for kdelibs and Plasma.

Re: Review Request: Add support for building libplasma with GLES2

2011-02-25 Thread Jammy Zhou
> On Feb. 23, 2011, 5:29 p.m., Martin Gräßlin wrote: > > The GLApplet seems to be unmaintained and is nowhere used in KDE (see > > http://lxr.kde.org/ident?i=GLApplet ). There was once one demo applet using > > it, but it has vanished. > > > > GLApplet uses OpenGL only for glClear before passi

Re: Review Request: Add support for building libplasma with GLES2

2011-02-24 Thread Martin Gräßlin
> On Feb. 23, 2011, 5:29 p.m., Martin Gräßlin wrote: > > The GLApplet seems to be unmaintained and is nowhere used in KDE (see > > http://lxr.kde.org/ident?i=GLApplet ). There was once one demo applet using > > it, but it has vanished. > > > > GLApplet uses OpenGL only for glClear before passi

Re: Review Request: Add support for building libplasma with GLES2

2011-02-24 Thread Jammy Zhou
> On Feb. 23, 2011, 5:29 p.m., Martin Gräßlin wrote: > > The GLApplet seems to be unmaintained and is nowhere used in KDE (see > > http://lxr.kde.org/ident?i=GLApplet ). There was once one demo applet using > > it, but it has vanished. > > > > GLApplet uses OpenGL only for glClear before passi

Re: Review Request: Add support for building libplasma with GLES2

2011-02-24 Thread Jammy Zhou
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100705/ --- (Updated Feb. 24, 2011, 2:07 a.m.) Review request for kdelibs and Plasma.

Re: Review Request: Add support for building libplasma with GLES2

2011-02-23 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100705/#review1612 --- The GLApplet seems to be unmaintained and is nowhere used in KDE

Review Request: Add support for building libplasma with GLES2

2011-02-21 Thread Jammy Zhou
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100705/ --- Review request for kdelibs. Summary --- After build kwin with GLES2 c