Re: Review Request: Add submenu support to QML shutdown dialog.

2012-07-17 Thread Konstantinos Smanis
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105568/#review16022 --- I forgot to mention that the submenus should only be created if

Re: Review Request: Add submenu support to QML shutdown dialog.

2012-07-17 Thread Lamarque Vieira Souza
> On July 17, 2012, 6:19 p.m., Konstantinos Smanis wrote: > > I forgot to mention that the submenus should only be created if Grub2 or > > Burg is the selected Boot Manager in KDM. Other bootloaders (grub, lilo) > > should still be able to use '>' in the menu titles without creating > > submen

Re: Review Request: Add submenu support to QML shutdown dialog.

2012-07-17 Thread Oswald Buddenhagen
> On July 17, 2012, 6:19 p.m., Konstantinos Smanis wrote: > > I forgot to mention that the submenus should only be created if Grub2 or > > Burg is the selected Boot Manager in KDM. Other bootloaders (grub, lilo) > > should still be able to use '>' in the menu titles without creating > > submen

Re: Review Request: Add submenu support to QML shutdown dialog.

2012-07-17 Thread Lamarque Vieira Souza
> On July 17, 2012, 6:19 p.m., Konstantinos Smanis wrote: > > I forgot to mention that the submenus should only be created if Grub2 or > > Burg is the selected Boot Manager in KDM. Other bootloaders (grub, lilo) > > should still be able to use '>' in the menu titles without creating > > submen

Re: Review Request: Add submenu support to QML shutdown dialog.

2012-07-17 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105568/#review16019 --- This review has been submitted with commit 7884098c74837db178a

Re: Review Request: Add submenu support to QML shutdown dialog.

2012-07-17 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105568/#review16018 --- This review has been submitted with commit 0e325a61a57ff85f15b

Re: Review Request: Add submenu support to QML shutdown dialog.

2012-07-14 Thread Konstantinos Smanis
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105568/#review15857 --- The issues were resolved; much better now. - Konstantinos Sman

Re: Review Request: Add submenu support to QML shutdown dialog.

2012-07-14 Thread Konstantinos Smanis
> On July 14, 2012, 12:18 p.m., Konstantinos Smanis wrote: > > My QML knowledge is too limited to review your code, but I tested your > > patch and have the following remarks to make: > > > > 1) There is some flickering when hovering a menu item. Dunno if it has to > > do with my theme (tried

Re: Review Request: Add submenu support to QML shutdown dialog.

2012-07-14 Thread Lamarque Vieira Souza
> On July 14, 2012, 12:18 p.m., Konstantinos Smanis wrote: > > My QML knowledge is too limited to review your code, but I tested your > > patch and have the following remarks to make: > > > > 1) There is some flickering when hovering a menu item. Dunno if it has to > > do with my theme (tried

Re: Review Request: Add submenu support to QML shutdown dialog.

2012-07-14 Thread Lamarque Vieira Souza
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105568/ --- (Updated July 14, 2012, 6:53 p.m.) Review request for KDE Runtime and Kons

Re: Review Request: Add submenu support to QML shutdown dialog.

2012-07-14 Thread Konstantinos Smanis
> On July 14, 2012, 12:18 p.m., Konstantinos Smanis wrote: > > My QML knowledge is too limited to review your code, but I tested your > > patch and have the following remarks to make: > > > > 1) There is some flickering when hovering a menu item. Dunno if it has to > > do with my theme (tried

Re: Review Request: Add submenu support to QML shutdown dialog.

2012-07-14 Thread Konstantinos Smanis
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105568/#review15841 --- My QML knowledge is too limited to review your code, but I test

Re: Review Request: Add submenu support to QML shutdown dialog.

2012-07-13 Thread Lamarque Vieira Souza
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105568/ --- (Updated July 14, 2012, 5:48 a.m.) Review request for KDE Runtime and Kons

Re: Review Request: Add submenu support to QML shutdown dialog.

2012-07-13 Thread Lamarque Vieira Souza
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105568/ --- (Updated July 14, 2012, 5:41 a.m.) Review request for KDE Runtime and Kons

Re: Review Request: Add submenu support to QML shutdown dialog.

2012-07-13 Thread Lamarque Vieira Souza
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105568/ --- (Updated July 14, 2012, 2:46 a.m.) Review request for KDE Runtime and Kons

Review Request: Add submenu support to QML shutdown dialog.

2012-07-13 Thread Lamarque Vieira Souza
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105568/ --- Review request for KDE Runtime and Konstantinos Smanis. Description --