Re: Review Request: Add recentdocuments:/ kio slave to kde-runtime.

2012-03-11 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103849/#review11280 --- This review has been submitted with commit feeadd5c4fed9378649

Re: Review Request: Add recentdocuments:/ kio slave to kde-runtime.

2012-03-11 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103849/#review11278 --- Ship it! Looks good, please commit after adjusting the last mi

Re: Review Request: Add recentdocuments:/ kio slave to kde-runtime.

2012-03-07 Thread Xuetian Weng
> On Feb. 13, 2012, 11:26 a.m., David Faure wrote: > > kioslave/recentdocuments/recentdocuments.cpp, line 58 > > > > > > Why use KUrl here? This is always a local path, and you turn it into a > > local path in order

Re: Review Request: Add recentdocuments:/ kio slave to kde-runtime.

2012-02-15 Thread Xuetian Weng
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103849/ --- (Updated Feb. 15, 2012, 3:11 p.m.) Review request for KDE Runtime. Chang

Re: Review Request: Add recentdocuments:/ kio slave to kde-runtime.

2012-02-13 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103849/#review10588 --- kioslave/recentdocuments/recentdocuments.cpp

Re: Review Request: Add recentdocuments:/ kio slave to kde-runtime.

2012-02-13 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103849/#review10587 --- kioslave/recentdocuments/recentdocuments.cpp

Re: Review Request: Add recentdocuments:/ kio slave to kde-runtime.

2012-02-05 Thread Xuetian Weng
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103849/ --- (Updated Feb. 5, 2012, 7:24 p.m.) Review request for KDE Runtime. Change

Re: Review Request: Add recentdocuments:/ kio slave to kde-runtime.

2012-02-05 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103849/#review10352 --- kioslave/recentdocuments/recentdocumentsnotifier.cpp

Re: Review Request: Add recentdocuments:/ kio slave to kde-runtime.

2012-02-05 Thread Xuetian Weng
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103849/ --- (Updated Feb. 5, 2012, 5:28 a.m.) Review request for KDE Runtime. Change

Re: Review Request: Add recentdocuments:/ kio slave to kde-runtime.

2012-02-04 Thread Xuetian Weng
> On Feb. 2, 2012, 11:27 p.m., Albert Astals Cid wrote: > > kioslave/recentdocuments/recentdocuments.protocol, line 13 > > > > > > Why 4 maxInstances? Not sure for this part... maybe only one? > On Feb. 2, 2012, 1

Re: Review Request: Add recentdocuments:/ kio slave to kde-runtime.

2012-02-02 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103849/#review10300 --- You need a Messages.sh to extract your i18n calls so that they

Review Request: Add recentdocuments:/ kio slave to kde-runtime.

2012-02-02 Thread Xuetian Weng
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103849/ --- Review request for KDE Runtime. Description --- Add recentdocuments:/