Re: Review Request: Add pkgconfig hints to FindSamba.cmake

2012-10-24 Thread Raphael Kubo da Costa
Alexander Neundorf writes: > On Monday 22 October 2012, Rex Dieter wrote: >> > On Oct. 21, 2012, 9:27 a.m., Raphael Kubo da Costa wrote: >> > > cmake/modules/FindSamba.cmake, line 23 >> > > > > > ne23> >> > > >> > > Plea

Re: Review Request: Add pkgconfig hints to FindSamba.cmake

2012-10-23 Thread Alexander Neundorf
On Monday 22 October 2012, Rex Dieter wrote: > > On Oct. 21, 2012, 9:27 a.m., Raphael Kubo da Costa wrote: > > > cmake/modules/FindSamba.cmake, line 23 > > > > > ne23> > > > > > > Please note that support for the QUIET k

Re: Review Request: Add pkgconfig hints to FindSamba.cmake

2012-10-21 Thread Rex Dieter
> On Oct. 21, 2012, 9:27 a.m., Raphael Kubo da Costa wrote: > > cmake/modules/FindSamba.cmake, line 23 > > > > > > Please note that support for the QUIET keyword was added in CMake 2.8.2 > > -- it is probably OK for

Re: Review Request: Add pkgconfig hints to FindSamba.cmake

2012-10-21 Thread Raphael Kubo da Costa
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106861/#review20611 --- cmake/modules/FindSamba.cmake

Re: Review Request: Add pkgconfig hints to FindSamba.cmake

2012-10-15 Thread Rex Dieter
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106861/ --- (Updated Oct. 15, 2012, 12:24 p.m.) Review request for kdelibs. Changes

Re: Review Request: Add pkgconfig hints to FindSamba.cmake

2012-10-15 Thread Rex Dieter
> On Oct. 15, 2012, 6:19 a.m., Rolf Eike Beer wrote: > > cmake/modules/FindSamba.cmake, line 20 > > > > > > Why the if? If there is no pkgconfig found it the macro will just do > > nothing. And pkgconfig could even

Re: Review Request: Add pkgconfig hints to FindSamba.cmake

2012-10-14 Thread Rolf Eike Beer
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106861/#review20357 --- cmake/modules/FindSamba.cmake

Review Request: Add pkgconfig hints to FindSamba.cmake

2012-10-14 Thread Rex Dieter
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106861/ --- Review request for kdelibs. Description --- Add pkgconfig hints to Fi