Re: Review Request: Add cmake config for kdeclarative library.

2012-04-29 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104140/#review13110 --- This review has been submitted with commit d5b2e642a75ed4f0421

Re: Review Request: Add cmake config for kdeclarative library.

2012-04-27 Thread Laszlo Papp
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104140/#review13003 --- Ship it! Ship It! - Laszlo Papp On March 5, 2012, 9:55 p.m.

Re: Review Request: Add cmake config for kdeclarative library.

2012-04-27 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104140/#review12971 --- bump. what's the status of this? - Aleix Pol Gonzalez On Mar

Re: Review Request: Add cmake config for kdeclarative library.

2012-04-09 Thread Lamarque Vieira Souza
> On March 5, 2012, 8:51 p.m., Alexander Neundorf wrote: > > experimental/libkdeclarative/KDeclarativeConfig.cmake.in, line 14 > > > > > > I didn't check, but how is INCLUDE_INSTALL_DIR set ? > > Is it done by vi

Re: Review Request: Add cmake config for kdeclarative library.

2012-03-06 Thread Lamarque Vieira Souza
> On March 5, 2012, 8:51 p.m., Alexander Neundorf wrote: > > experimental/libkdeclarative/KDeclarativeConfig.cmake.in, line 12 > > > > > > You may want to use something like > > KDeclarative_SOURCE_DIR, which is

Re: Review Request: Add cmake config for kdeclarative library.

2012-03-05 Thread Lamarque Vieira Souza
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104140/ --- (Updated March 5, 2012, 9:55 p.m.) Review request for kdelibs. Changes -

Re: Review Request: Add cmake config for kdeclarative library.

2012-03-05 Thread Alexander Neundorf
> On March 5, 2012, 8:51 p.m., Alexander Neundorf wrote: > > experimental/libkdeclarative/KDeclarativeConfig.cmake.in, line 12 > > > > > > You may want to use something like > > KDeclarative_SOURCE_DIR, which is

Re: Review Request: Add cmake config for kdeclarative library.

2012-03-05 Thread Lamarque Vieira Souza
> On March 2, 2012, 6:57 p.m., Laszlo Papp wrote: > > I am a bit of layman in here (thus pardon me), but I would personally > > prefer a separated location for these config files. Something like either > > cmake/modules or in the experimental subfolder itself right next to the > > "CTestConfig

Re: Review Request: Add cmake config for kdeclarative library.

2012-03-05 Thread Lamarque Vieira Souza
> On March 5, 2012, 8:51 p.m., Alexander Neundorf wrote: > > experimental/libkdeclarative/KDeclarativeConfig.cmake.in, line 14 > > > > > > I didn't check, but how is INCLUDE_INSTALL_DIR set ? > > Is it done by vi

Re: Review Request: Add cmake config for kdeclarative library.

2012-03-05 Thread Alexander Neundorf
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104140/#review11151 --- experimental/libkdeclarative/KDeclarativeConfig.cmake.in

Re: Review Request: Add cmake config for kdeclarative library.

2012-03-05 Thread Alexander Neundorf
> On March 2, 2012, 6:57 p.m., Laszlo Papp wrote: > > I am a bit of layman in here (thus pardon me), but I would personally > > prefer a separated location for these config files. Something like either > > cmake/modules or in the experimental subfolder itself right next to the > > "CTestConfig

Re: Review Request: Add cmake config for kdeclarative library.

2012-03-02 Thread Laszlo Papp
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104140/#review11090 --- I am a bit of layman in here (thus pardon me), but I would pers

Re: Review Request: Add cmake config for kdeclarative library.

2012-03-02 Thread Lamarque Vieira Souza
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104140/ --- (Updated March 2, 2012, 6:01 p.m.) Review request for kdelibs. Changes -

Review Request: Add cmake config for kdeclarative library.

2012-03-02 Thread Lamarque Vieira Souza
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104140/ --- Review request for kdelibs. Description --- Currently kdeclarative li