Re: Review Request: Activities support for Konqueror

2012-10-18 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106908/#review20545 --- This review has been submitted with commit ff21d2c529542139f19

Re: Review Request: Activities support for Konqueror

2012-10-18 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106908/#review20544 --- Ship it! Ah, well, that's even better, then. (Thanks for the

Re: Review Request: Activities support for Konqueror

2012-10-18 Thread Ivan Čukić
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106908/ --- (Updated Oct. 18, 2012, 10:13 a.m.) Review request for KDE Base Apps and D

Re: Review Request: Activities support for Konqueror

2012-10-18 Thread Ivan Čukić
> On Oct. 18, 2012, 9:20 a.m., David Faure wrote: > > Well if this works, ship it. I'm confused about this stuff though, it only > > says "this view has focus", but how does it get information about the > > current url etc? The url is set in: int KonqView::openUrl( const KUrl &url, const QStri

Re: Review Request: Activities support for Konqueror

2012-10-18 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106908/#review20540 --- Ship it! Well if this works, ship it. I'm confused about this

Re: Review Request: Activities support for Konqueror

2012-10-17 Thread Ivan Čukić
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106908/ --- (Updated Oct. 17, 2012, 4:06 p.m.) Review request for KDE Base Apps and Da

Re: Review Request: Activities support for Konqueror

2012-10-17 Thread Ivan Čukić
> On Oct. 17, 2012, 3:43 p.m., David Faure wrote: > > konqueror/src/konqview.h, line 48 > > > > > > You should switch to #cmakedefine01 in the config-apps.h file, and use > > #if here. > > > > This has the

Re: Review Request: Activities support for Konqueror

2012-10-17 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106908/#review20502 --- konqueror/src/konqview.h

Re: Review Request: Activities support for Konqueror

2012-10-17 Thread Ivan Čukić
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106908/ --- (Updated Oct. 17, 2012, 3:27 p.m.) Review request for KDE Base Apps and Da

Review Request: Activities support for Konqueror

2012-10-16 Thread Ivan Čukić
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106908/ --- Review request for KDE Base Apps. Description --- Konqueror reports t