Re: Review Request: [PATCH] Make kio_info produce valid HTML

2012-12-09 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105590/#review23228 --- This review has been submitted with commit 0817c385be22fc99091

Re: Review Request: [PATCH] Make kio_info produce valid HTML

2012-12-09 Thread Albert Astals Cid
> On July 26, 2012, 12:53 p.m., Paul Walger wrote: > > Ship It! > > Albert Astals Cid wrote: > Was this ever commited? > > Paul Walger wrote: > I am quite unfamiliar with whole process how to send in a patch. > How can i commit this? Once you get the "Ship it!" you are supposed to

Re: Review Request: [PATCH] Make kio_info produce valid HTML

2012-12-09 Thread Paul Walger
> On July 26, 2012, 12:53 p.m., Paul Walger wrote: > > Ship It! > > Albert Astals Cid wrote: > Was this ever commited? I am quite unfamiliar with whole process how to send in a patch. How can i commit this? - Paul --- This is an au

Re: Review Request: [PATCH] Make kio_info produce valid HTML

2012-12-09 Thread Albert Astals Cid
> On July 26, 2012, 12:53 p.m., Paul Walger wrote: > > Ship It! Was this ever commited? - Albert --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105590/#review16482 --

Re: Review Request: [PATCH] Make kio_info produce valid HTML

2012-07-22 Thread Michael Pyne
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105590/#review16236 --- Ship it! Sorry about the delay (I was away). I don't see any o

Re: Review Request: [PATCH] Make kio_info produce valid HTML

2012-07-20 Thread Paul Walger
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105590/ --- (Updated July 19, 2012, 8:21 p.m.) Review request for KDE Runtime. Chang

Re: Review Request: [PATCH] Make kio_info produce valid HTML

2012-07-17 Thread Michael Pyne
> On July 17, 2012, 2:35 a.m., Michael Pyne wrote: > > I think the current best-practice for HTML is a doctype of (and I'm not > > kidding) , which also prevents requiring a manual annotation > > of text/css later in the style sheets. However these changes (except the > > question of the missi

Re: Review Request: [PATCH] Make kio_info produce valid HTML

2012-07-17 Thread Paul Walger
> On July 17, 2012, 2:35 a.m., Michael Pyne wrote: > > I think the current best-practice for HTML is a doctype of (and I'm not > > kidding) , which also prevents requiring a manual annotation > > of text/css later in the style sheets. However these changes (except the > > question of the missi

Re: Review Request: [PATCH] Make kio_info produce valid HTML

2012-07-16 Thread Michael Pyne
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105590/#review15990 --- I think the current best-practice for HTML is a doctype of (and

Re: Review Request: [PATCH] Make kio_info produce valid HTML

2012-07-16 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105590/#review15954 --- Ship it! Ship It! - David Edmundson On July 16, 2012, 11:38

Review Request: [PATCH] Make kio_info produce valid HTML

2012-07-16 Thread Paul Walger
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105590/ --- Review request for KDE Runtime. Description --- Fixes Bug 295170. T