Re: Replacement for Qt's Undo Framework

2011-05-09 Thread Aaron J. Seigo
On Monday, May 9, 2011 13:53:55 Alexander Potashev wrote: > 2011/4/26 Aaron J. Seigo : > > it's bad practice if it can be fixed in Qt; it's not bad practice if it > > is something that doesn't belong in Qt. kdelibs should be a value-add > > extension of Qt for areas that make sense primarily/exclus

Re: Replacement for Qt's Undo Framework

2011-05-09 Thread Alexander Potashev
2011/4/26 Aaron J. Seigo : > it's bad practice if it can be fixed in Qt; it's not bad practice if it is > something that doesn't belong in Qt. kdelibs should be a value-add extension > of Qt for areas that make sense primarily/exclusively to the kinds of apps we > create and/or target. it should no

Re: Replacement for Qt's Undo Framework

2011-04-28 Thread Boudewijn Rempt
On Monday 25 April 2011 Apr, Alexander Potashev wrote: <...> Just want to say I think it's really nice to see Matus' Google Code In work noticed :-) -- Boudewijn Rempt | http://www.valdyas.org, http://www.krita.org

Re: Replacement for Qt's Undo Framework

2011-04-27 Thread Olivier Goffart
Le Tuesday 26 April 2011, Albert Astals Cid a écrit : > A Dimarts, 26 d'abril de 2011, Olivier Goffart va escriure: > > > What do you think about inclusion of KUndo*2 into kdelibs? > > > > I have not seen the details about KUndo2 yet, but what are the reasons > > that keep you from improving QUnd

Re: Replacement for Qt's Undo Framework

2011-04-26 Thread Alexander Potashev
2011/4/26 Aaron J. Seigo : > On Monday, April 25, 2011 22:12:55 Alexander Potashev wrote: >> What do you think about inclusion of KUndo*2 into kdelibs? > > we really don't want more duplication of code and effort between Qt and > kdelibs, and we certainly don't want forks of Qt code in kdelibs. > >

Re: Replacement for Qt's Undo Framework

2011-04-26 Thread Alexander Potashev
2011/4/26 Albert Astals Cid : >> I kept the arguments of UndoCommand() the same, but now if you put >> something like "Create a document|-|creation of a document" as the >> "text" into the constructor (or translate it with a similar string >> with "|-|"), you'll get "Create a document" as the name

Re: Replacement for Qt's Undo Framework

2011-04-26 Thread Albert Astals Cid
A Dimarts, 26 d'abril de 2011, Olivier Goffart va escriure: > > What do you think about inclusion of KUndo*2 into kdelibs? > > I have not seen the details about KUndo2 yet, but what are the reasons > that keep you from improving QUndo in Qt? Is there technical reasons? or > just political issue

Re: Replacement for Qt's Undo Framework

2011-04-26 Thread David Faure
On Tuesday 26 April 2011, Aaron J. Seigo wrote: > we really don't want more duplication of code and effort between Qt and > kdelibs, and we certainly don't want forks of Qt code in kdelibs. Especially after I moved the KUndoCommand/KUndoHistory classes to kde3support, after polishing them for kd

Re: Replacement for Qt's Undo Framework

2011-04-26 Thread Aaron J. Seigo
On Tuesday, April 26, 2011 07:12:32 Tom Albers wrote: > It does sound like to me as we take the base class from Qt and > improve it for usage within KDE. not if it can be improved directly in the classes in Qt itself, limiting the number of classes we have, lowering the cost of learning the comb

Re: Replacement for Qt's Undo Framework

2011-04-26 Thread Thiago Macieira
On Tuesday, 26 de April de 2011 07:12:32 Tom Albers wrote: > - Original Message - > > > On Monday, April 25, 2011 22:12:55 Alexander Potashev wrote: > > > What do you think about inclusion of KUndo*2 into kdelibs? > > > > we really don't want more duplication of code and effort between Qt

Re: Replacement for Qt's Undo Framework

2011-04-26 Thread Bèrto ëd Sèra
Tom, with all the due respect, "improve" should mean the Qt version does the job, but you have a more specific target to meet, which is alien to Qt. I'm not aware of Qt localization having defined Russian "off target", so I'd say an upstream bug is an upstream bug. That's unless Qt says they have

Re: Replacement for Qt's Undo Framework

2011-04-26 Thread Tom Albers
- Original Message - > On Monday, April 25, 2011 22:12:55 Alexander Potashev wrote: > > What do you think about inclusion of KUndo*2 into kdelibs? > > we really don't want more duplication of code and effort between Qt > and > kdelibs, and we certainly don't want forks of Qt code in kdelib

Re: Replacement for Qt's Undo Framework

2011-04-26 Thread Aaron J. Seigo
On Monday, April 25, 2011 22:12:55 Alexander Potashev wrote: > What do you think about inclusion of KUndo*2 into kdelibs? we really don't want more duplication of code and effort between Qt and kdelibs, and we certainly don't want forks of Qt code in kdelibs. please work on having this fixed in

Re: Replacement for Qt's Undo Framework

2011-04-25 Thread Olivier Goffart
Le Monday 25 April 2011, Alexander Potashev a écrit : > Hi, > > The Qt's Undo Framework (QUndoCommand, QUndoStack, QUndoGroup, > QUndoView) has a few oddities: > 1. The names of undo actions can only have a predefined prefix > (https://bugs.kde.org/show_bug.cgi?id=253459), > 2. You can't use diffe

Re: Replacement for Qt's Undo Framework

2011-04-25 Thread Albert Astals Cid
A Dilluns, 25 d'abril de 2011, Alexander Potashev va escriure: > Hi, > > The Qt's Undo Framework (QUndoCommand, QUndoStack, QUndoGroup, > QUndoView) has a few oddities: > > The solution is to fork QUndo* classes and fix the problems in the new > classes, so did I: > https://github.com/aspotashev/l

Replacement for Qt's Undo Framework

2011-04-25 Thread Alexander Potashev
Hi, The Qt's Undo Framework (QUndoCommand, QUndoStack, QUndoGroup, QUndoView) has a few oddities: 1. The names of undo actions can only have a predefined prefix (https://bugs.kde.org/show_bug.cgi?id=253459), 2. You can't use different strings for the name of undo action (Edit -> Undo/Redo [some ac