Re: Re: Review request for KSecretsService components

2011-11-09 Thread Albert Astals Cid
A Dijous, 10 de novembre de 2011, Valentin Rusu vàreu escriure: > On 11/10/2011 01:00 AM, Valentin Rusu wrote: > > On 11/10/2011 12:48 AM, Albert Astals Cid wrote: > * createItem falls in the "let's use a bool instead of an > enum > because it> > > just have tw

Re: Re: Review request for KSecretsService components

2011-11-09 Thread Albert Astals Cid
A Dijous, 10 de novembre de 2011, Valentin Rusu vàreu escriure: > On 11/10/2011 12:48 AM, Albert Astals Cid wrote: > > A Dijous, 10 de novembre de 2011, Valentin Rusu vàreu escriure: > >> Hello Albert, > >> > >> Thanks for the thourough review. > >> > >> On 11/09/2011 03:26 PM, Albert Astals Cid

Re: Review request for KSecretsService components

2011-11-09 Thread Valentin Rusu
On 11/10/2011 01:00 AM, Valentin Rusu wrote: On 11/10/2011 12:48 AM, Albert Astals Cid wrote: * createItem falls in the "let's use a bool instead of an enum because it> just have two values" trap for the replace parameter Well, I don't agree. When presenting a new item to the collec

Re: Review request for KSecretsService components

2011-11-09 Thread Valentin Rusu
On 11/10/2011 12:48 AM, Albert Astals Cid wrote: A Dijous, 10 de novembre de 2011, Valentin Rusu vàreu escriure: Hello Albert, Thanks for the thourough review. On 11/09/2011 03:26 PM, Albert Astals Cid wrote: This is scary, last time i used kwallet, i had to add a single line, and now there a

Re: Re: Review request for KSecretsService components

2011-11-09 Thread Albert Astals Cid
A Dijous, 10 de novembre de 2011, Valentin Rusu vàreu escriure: > Hello Albert, > > Thanks for the thourough review. > > On 11/09/2011 03:26 PM, Albert Astals Cid wrote: > > This is scary, last time i used kwallet, i had to add a single line, and > > now there are like a billion of classes? > >

Re: Review request for KSecretsService components

2011-11-09 Thread Valentin Rusu
Hello Albert, Thanks for the thourough review. On 11/09/2011 03:26 PM, Albert Astals Cid wrote: A Dimarts, 8 de novembre de 2011, Valentin Rusu vàreu escriure: Hello Again, The freeze will come in less thant two days now and I'd like to know if anyone reviewed these components. Thanks, On 1

Re: Re: Review request for KSecretsService components

2011-11-09 Thread Albert Astals Cid
A Dimarts, 8 de novembre de 2011, Valentin Rusu vàreu escriure: > Hello Again, > > The freeze will come in less thant two days now and I'd like to know if > anyone reviewed these components. > > Thanks, > > On 10/31/2011 11:48 PM, Valentin Rusu wrote: > > Hello, > > > > Please be advised three

Re: Review request for KSecretsService components

2011-11-08 Thread Valentin Rusu
Hello Again, The freeze will come in less thant two days now and I'd like to know if anyone reviewed these components. Thanks, On 10/31/2011 11:48 PM, Valentin Rusu wrote: Hello, Please be advised three repostories need review before integration into the next release: 1. /kdereview/ksecre