Re: Review Request: Fix Calculator keyboard key not working

2012-08-17 Thread Allen Winter
> On Aug. 9, 2012, 11:12 a.m., David Faure wrote: > > Looks like a workaround. > > > > More details posted in the bug report, let's discuss it there in order to > > include Leonardo. I see this patch was committed. Should this review be closed as submitted now? - Allen

Re: Re: Review Request: Fix Calculator keyboard key not working

2012-08-09 Thread Jos Poortvliet
On Tuesday, August 07, 2012 19:31:31 Thomas Lübking wrote: > > On Aug. 7, 2012, 6:15 p.m., Lamarque Vieira Souza wrote: > > > kdeui/util/kkeyserver_x11.cpp, line 358 > > > > > e358>> > > > > I think this will break calc

Re: Review Request: Fix Calculator keyboard key not working

2012-08-09 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105909/#review17142 --- Looks like a workaround. More details posted in the bug report

Re: Review Request: Fix Calculator keyboard key not working

2012-08-08 Thread Kai Uwe Broulik
> On Aug. 7, 2012, 6:15 p.m., Lamarque Vieira Souza wrote: > > kdeui/util/kkeyserver_x11.cpp, line 358 > > > > > > I think this will break calculator key for other users. This change > > also does not make sense, K

Re: Review Request: Fix Calculator keyboard key not working

2012-08-07 Thread Thomas Lübking
> On Aug. 7, 2012, 6:15 p.m., Lamarque Vieira Souza wrote: > > kdeui/util/kkeyserver_x11.cpp, line 358 > > > > > > I think this will break calculator key for other users. This change > > also does not make sense, K

Re: Review Request: Fix Calculator keyboard key not working

2012-08-07 Thread Lamarque Vieira Souza
> On Aug. 7, 2012, 6:15 p.m., Lamarque Vieira Souza wrote: > > kdeui/util/kkeyserver_x11.cpp, line 358 > > > > > > I think this will break calculator key for other users. This change > > also does not make sense, K

Re: Review Request: Fix Calculator keyboard key not working

2012-08-07 Thread Andreas Pakulat
> On Aug. 7, 2012, 6:15 p.m., Lamarque Vieira Souza wrote: > > kdeui/util/kkeyserver_x11.cpp, line 358 > > > > > > I think this will break calculator key for other users. This change > > also does not make sense, K

Re: Review Request: Fix Calculator keyboard key not working

2012-08-07 Thread Lamarque Vieira Souza
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105909/#review17061 --- kdeui/util/kkeyserver_x11.cpp