Re: Re: Review Request for KDecoration

2014-12-11 Thread Martin Gräßlin
On Thursday 11 December 2014 00:05:52 Albert Astals Cid wrote: > El Dimecres, 10 de desembre de 2014, a les 15:44:02, Thomas Lübking va > > escriure: > > On Mittwoch, 10. Dezember 2014 13:11:07 CEST, Christoph Feck wrote: > > > Every interactive on-screen element must have a text, either as a > >

Re: Re: Review Request for KDecoration

2014-12-09 Thread Martin Gräßlin
On Wednesday 10 December 2014 00:31:03 Thomas Lübking wrote: > On Mittwoch, 10. Dezember 2014 00:21:38 CEST, Albert Astals Cid wrote: > > Where did the strings such as > > > > "Not on all desktops" > > They were/are not part of KDecoration, but KCommonDecoration - an optional > "simplifying" wrap

Re: Re: Review Request for KDecoration

2014-12-09 Thread Martin Gräßlin
On Wednesday 10 December 2014 00:21:38 Albert Astals Cid wrote: > El Divendres, 28 de novembre de 2014, a les 15:30:23, Martin Gräßlin va > > escriure: > > On Friday 28 November 2014 15:25:03 Thomas Lübking wrote: > > > On Freitag, 28. November 2014 14:55:43 CEST, Martin Gräßlin wrote: > > > > Bot

Re: Re: Review Request for KDecoration

2014-11-28 Thread Martin Gräßlin
On Friday 28 November 2014 15:25:03 Thomas Lübking wrote: > On Freitag, 28. November 2014 14:55:43 CEST, Martin Gräßlin wrote: > > Both signals are now removed. Works like a charm with the > > handling directly in KWin. > > I foresee trouble/complicfication on this (at least limitation) > > Assum

Re: Re: Review Request for KDecoration

2014-11-28 Thread Martin Gräßlin
On Friday 28 November 2014 12:52:44 Christoph Feck wrote: > > > > Q_PROPERTY(QFont font > > > > > > When I want to compute pixel sizes for the requested font, how > > > do I get the correct QPaintDevice needed for the QFontMetrics? > > > Otherwise, please provide a QFontMetrics (see QStyleOption).

Re: Re: Re: Review Request for KDecoration

2014-11-28 Thread Martin Gräßlin
Martin GräßlinOn Friday 28 November 2014 12:00:43 wrote: > > >void titleBarDoubleClicked(); > > > > Maybe it might sense to have the event here, to check keyboard > > modifiers? > > > > >void titleBarWheelEvent(const QPoint &angleDelta); > > > > Why not simply pass the QWheelEvent? I mi

Re: Re: Review Request for KDecoration

2014-11-28 Thread Martin Gräßlin
On Friday 28 November 2014 13:53:07 Sebastian Kügler wrote: > On Friday, November 28, 2014 12:00:43 Martin Gräßlin wrote: > > > Given that you call it "fundamental", I suggest to allow qreal here. > > > A "millimeter" is really small, and if you only allow integer values, > > > the precision might

Re: Re: Review Request for KDecoration

2014-11-28 Thread Martin Gräßlin
On Sunday 16 November 2014 23:30:35 Christoph Feck wrote: > On Friday 31 October 2014 08:22:53 Martin Gräßlin wrote: > > today I want to start the review process for the new KDecoration > > Hi Martin, > > thanks for the work, here are some random comments from my side. I > hope I am not too late.

Re: Re: Review Request for KDecoration

2014-11-04 Thread Martin Gräßlin
On Tuesday 04 November 2014 13:40:30 Milian Wolff wrote: > > I'd rather stress "notice that the return value can be nullptr and change > > during the lifetime of the DecoratedClient". > > > > The user can still do > > Decoration *m_deco = m_client->decoration(); // fails at some point > > > > Ove

Re: Re: Review Request for KDecoration

2014-11-04 Thread Martin Gräßlin
On Monday 03 November 2014 23:33:15 Milian Wolff wrote: > On Friday 31 October 2014 08:22:53 Martin Gräßlin wrote: > > Hi KDE core developers, > > > > today I want to start the review process for the new KDecoration > > library[1]. This library is intended to replace the window decoration > > libr

Re: Re: Review Request for KDecoration

2014-11-03 Thread Martin Gräßlin
On Monday 03 November 2014 22:29:22 Albert Astals Cid wrote: > El Divendres, 31 d'octubre de 2014, a les 08:22:53, Martin Gräßlin va > > escriure: > > Hi KDE core developers, > > > > today I want to start the review process for the new KDecoration > > library[1]. This library is intended to repla