Re: QDialog on stack+exec and dbus quit crash is no more

2014-07-09 Thread Albert Astals Cid
El Dimecres, 9 de juliol de 2014, a les 10:58:50, David Faure va escriure: > On Thursday 12 December 2013 20:01:42 Albert Astals Cid wrote: > > El Dijous, 12 de desembre de 2013, a les 19:57:25, David Faure va escriure: > > > On Monday 11 November 2013 21:04:35 Jan Kundrát wrote: > > > > On Monday

Re: QDialog on stack+exec and dbus quit crash is no more

2014-07-09 Thread Milian Wolff
On Wednesday 09 July 2014 10:58:50 David Faure wrote: > On Thursday 12 December 2013 20:01:42 Albert Astals Cid wrote: > > El Dijous, 12 de desembre de 2013, a les 19:57:25, David Faure va escriure: > > > On Monday 11 November 2013 21:04:35 Jan Kundrát wrote: > > > > On Monday, 11 November 2013 19

Re: QDialog on stack+exec and dbus quit crash is no more

2014-07-09 Thread David Faure
On Thursday 12 December 2013 20:01:42 Albert Astals Cid wrote: > El Dijous, 12 de desembre de 2013, a les 19:57:25, David Faure va escriure: > > On Monday 11 November 2013 21:04:35 Jan Kundrát wrote: > > > On Monday, 11 November 2013 19:17:22 CEST, Albert Astals Cid wrote: > > > > Not sure you're u

Re: QDialog on stack+exec and dbus quit crash is no more

2013-12-12 Thread David Faure
On Monday 11 November 2013 21:04:35 Jan Kundrát wrote: > On Monday, 11 November 2013 19:17:22 CEST, Albert Astals Cid wrote: > > Not sure you're understanding what i say, we have an explicit check about > > QDialog on stack+exec that says "it will crash if you dbus quit". > > We've chatted about t

Re: QDialog on stack+exec and dbus quit crash is no more

2013-12-12 Thread Albert Astals Cid
El Dijous, 12 de desembre de 2013, a les 19:57:25, David Faure va escriure: > On Monday 11 November 2013 21:04:35 Jan Kundrát wrote: > > On Monday, 11 November 2013 19:17:22 CEST, Albert Astals Cid wrote: > > > Not sure you're understanding what i say, we have an explicit check > > > about > > > QD

Re: QDialog on stack+exec and dbus quit crash is no more

2013-11-15 Thread Jan Kundrát
On Thursday, 14 November 2013 22:02:09 CEST, Michael Reeves wrote: That link is broken. Try this one -- it's from valgrind, not the gdb, but it points to the actual problem: http://kde.6490.n7.nabble.com/QDialog-on-stack-exec-and-dbus-quit-crash-is-no-more-tp1549181p1549244.html C

Re: QDialog on stack+exec and dbus quit crash is no more

2013-11-15 Thread Michael Reeves
On Monday, November 11, 2013 9:22:57 PM Albert Astals Cid wrote: > El Dilluns, 11 de novembre de 2013, a les 19:36:45, Kevin Krammer va escriure: > Of course one can say that the crash in [1] is a bug that someone will fix, > any taker? > > Cheers, > Albert > > [1] http://pastebin.kde.org/pol

Re: QDialog on stack+exec and dbus quit crash is no more

2013-11-11 Thread Albert Astals Cid
El Dilluns, 11 de novembre de 2013, a les 19:36:45, Kevin Krammer va escriure: > On Monday, 2013-11-11, 19:17:22, Albert Astals Cid wrote: > > El Diumenge, 10 de novembre de 2013, a les 15:45:42, Jan Kundrát va > > > > > I've wasted my fair share of time on this in Trojita where we disconnect > >

Re: QDialog on stack+exec and dbus quit crash is no more

2013-11-11 Thread Jan Kundrát
On Monday, 11 November 2013 19:17:22 CEST, Albert Astals Cid wrote: Not sure you're understanding what i say, we have an explicit check about QDialog on stack+exec that says "it will crash if you dbus quit". We've chatted about this with Albert on IRC. My understanding of this is that there ar

Re: QDialog on stack+exec and dbus quit crash is no more

2013-11-11 Thread Thomas Lübking
On Montag, 11. November 2013 19:17:22 CEST, Albert Astals Cid wrote: Not sure you're understanding what i say, we have an explicit check about QDialog on stack+exec that says "it will crash if you dbus quit". What I'm saying is that this doesn't happen anymore and we should remove that check.

Re: QDialog on stack+exec and dbus quit crash is no more

2013-11-11 Thread Kevin Krammer
On Monday, 2013-11-11, 19:17:22, Albert Astals Cid wrote: > El Diumenge, 10 de novembre de 2013, a les 15:45:42, Jan Kundrát va > > I've wasted my fair share of time on this in Trojita where we disconnect > > from the IMAP server upon seeing a network error. This, naturally, leads > > to > > free

Re: QDialog on stack+exec and dbus quit crash is no more

2013-11-11 Thread Albert Astals Cid
El Diumenge, 10 de novembre de 2013, a les 15:45:42, Jan Kundrát va escriure: > On Saturday, 9 November 2013 23:45:20 CEST, Albert Astals Cid wrote: > > But I don't think that's a problem anymore. I tried to crash it > > by doing what > > the blog says and it doesn't crash, and after having a look

Re: QDialog on stack+exec and dbus quit crash is no more

2013-11-10 Thread Jan Kundrát
On Saturday, 9 November 2013 23:45:20 CEST, Albert Astals Cid wrote: But I don't think that's a problem anymore. I tried to crash it by doing what the blog says and it doesn't crash, and after having a look at the KApplication::quit code that calls QCoreApplication::quit() code I think that t

QDialog on stack+exec and dbus quit crash is no more

2013-11-09 Thread Albert Astals Cid
So in the EBN checks we are checking for places where we create QDailog on the stack and then call exec and suggesting to replace them with a QPointer QDialog, see http://ebn.kde.org/krazy/reports/kde-4.x/kdegames/kmines/index.html and http://blogs.kde.org/node/3919 So people are trying to do