Re: New repo in kdereview: KRecorder

2022-12-07 Thread Nate Graham
Thanks for all the hard work, Devin. Looks great now! +1 from me. Nate On 12/7/22 22:21, Devin wrote: Here are my audio settings: https://i.imgur.com/8YqR82x.jpg I've adjusted the settings for vorbis visualization which *should* be better now. I think the way the visualization is calculate

Re: New repo in kdereview: KRecorder

2022-12-07 Thread Devin
> Here are my audio settings: https://i.imgur.com/8YqR82x.jpg I've adjusted the settings for vorbis visualization which *should* be better now. I think the way the visualization is calculated probably needs to be more sophisticated eventually to be smoother. > I think I found the problem; I use 1

Re: New repo in kdereview: KRecorder

2022-12-05 Thread Nate Graham
On 12/4/22 16:47, Devin wrote: I can reproduce it in the following way on Desktop: Hmm, I'm on Kirigami from master and still can't reproduce it, see the attached video. I think I found the problem; I use 11pt Noto Sans font. I can't reproduce the issue with the default 10pt. This probably p

Re: New repo in kdereview: KRecorder

2022-11-28 Thread Nate Graham
On 11/24/22 16:32, Devin wrote: I can still see this: https://i.imgur.com/MrrwyAo.jpg No matter how I try to resize the window, I can't seem to reproduce the issue... weird I can reproduce it in the following way on Desktop: 1. Start with the window in a wide state, in two-pane view 2. Resize

Re: New repo in kdereview: KRecorder

2022-11-24 Thread Devin
> I can still see this: https://i.imgur.com/MrrwyAo.jpg No matter how I try to resize the window, I can't seem to reproduce the issue... weird > When I look at other platforms, what I see is that it's common and > traditional for the *record* button to be a red circle, but the stop button > is

Re: New repo in kdereview: KRecorder

2022-11-14 Thread Nate Graham
Much better! Most issues are fixed now. I feel like we're close. See a few remaining comments: The left pane's placeholder message is off-center with narrow windows. Fixed. I can still see this: https://i.imgur.com/MrrwyAo.jpg On the recording page, the "stop recording" button is red w

Re: New repo in kdereview: KRecorder

2022-11-09 Thread Devin
Hi Nate, I've done some work on addressing the feedback: > The app should have a Bugzilla component and its "Report a bug" button should > take users there, as we have been migrating towards for other mobile apps > recently. Resolved > When I open the app for the first time on the desktop, I

Re: New repo in kdereview: KRecorder

2022-10-26 Thread Nate Graham
Pretty nice app. The app should have a Bugzilla component and its "Report a bug" button should take users there, as we have been migrating towards for other mobile apps recently. Some UI review now: When I open the app for the first time on the desktop, I get a mobile-specific floating a

Re: New repo in kdereview: KRecorder

2022-10-26 Thread Devin
Any other comments or issues to address? Thanks, Devin On Fri, Oct 21, 2022 at 6:21 PM Albert Astals Cid wrote: > > El divendres, 21 d’octubre de 2022, a les 23:55:28 (CEST), Devin va escriure: > > > make install doesn't install any icon for me with the current master. > > > > I just checked and

Re: New repo in kdereview: KRecorder

2022-10-21 Thread Albert Astals Cid
El divendres, 21 d’octubre de 2022, a les 23:55:28 (CEST), Devin va escriure: > > make install doesn't install any icon for me with the current master. > > I just checked and indeed, the method I changed to using > ecm_install_icons doesn't seem to have the behaviour I thought it did. > I hadn't v

Re: New repo in kdereview: KRecorder

2022-10-21 Thread Devin
> make install doesn't install any icon for me with the current master. I just checked and indeed, the method I changed to using ecm_install_icons doesn't seem to have the behaviour I thought it did. I hadn't verified it properly because the icon was already preinstalled for me. I reverted to the

Re: New repo in kdereview: KRecorder

2022-10-21 Thread Albert Astals Cid
El divendres, 21 d’octubre de 2022, a les 23:00:46 (CEST), Devin va escriure: > > The app doesn't have an icon when run in X11 > > Hmm, the location the icon installed to might be non-standard. I think > I've fixed it on master now by copying the way other KDE apps install > the icon. make instal

Re: New repo in kdereview: KRecorder

2022-10-21 Thread Devin
> Why the mov vs ogg dance? Seems to have been a bug with the saved audio format not getting applied until the settings model was initialized (in this case, when the dialog opened). It has been fixed now, thanks! > The app doesn't have an icon when run in X11 Hmm, the location the icon installed

Re: New repo in kdereview: KRecorder

2022-10-21 Thread Albert Astals Cid
El divendres, 21 d’octubre de 2022, a les 4:25:44 (CEST), Devin va escriure: > Hi everyone, > > There will be some Plasma Mobile Gear applications going through here since > it seems some did not make it through kdereview. Our eventual goal is to > hopefully move them to the KDE Gear release :) >

New repo in kdereview: KRecorder

2022-10-20 Thread Devin
Hi everyone, There will be some Plasma Mobile Gear applications going through here since it seems some did not make it through kdereview. Our eventual goal is to hopefully move them to the KDE Gear release :) I would like to put krecorder through kdereview: https://invent.kde.org/plasma-mobile/k