Re: Moving plasma-nm to extragear

2014-06-11 Thread Jan Grulich
Hi, the two week period for review has passed, so I guess we are able to move plasma-nm to kde-workspace. Is there anyone who disagree with this? I'll wait for a few days and then fill a new ticket. Thanks. Cheers, Jan -- Jan Grulich Red Hat Czech, s.r.o jgrul...@redhat.com On Tuesday 27 of

Re: Moving plasma-nm to extragear

2014-06-07 Thread Jan Grulich
Hi, thanks for the quick review. On Friday 06 of June 2014 22:01 you wrote: > El Dimarts, 27 de maig de 2014, a les 20:41:23, Jan Grulich va escriure: > > Hi, > > > > we would like to move plasma-nm to extragear/base and ask you for a > > review. > > Looks like in these i18n calls you should us

Re: Moving plasma-nm to extragear

2014-06-06 Thread Albert Astals Cid
El Dimarts, 27 de maig de 2014, a les 20:41:23, Jan Grulich va escriure: > Hi, > > we would like to move plasma-nm to extragear/base and ask you for a review. Looks like in these i18n calls you should use proper argument placement and not "+" return i18n("Connected") + ", ⬇ " + Download + ", ⬆

Re: Moving plasma-nm to extragear

2014-05-30 Thread Sebastian Kügler
On Friday, May 30, 2014 10:31:37 Lamarque Souza wrote: > I agree that Plasma NM should go to kde/workspace. In the past the only > thing that prevented that was the fact that we needed to change > translatable strings from time to time, which obviously does not comply > with the string freeze. Now

Re: Moving plasma-nm to extragear

2014-05-30 Thread Jan Grulich
Hi, I agree too, it would be probably better be part of kde/workspace, also plasma-nm is not changing that much these days, so it should be fine. Jan -- Jan Grulich Red Hat Czech, s.r.o jgrul...@redhat.com On Friday 30 of May 2014 10:31 Lamarque Souza wrote: > Hi all, > > I agree that Plasm

Re: Moving plasma-nm to extragear

2014-05-30 Thread Lamarque Souza
Hi all, I agree that Plasma NM should go to kde/workspace. In the past the only thing that prevented that was the fact that we needed to change translatable strings from time to time, which obviously does not comply with the string freeze. Now that kde/workspace is released more often that should

Re: Moving plasma-nm to extragear

2014-05-30 Thread Aleix Pol
On Tue, May 27, 2014 at 8:41 PM, Jan Grulich wrote: > Hi, > > we would like to move plasma-nm to extragear/base and ask you for a review. > > Plasma-nm is a new applet written in QML for managing network connections > and > contains a few parts: > > 1) applet - plasma applet which allows you to c

Moving plasma-nm to extragear

2014-05-28 Thread Jan Grulich
Hi, we would like to move plasma-nm to extragear/base and ask you for a review. Plasma-nm is a new applet written in QML for managing network connections and contains a few parts: 1) applet - plasma applet which allows you to connect/disconnect your connections 2) editor - application allows