Re: Moving Baloo and Baloo-widgets into KDE SC

2014-01-21 Thread Vishesh Handa
On Tuesday 21 January 2014 12:34:52 Todd wrote: > > From what I read on the baloo page, it seems likes baloo accesses various > databases. If that is the case, instead of a bridge that copies metadata > back and forth like in nepomuk, would it be possible for programs like > Digikam and Amarok to

Re: Moving Baloo and Baloo-widgets into KDE SC

2014-01-21 Thread Todd
On Fri, Jan 10, 2014 at 11:02 AM, Mario Fux KDE ML wrote: > Am Donnerstag, 09. Januar 2014, 23.26:01 schrieb Àlex Fiestas: > > Morning Alex > > > On Thursday 09 January 2014 21:52:52 Christoph Feck wrote: > > > But if the above scenario does not work, we should probably not > > > introduce Baloo f

Re: Moving Baloo and Baloo-widgets into KDE SC

2014-01-20 Thread Vishesh Handa
On Sunday 19 January 2014 15:56:17 David Edmundson wrote: > Code Review of baloo/file/lib > > ==file.cpp > > Should it override type() from Item and set it to "File" ? > I'll probably removing this whole type thing. I'm not sure. > > ==filemodifyjob.cpp. > > The code won't unset a rating, co

Re: Moving Baloo and Baloo-widgets into KDE SC

2014-01-19 Thread Ivan Čukić
> Ideally this would be exposed in the File object, maybe with some sort > of QVariantMap userProperties() method. Please don't make it load all attributes and values into the memory if the most common use-case is to load a value for a desired key. I'd rather go for something like some_iterat

Re: Moving Baloo and Baloo-widgets into KDE SC

2014-01-19 Thread David Edmundson
This doesn't need to be be in the first release but I would like an exposed Qt interface to fsetxattrs and xgetxattrs. Ideally this would be exposed in the File object, maybe with some sort of QVariantMap userProperties() method. FileFetchJob would then load all the properties in the same way rat

Re: Moving Baloo and Baloo-widgets into KDE SC

2014-01-19 Thread David Edmundson
Code Review of baloo/file/lib ==file.cpp Should it override type() from Item and set it to "File" ? ==filemodifyjob.cpp. The code won't unset a rating, comments or tags on multiple files. You update Xapian ok, but you're not calling fsetxattr(). The d pointer leaks? ==DB.cpp SQLITE3-> SQLIT

Re: Moving Baloo and Baloo-widgets into KDE SC

2014-01-17 Thread Vishesh Handa
On Friday 17 January 2014 11:54:06 Mario Fux KDE ML wrote: > Am Freitag, 10. Januar 2014, 11.28:34 schrieb Sebastian Kügler: > > Hey, > > Morning sebas and Co > > Here finally my answer to this thread. > > [snip] > > > > - Digikam (gets new Nepomuk with 4.0.0 due in May or so. Will it work)? >

Re: Moving Baloo and Baloo-widgets into KDE SC

2014-01-17 Thread Mario Fux KDE ML
Am Freitag, 10. Januar 2014, 11.28:34 schrieb Sebastian Kügler: > Hey, Morning sebas and Co Here finally my answer to this thread. [snip] > > - Digikam (gets new Nepomuk with 4.0.0 due in May or so. Will it work)? > > Maybe this feature is worth delaying then? Is anybody of the Digikam team r

Re: Moving Baloo and Baloo-widgets into KDE SC

2014-01-12 Thread Thomas Lübking
On Sonntag, 12. Januar 2014 12:28:09 CEST, Vishesh Handa wrote: How should one go about this? Dot article? An article on dot will help, but it's not important where the information is hosted. What is important is that it has the character of an official press release. a) It has to show up in

Re: Moving Baloo and Baloo-widgets into KDE SC

2014-01-12 Thread Vishesh Handa
On Friday 10 Jan 2014 18:17:48 Thomas Lübking wrote: > On Freitag, 10. Januar 2014 11:28:34 CEST, Sebastian Kügler wrote: > > with the long > > term support workspace out, so we can recommend people to use > > that, if they're slightly more adventurous, run 4.13 > > I'm not sure whether I understa

Re: Moving Baloo and Baloo-widgets into KDE SC

2014-01-10 Thread Thomas Lübking
On Freitag, 10. Januar 2014 11:28:34 CEST, Sebastian Kügler wrote: with the long term support workspace out, so we can recommend people to use that, if they're slightly more adventurous, run 4.13 I'm not sure whether I understand that - afaiu there will be no workspace > 4.11 ever, but other

Re: Moving Baloo and Baloo-widgets into KDE SC

2014-01-10 Thread David Edmundson
On Fri, Jan 10, 2014 at 1:22 PM, Jan Kundrát wrote: > On Friday, 10 January 2014 11:02:22 CEST, Mario Fux KDE ML wrote: >> >> - KPhotoalbum > > > The only reason why KPhotoAlbum links with Nepomuk is because of the rating > widget ("the five stars in a row") which lives in a Nepomuk-provided > lib

Re: Moving Baloo and Baloo-widgets into KDE SC

2014-01-10 Thread Jan Kundrát
On Friday, 10 January 2014 11:02:22 CEST, Mario Fux KDE ML wrote: - KPhotoalbum The only reason why KPhotoAlbum links with Nepomuk is because of the rating widget ("the five stars in a row") which lives in a Nepomuk-provided library. *Nothing* has been stored in a Nepomuk DB form inside KPA,

Re: Moving Baloo and Baloo-widgets into KDE SC

2014-01-10 Thread Vishesh Handa
On Friday 10 Jan 2014 11:02:22 Mario Fux KDE ML wrote: > > IIRC it's still not clear for all the current Nepomuk apps if they work > after 4.13. Let's try to list them again. > > - Amarok (got Nepomuk support with 2.7, will it work after 4.13? No. It will not. There is no way this can be ported.

Re: Moving Baloo and Baloo-widgets into KDE SC

2014-01-10 Thread Vishesh Handa
On Friday 10 Jan 2014 12:07:04 Shantanu Tushar Jha wrote: > On Fri, Jan 10, 2014 at 3:56 AM, Àlex Fiestas wrote: > > On Thursday 09 January 2014 21:52:52 Christoph Feck wrote: > > > But if the above scenario does not work, we should probably not > > > introduce Baloo for KDE SC 4.x. > > > > I hav

Re: Moving Baloo and Baloo-widgets into KDE SC

2014-01-10 Thread Sebastian Kügler
Hey, On Friday, January 10, 2014 11:02:22 Mario Fux KDE ML wrote: > Am Donnerstag, 09. Januar 2014, 23.26:01 schrieb Àlex Fiestas: > > If the breakage is minimal (which I know it is, but I will let vHanda > > reply > > to that) I vote to replace it even if we make a bit worse the experience > > u

Re: Moving Baloo and Baloo-widgets into KDE SC

2014-01-10 Thread Mario Fux KDE ML
Am Donnerstag, 09. Januar 2014, 23.26:01 schrieb Àlex Fiestas: Morning Alex > On Thursday 09 January 2014 21:52:52 Christoph Feck wrote: > > But if the above scenario does not work, we should probably not > > introduce Baloo for KDE SC 4.x. > > I have to disagree here. And I'm probably disagree

Re: Moving Baloo and Baloo-widgets into KDE SC

2014-01-10 Thread Shantanu Tushar Jha
On Fri, Jan 10, 2014 at 3:56 AM, Àlex Fiestas wrote: > On Thursday 09 January 2014 21:52:52 Christoph Feck wrote: > > But if the above scenario does not work, we should probably not > > introduce Baloo for KDE SC 4.x. > > I have to disagree here. > > We can't keep playing this conservative when w

Re: Moving Baloo and Baloo-widgets into KDE SC

2014-01-10 Thread Vishesh Handa
On Thursday 09 Jan 2014 21:52:52 Christoph Feck wrote: > On Thursday 09 January 2014 13:42:12 Vishesh Handa wrote: > > Rough Update - > > > > The migrator has been written and tested for files. The tags, > > rating, comments and indexing configuration are properly migrated. > > Is this a one-time

Re: Moving Baloo and Baloo-widgets into KDE SC

2014-01-09 Thread Àlex Fiestas
On Thursday 09 January 2014 21:52:52 Christoph Feck wrote: > But if the above scenario does not work, we should probably not > introduce Baloo for KDE SC 4.x. I have to disagree here. We can't keep playing this conservative when we have things that are in the Nepomuk situation. If it is the most

Re: Moving Baloo and Baloo-widgets into KDE SC

2014-01-09 Thread Christoph Feck
On Thursday 09 January 2014 13:42:12 Vishesh Handa wrote: > Rough Update - > > The migrator has been written and tested for files. The tags, > rating, comments and indexing configuration are properly migrated. Is this a one-time migration, or continuous migration? In other words, if a user tags

Re: Moving Baloo and Baloo-widgets into KDE SC

2014-01-09 Thread Vishesh Handa
On Wednesday 25 Dec 2013 23:49:12 Albert Astals Cid wrote: > > Please use a KCatalogLoader (and while at it fix it for nepomuk-widgets too Fixed -- Vishesh Handa

Re: Moving Baloo and Baloo-widgets into KDE SC

2014-01-09 Thread Vishesh Handa
Rough Update - The migrator has been written and tested for files. The tags, rating, comments and indexing configuration are properly migrated. Considering that certain applications are still going to continue using Nepomuk for sometime. The plan is to move most of kde-runtime/nepomuk into its

Re: Moving Baloo and Baloo-widgets into KDE SC

2013-12-31 Thread Shantanu Tushar Jha
Though not listed, plasma-mediacenter will move to baloo as soon as it gets a stable release. This is also a great excuse for us to spend time in fixing the tight coupling between our media collection logic and Nepomuk. On Fri, Dec 27, 2013 at 6:13 PM, Albert Astals Cid wrote: > El Divendres, 2

Re: Moving Baloo and Baloo-widgets into KDE SC

2013-12-30 Thread andrea diamantini
2013/12/27 Albert Astals Cid > What about the users of: > rekonq > I'll be happy to move to Baloo in the upcoming KF5 series. Rekonq just uses Nepomuk to tag/rate bookmarks. I'll just need some explanations about moving the actual info. Cheers, -- Andrea Diamantini WEB: http://www.adjam.or

Re: Moving Baloo and Baloo-widgets into KDE SC

2013-12-27 Thread Jan Kundrát
On Friday, 27 December 2013 13:43:50 CEST, Albert Astals Cid wrote: kphotoalbum Unless I'm terribly mistaken, KPhotoAlbum uses just the stars widget. The actual rating is saved in its own DB. We do care about the backwards compatibility, though, which means that a released tarball needs to

Re: Moving Baloo and Baloo-widgets into KDE SC

2013-12-27 Thread Àlex Fiestas
On Friday 27 December 2013 18:31:19 Ivan Čukić wrote: > > The most notorious exceptions are to this rule are nepgoogle and webminer. > > Maintainers of both projects are already working on porting them to Baloo. > > This I like. > > Baloo seems to be working very nice (I've been running it for so

Re: Moving Baloo and Baloo-widgets into KDE SC

2013-12-27 Thread Àlex Fiestas
On Friday 27 December 2013 18:45:09 Martin Graesslin wrote: > On Friday 27 December 2013 18:31:19 Ivan Čukić wrote: > > It just *needs* to be smooth and stable. It would be awful if the first > > impression of baloo was the same as with the first releases of plasma and > > nepomuk. > > Maybe the N

Re: Moving Baloo and Baloo-widgets into KDE SC

2013-12-27 Thread Martin Graesslin
On Friday 27 December 2013 18:31:19 Ivan Čukić wrote: > It just *needs* to be smooth and stable. It would be awful if the first > impression of baloo was the same as with the first releases of plasma and > nepomuk. Maybe the Nepomuk/Baloo developers could think about a fallback plan in case proble

Re: Moving Baloo and Baloo-widgets into KDE SC

2013-12-27 Thread Ivan Čukić
> The most notorious exceptions are to this rule are nepgoogle and webminer. > Maintainers of both projects are already working on porting them to Baloo. This I like. Baloo seems to be working very nice (I've been running it for some time now), so if all clients are being ported, then I have no

Re: Moving Baloo and Baloo-widgets into KDE SC

2013-12-27 Thread Àlex Fiestas
On Wednesday 25 December 2013 01:13:33 Ivan Čukić wrote: > On Tuesday, 24. December 2013. 22.03.28 Àlex Fiestas wrote: > > As I see it, the nepomuk maintainer says it works better than Nepomuk for > > all cases covered by SC. I don't see any reason not to move forward then. > > The truthfulness of

Re: Moving Baloo and Baloo-widgets into KDE SC

2013-12-27 Thread Àlex Fiestas
On Tuesday 24 December 2013 23:32:27 Thomas Lübking wrote: > On Dienstag, 24. Dezember 2013 22:03:28 CEST, Àlex Fiestas wrote: > > On Tuesday 24 December 2013 21:25:37 Ivan Čukić wrote: > >> I would like baloo to be available in 4.x, with no API > >> stability guarantees, ... > > > > As I see it,

Re: Moving Baloo and Baloo-widgets into KDE SC

2013-12-27 Thread Àlex Fiestas
On Friday 27 December 2013 13:43:50 Albert Astals Cid wrote: > El Divendres, 27 de desembre de 2013, a les 13:24:14, Vishesh Handa va > > escriure: > > On Wednesday 25 Dec 2013 23:43:20 Albert Astals Cid wrote: > > > The pim agent Messages.sh catalog name is wrong as discussed on IRC. > > > > Fix

Re: Moving Baloo and Baloo-widgets into KDE SC

2013-12-27 Thread Albert Astals Cid
El Divendres, 27 de desembre de 2013, a les 13:24:14, Vishesh Handa va escriure: > On Wednesday 25 Dec 2013 23:43:20 Albert Astals Cid wrote: > > The pim agent Messages.sh catalog name is wrong as discussed on IRC. > > Fixed > > > balooshow and baloosearch are missing Messages.sh > > Fixed > >

Re: Moving Baloo and Baloo-widgets into KDE SC

2013-12-27 Thread Vishesh Handa
On Wednesday 25 Dec 2013 23:43:20 Albert Astals Cid wrote: > > The pim agent Messages.sh catalog name is wrong as discussed on IRC. Fixed > > balooshow and baloosearch are missing Messages.sh Fixed > > kio_tags is duplicated. What's the plan for it? Kill the old one? In that > case, can the

Re: Moving Baloo and Baloo-widgets into KDE SC

2013-12-25 Thread Albert Astals Cid
El Dimarts, 24 de desembre de 2013, a les 11:28:11, Vishesh Handa va escriure: > Hey guys > > I would like to move Baloo and Baloo-widgets into KDE SC soon. It would be > nice if someone could review the code. Both the projects are in kdereview. baloo-widgets does not load it's catalog message an

Re: Moving Baloo and Baloo-widgets into KDE SC

2013-12-25 Thread Albert Astals Cid
El Dimarts, 24 de desembre de 2013, a les 11:28:11, Vishesh Handa va escriure: > Hey guys > > I would like to move Baloo and Baloo-widgets into KDE SC soon. It would be > nice if someone could review the code. Both the projects are in kdereview. The pim agent Messages.sh catalog name is wrong as

Re: Moving Baloo and Baloo-widgets into KDE SC

2013-12-25 Thread David Edmundson
On Wed, Dec 25, 2013 at 10:15 PM, Thomas Lübking wrote: > On Mittwoch, 25. Dezember 2013 21:06:56 CEST, David Edmundson wrote: > >> With the planned slow transition of apps from kdelibs4 to frameworks >> we are going to have a point where we have apps on either side. >> I expect Dolphin to port ve

Re: Moving Baloo and Baloo-widgets into KDE SC

2013-12-25 Thread Thomas Lübking
On Mittwoch, 25. Dezember 2013 21:06:56 CEST, David Edmundson wrote: With the planned slow transition of apps from kdelibs4 to frameworks we are going to have a point where we have apps on either side. I expect Dolphin to port very soon, KMail isn't planned for a long time as KDE PIM libs are to

Re: Moving Baloo and Baloo-widgets into KDE SC

2013-12-25 Thread David Edmundson
Vishesh, Review of the folder "core" itemtype.h is useless. - it is not namespaced and it doesn't do anything. datastore.h - it's public, so should use a d-pointer. query.cpp - you don't delete d ? - there's a few things still TODO result.h does it make sense to use Baloo::Item::Id inste

Re: Moving Baloo and Baloo-widgets into KDE SC

2013-12-25 Thread David Edmundson
On Tue, Dec 24, 2013 at 11:32 PM, Thomas Lübking wrote: > On Dienstag, 24. Dezember 2013 22:03:28 CEST, Àlex Fiestas wrote: >> >> On Tuesday 24 December 2013 21:25:37 Ivan Čukić wrote: > > > The point is, that you virtually cannot make a release that breaks half the > former nepomuk clients. > You

Re: Moving Baloo and Baloo-widgets into KDE SC

2013-12-24 Thread Ivan Čukić
On Tuesday, 24. December 2013. 22.03.28 Àlex Fiestas wrote: > As I see it, the nepomuk maintainer says it works better than Nepomuk for > all cases covered by SC. I don't see any reason not to move forward then. The truthfulness of Vishesh's claim does not enter into it. If we believe it (and I d

Re: Moving Baloo and Baloo-widgets into KDE SC

2013-12-24 Thread Thomas Lübking
On Dienstag, 24. Dezember 2013 22:03:28 CEST, Àlex Fiestas wrote: On Tuesday 24 December 2013 21:25:37 Ivan Čukić wrote: I would like baloo to be available in 4.x, with no API stability guarantees, ... As I see it, the nepomuk maintainer says it works better than Nepomuk for all cases cove

Re: Moving Baloo and Baloo-widgets into KDE SC

2013-12-24 Thread Àlex Fiestas
On Tuesday 24 December 2013 19:57:17 Thomas Lübking wrote: > On Dienstag, 24. Dezember 2013 19:29:11 CEST, Vishesh Handa wrote: > > On Tuesday 24 Dec 2013 13:06:55 Christoph Feck wrote: > >> How does Baloo cooperate with Nepomuk? Note that we have ABI > >> guarantees, so if the metadata is not shar

Re: Moving Baloo and Baloo-widgets into KDE SC

2013-12-24 Thread Àlex Fiestas
On Tuesday 24 December 2013 21:25:37 Ivan Čukić wrote: > > As I understand it there are no plans to remove the nepomuk-core or > > nepomuk-widget libraries. If you switch to Baloo, anything compiled > > against > > nepomuk will still run but will act as if nepomuk is disabled. This is > > something

Re: Moving Baloo and Baloo-widgets into KDE SC

2013-12-24 Thread Ivan Čukić
> As I understand it there are no plans to remove the nepomuk-core or > nepomuk-widget libraries. If you switch to Baloo, anything compiled against > nepomuk will still run but will act as if nepomuk is disabled. This is > something clients previously had to cope with anyway. Meaning that everyth

Re: Moving Baloo and Baloo-widgets into KDE SC

2013-12-24 Thread David Edmundson
On 24 Dec 2013 18:57, "Thomas Lübking" wrote: > > On Dienstag, 24. Dezember 2013 19:29:11 CEST, Vishesh Handa wrote: >> >> On Tuesday 24 Dec 2013 13:06:55 Christoph Feck wrote: >>> >>> How does Baloo cooperate with Nepomuk? Note that we have ABI >>> guarantees, so if the metadata is not shared bet

Re: Moving Baloo and Baloo-widgets into KDE SC

2013-12-24 Thread Thomas Lübking
On Dienstag, 24. Dezember 2013 19:29:11 CEST, Vishesh Handa wrote: On Tuesday 24 Dec 2013 13:06:55 Christoph Feck wrote: How does Baloo cooperate with Nepomuk? Note that we have ABI guarantees, so if the metadata is not shared between running instances of two services, but applications would hav

Re: Moving Baloo and Baloo-widgets into KDE SC

2013-12-24 Thread Vishesh Handa
On Tuesday 24 Dec 2013 13:06:55 Christoph Feck wrote: > How does Baloo cooperate with Nepomuk? Note that we have ABI > guarantees, so if the metadata is not shared between running instances > of two services, but applications would have to be ported to the new > ABI, then you cannot introduce Baloo

Re: Moving Baloo and Baloo-widgets into KDE SC

2013-12-24 Thread Christoph Feck
On Tuesday 24 December 2013 11:28:11 Vishesh Handa wrote: > Hey guys > > I would like to move Baloo and Baloo-widgets into KDE SC soon. It > would be nice if someone could review the code. Both the projects > are in kdereview. > > Baloo is a metadata and search framework which is a successor to >

Moving Baloo and Baloo-widgets into KDE SC

2013-12-24 Thread Vishesh Handa
Hey guys I would like to move Baloo and Baloo-widgets into KDE SC soon. It would be nice if someone could review the code. Both the projects are in kdereview. Baloo is a metadata and search framework which is a successor to the Nepomuk project. It primarily provides - * An API for searching *