Re: MauiKit and Index review

2020-12-01 Thread Carl Schwan
Le lundi, septembre 28, 2020 9:02 AM, Camilo Higuita Rodriguez a écrit : Hi, some feedback: Index looks visually really nice, great job on that front :) In term of technical review: * There are tons of clazy warning in your codebase: I fixed some of them in [1] but there are more of them

Re: MauiKit and Index review

2020-09-30 Thread Camilo Higuita Rodriguez
I will make the corrections to mauikit. Not sire how is the translation catalog set? What is the best way to set the date format to not force it? Thanks for the feedback. On Mon, 28 Sep 2020 at 5:42 PM Albert Astals Cid wrote: > El dimarts, 22 de setembre de 2020, a les 23:05:10 CEST, Camilo Hi

Re: MauiKit and Index review

2020-09-30 Thread Albert Astals Cid
El dimecres, 30 de setembre de 2020, a les 8:38:50 CEST, Thomas Baumgart va escriure: > On Dienstag, 29. September 2020 23:27:47 CEST Albert Astals Cid wrote: > > > El dimarts, 29 de setembre de 2020, a les 21:05:23 CEST, Camilo Higuita > > Rodriguez va escriure: > > > I will make the correction

Re: MauiKit and Index review

2020-09-29 Thread Thomas Baumgart
On Dienstag, 29. September 2020 23:27:47 CEST Albert Astals Cid wrote: > El dimarts, 29 de setembre de 2020, a les 21:05:23 CEST, Camilo Higuita > Rodriguez va escriure: > > I will make the corrections to mauikit. Not sire how is the translation > > catalog set? > > https://api.kde.org/framework

Re: MauiKit and Index review

2020-09-29 Thread Albert Astals Cid
El dimarts, 29 de setembre de 2020, a les 21:05:23 CEST, Camilo Higuita Rodriguez va escriure: > I will make the corrections to mauikit. Not sire how is the translation > catalog set? https://api.kde.org/frameworks/ki18n/html/prg_guide.html#link_cat > What is the best way to set the date format

Re: MauiKit and Index review

2020-09-28 Thread Albert Astals Cid
El dimarts, 22 de setembre de 2020, a les 23:05:10 CEST, Camilo Higuita Rodriguez va escriure: > Hi, > For the next stable release, we would like to go through KDE review first. > > To start I want to submit MauiKit and Index for review, and later on the > other apps. > https://invent.kde.org/mau

Re: MauiKit and Index review

2020-09-28 Thread Kevin Kofler
Camilo Higuita Rodriguez wrote: > To start I want to submit MauiKit and Index for review, and later on the > other apps. > https://invent.kde.org/maui/mauikit > https://invent.kde.org/maui/index Looks like the correct link is actually: https://invent.kde.org/maui/index-fm Unfortunately, Index is

MauiKit and Index review

2020-09-28 Thread Camilo Higuita Rodriguez
Hi, For the next stable release, we would like to go through KDE review first. To start I want to submit MauiKit and Index for review, and later on the other apps. https://invent.kde.org/maui/mauikit https://invent.kde.org/maui/index The changes we have made to get to this review are all in the d