Re: Kcmgrub2

2011-04-26 Thread Alberto Mattea
In data martedì 26 aprile 2011 23:13:29, Albert Astals Cid ha scritto: > A Tuesday, April 26, 2011, Alberto Mattea va escriure: > > In data sabato 23 aprile 2011 05:03:22, Raphael Kubo da Costa ha scritto: > > > Alberto Mattea writes: > > > > Hi, kcmgrub2 has been

Re: Kcmgrub2

2011-04-26 Thread Albert Astals Cid
A Tuesday, April 26, 2011, Alberto Mattea va escriure: > In data sabato 23 aprile 2011 05:03:22, Raphael Kubo da Costa ha scritto: > > Alberto Mattea writes: > > > Hi, kcmgrub2 has been under review for two weeks now. I've done all the > > > suggested changes. &g

Re: Kcmgrub2

2011-04-26 Thread Alberto Mattea
In data sabato 23 aprile 2011 05:03:22, Raphael Kubo da Costa ha scritto: > Alberto Mattea writes: > > Hi, kcmgrub2 has been under review for two weeks now. I've done all the > > suggested changes. > > Would it be possible to move it to kdemain/sysadmin or (if t

Re: Kcmgrub2

2011-04-22 Thread Raphael Kubo da Costa
Alberto Mattea writes: > Hi, kcmgrub2 has been under review for two weeks now. I've done all the > suggested changes. > Would it be possible to move it to kdemain/sysadmin or (if that's not > possible) to extragear/sysadmin? By the way, is there any relationship between kcmgrub2 and kcm-grub2?

Kcmgrub2

2011-04-18 Thread Alberto Mattea
Hi, kcmgrub2 has been under review for two weeks now. I've done all the suggested changes. Would it be possible to move it to kdemain/sysadmin or (if that's not possible) to extragear/sysadmin? Thanks Alberto

Re: Review request: Kcmgrub2

2011-04-07 Thread Alberto Mattea
In data giovedì 7 aprile 2011 00:01:20, Michael Jansen ha scritto: > > Preferably so. Remember that most script programs do not require to be > installed. A ruby program even if having a rakefile most of the time is > able to be run from the checkout. And what i remember from python the same > app

Re: Review request: Kcmgrub2

2011-04-06 Thread Michael Jansen
On Wednesday 06 April 2011 20:57:02 Alberto Mattea wrote: > In data mercoledì 6 aprile 2011 20:43:40, Michael Jansen ha scritto: > > > > You might also want to consider using KDE's > > > > macro_optional_find_package() together with macro_log_feature(), > > > > so you show a list of all the depende

Re: Review request: Kcmgrub2

2011-04-06 Thread Alberto Mattea
In data mercoledì 6 aprile 2011 20:43:40, Michael Jansen ha scritto: > > > You might also want to consider using KDE's > > > macro_optional_find_package() together with macro_log_feature(), so you > > > show a list of all the dependencies which have or have not been found > > > instead of failing a

Re: Review request: Kcmgrub2

2011-04-06 Thread Michael Jansen
> > You might also want to consider using KDE's > > macro_optional_find_package() together with macro_log_feature(), so you > > show a list of all the dependencies which have or have not been found > > instead of failing at the first one. > > > > I remember some discussions before about build-tim

Re: Review request: Kcmgrub2

2011-04-06 Thread Alberto Mattea
In data mercoledì 6 aprile 2011 20:01:32, Raphael Kubo da Costa ha scritto: > Alberto Mattea writes: > > In data mercoledì 6 aprile 2011 00:28:21, Raphael Kubo da Costa ha scritto: > >> Buildsystem-wise: > >> * I did not understand why you used include() instead of > >> > >> find_package() in,

Re: Review request: Kcmgrub2

2011-04-06 Thread Raphael Kubo da Costa
Alberto Mattea writes: > In data mercoledì 6 aprile 2011 00:28:21, Raphael Kubo da Costa ha scritto: >> Buildsystem-wise: >> >> * I did not understand why you used include() instead of >> find_package() in, for example, >> >> include(FindPyQt4) > > Actually I used an article on the KDE

Re: Review request: Kcmgrub2

2011-04-06 Thread Alberto Mattea
Hi, thanks for the review. In data mercoledì 6 aprile 2011 00:28:21, Raphael Kubo da Costa ha scritto: > Alberto Mattea writes: > > Hi all, > > after 4 releases I think kcmgrub2 has reached an acceptable level of > > maturity, so I'd ask for a move to kdereview. It is c

Re: Review request: Kcmgrub2

2011-04-05 Thread Raphael Kubo da Costa
Alberto Mattea writes: > Hi all, > after 4 releases I think kcmgrub2 has reached an acceptable level of maturity, > so I'd ask for a move to kdereview. It is currently in playground-sysadmin > (git). I only took a quick look, as my Py{Qt,KDE}-fu is not that good. Buildsystem

Review request: Kcmgrub2

2011-04-05 Thread Alberto Mattea
Hi all, after 4 releases I think kcmgrub2 has reached an acceptable level of maturity, so I'd ask for a move to kdereview. It is currently in playground-sysadmin (git). I'd be honored if eventually it became part of KDE main and I'm willing to maintain it, but if this isn'