I opened an issue in line with the new process
https://invent.kde.org/frameworks/ksvg/-/issues/2
Jonathan
On Thu, 20 Apr 2023 at 09:26, Marco Martin wrote:
> Hi all,
> A part of plasma-framewrok, which is the one to do SVG-based themes,
> has now been splitted in a standalone library which is
FWIW the code itself is almost entirely just moved verbatim from
plasma-framework, which is already a framework.
Nate
On 6/21/23 12:41, Friedrich W. H. Kossebau wrote:
Am Mittwoch, 21. Juni 2023, 12:23:55 CEST schrieb Ben Cooksley:
On Wed, Jun 21, 2023 at 10:12 PM Harald Sitter wrote:
LGTM
Am Mittwoch, 21. Juni 2023, 12:23:55 CEST schrieb Ben Cooksley:
> On Wed, Jun 21, 2023 at 10:12 PM Harald Sitter wrote:
> > LGTM now +2
> >
> > On Wed, Jun 21, 2023 at 10:04 AM Marco Martin wrote:
> > > I fixed CI, passes now
>
> Thanks for correcting that.
>
> As Friedrich raised the initial
On Wed, Jun 21, 2023 at 10:12 PM Harald Sitter wrote:
> LGTM now +2
>
> On Wed, Jun 21, 2023 at 10:04 AM Marco Martin wrote:
> >
> > I fixed CI, passes now
>
Thanks for correcting that.
As Friedrich raised the initial concerns it would be nice to have him
confirm that the code quality issues h
LGTM now +2
On Wed, Jun 21, 2023 at 10:04 AM Marco Martin wrote:
>
> I fixed CI, passes now
>
> On Tue, Jun 20, 2023 at 8:44 PM Ben Cooksley wrote:
> >
> > Hi all,
> >
> > Sysadmin has just received a request to move this repository to Frameworks,
> > however after seeing some of the comments r
I fixed CI, passes now
On Tue, Jun 20, 2023 at 8:44 PM Ben Cooksley wrote:
>
> Hi all,
>
> Sysadmin has just received a request to move this repository to Frameworks,
> however after seeing some of the comments raised here regarding the
> repository I took a look myself to see if they had been
Hi all,
Sysadmin has just received a request to move this repository to Frameworks,
however after seeing some of the comments raised here regarding the
repository I took a look myself to see if they had been corrected.
At this time CI is still broken in KSvg, for both platforms - something
that w
Hi all,
Some time has passes, and changes have been done in the repo to
address some of the points.
Now there are review requests in plasma-framework which depends on
this repo (and accompanying plasma-workspace, plasma-desktop etc)
It would probably be better to have this in frameworks to have the
On Fri, May 12, 2023 at 3:41 PM Friedrich W. H. Kossebau
wrote:
> Did some small fixes (library e.g. was installed with literal ".SOVERSION" as
> suffix...), but the more I did and more I saw... IMHO this should not have yet
> been passed to kdereview, being in alpha state for my taste.
ouch, sor
Hi,
Am Donnerstag, 20. April 2023, 10:25:34 CEST schrieb Marco Martin:
> Hi all,
> A part of plasma-framewrok, which is the one to do SVG-based themes,
> has now been splitted in a standalone library which is intended to be
> a new framework in KF6 (all usages of the plasma-framework version
> wil
On Sun, Apr 23, 2023 at 11:05 AM Albert Astals Cid wrote:
> > Comments? reviews?
>
> There's a few "TODO KF6" in the code, should those be addressed?
ok, I'll go over all of them in the review period
> Is the plan to make it less plasma-specific with the rename?
>
> i.e. the ImageSet constructor
El dijous, 20 d’abril de 2023, a les 10:25:34 (CEST), Marco Martin va
escriure:
> Hi all,
> A part of plasma-framewrok, which is the one to do SVG-based themes,
> has now been splitted in a standalone library which is intended to be
> a new framework in KF6 (all usages of the plasma-framework vers
El dijous, 20 d’abril de 2023, a les 10:25:34 (CEST), Marco Martin va
escriure:
> Hi all,
> A part of plasma-framewrok, which is the one to do SVG-based themes,
> has now been splitted in a standalone library which is intended to be
> a new framework in KF6 (all usages of the plasma-framework vers
Hi all,
A part of plasma-framewrok, which is the one to do SVG-based themes,
has now been splitted in a standalone library which is intended to be
a new framework in KF6 (all usages of the plasma-framework version
will be ported once this officially lands, and then those classes will
be removed)
Th
14 matches
Mail list logo
