Re: KQuickImageEditor in KDEReview

2021-04-08 Thread Carl Schwan
Le jeudi, mars 25, 2021 4:47 PM, Harald Sitter a écrit : > - really close to 100% reuse cover. plz consider adding data to > KQuickImageEditorConfig.cmake.in and src/controls/plugins.qmltypes > > - in fact... shouldn't the qmltypes file be generated at build time? > - there's commented out KD

Re: KQuickImageEditor in KDEReview

2021-03-25 Thread Harald Sitter
- really close to 100% reuse cover. plz consider adding data to KQuickImageEditorConfig.cmake.in and src/controls/plugins.qmltypes - in fact... shouldn't the qmltypes file be generated at build time? - there's commented out KDEFrameworkCompilerSettings in CMakeLists, please remove it, Friedrich ask

Re: KQuickImageEditor in KDEReview

2021-03-14 Thread Albert Astals Cid
El dissabte, 13 de març de 2021, a les 23:10:11 CET, Carl Schwan va escriure: > Hello again, > I putting KQuickImageEditor in KDEReview. KQuickImageEditor is a very > simple image editor for QtQuick projects. It is designed to not depends > on Kirigami (but a simple example that

Re: KQuickImageEditor in KDEReview

2021-03-13 Thread Carl Schwan
Le samedi, mars 13, 2021 11:33 PM, Albert Astals Cid a écrit : > El dissabte, 13 de març de 2021, a les 23:10:11 CET, Carl Schwan va escriure: > > > Hello again, > > I putting KQuickImageEditor in KDEReview. KQuickImageEditor is a very > > simple image editor for QtQuick

Re: KQuickImageEditor in KDEReview

2021-03-13 Thread Albert Astals Cid
El dissabte, 13 de març de 2021, a les 23:10:11 CET, Carl Schwan va escriure: > Hello again, > I putting KQuickImageEditor in KDEReview. KQuickImageEditor is a very > simple image editor for QtQuick projects. It is designed to not depends > on Kirigami (but a simple example that

KQuickImageEditor in KDEReview

2021-03-13 Thread Carl Schwan
Hello again, I putting KQuickImageEditor in KDEReview. KQuickImageEditor is a very simple image editor for QtQuick projects. It is designed to not depends on Kirigami (but a simple example that integrate in Kirigami application is provided in the source code). It doesn't have any translatio