Re: Review Request: KMainWindow::parseGeometry() fails to position with positive coordinates

> On June 6, 2011, 2:04 a.m., David Faure wrote: > > Looks good overall, but I think I found a bug with negative coordinates: > > konqueror --geometry +500-100 > > gives me a window that xwininfo says is at "744x533+500-29", which doesn't > > match. > > > > I have no experience with this, but i

Re: Review Request: KMainWindow::parseGeometry() fails to position with positive coordinates

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101492/#review3702 --- Looks good overall, but I think I found a bug with negative coor

Re: Review Request: KMainWindow::parseGeometry() fails to position with positive coordinates

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101492/ --- (Updated June 3, 2011, 10:09 p.m.) Review request for kdelibs. Changes -

Re: Review Request: KMainWindow::parseGeometry() fails to position with positive coordinates

> On June 3, 2011, 7:58 p.m., Dawit Alemayehu wrote: > > Looks good, however should the new if statements have an else that > > defaulted to previous behavior ? That is should not > > > > if ( !(m & XValue) ) > > x = this->x(); > > if ( !(m & YValue) ) > > y = this->y(); > > >

Re: Review Request: KMainWindow::parseGeometry() fails to position with positive coordinates

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101492/ --- (Updated June 3, 2011, 6:58 p.m.) Review request for kdelibs. Changes --

Re: Review Request: KMainWindow::parseGeometry() fails to position with positive coordinates

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101492/#review3653 --- Looks good, however should the new if statements have an else th

Re: Review Request: KMainWindow::parseGeometry() fails to position with positive coordinates

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101492/#review3651 --- kdeui/widgets/kmainwindow.cpp

Review Request: KMainWindow::parseGeometry() fails to position with positive coordinates

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101492/ --- Review request for kdelibs. Summary --- When an X geometry is given o

Re: KMainWindow::parseGeometry()

On Thursday, May 26, 2011 20:53:46 Urban Widmark wrote: > Posting here to get some feedback. If it looks ok (or you are all too it looks ok; two small comments: * updatesizeonly -> updateSizeOnly * patches should be submitted, if possible, via git.reviewboard.kde.org which improves the patch re

KMainWindow::parseGeometry()

Hello, Two fixes to KMainWindow::parseGeometry(). The method takes a parameter, parsewidth, which if set makes it *only* update the size of the window. Otherwise it only updates the position. That makes no sense, an X geometry can be both position and size. This patch changes what the flag does