Re: KHealthCertificate in kdereview

2021-07-12 Thread Volker Krause
On Montag, 12. Juli 2021 13:36:11 CEST Harald Sitter wrote: > My only gripe, besides what Albert already pointed out, is that all > the properties are WRITEable but have no NOTIFY signal nor are they > CONSTANT. One of those things ought to change. Considering only the > certificate objects have pr

Re: KHealthCertificate in kdereview

2021-07-12 Thread Volker Krause
On Montag, 12. Juli 2021 00:36:05 CEST Albert Astals Cid wrote: > El diumenge, 11 de juliol de 2021, a les 15:32:27 (CEST), Volker Krause va escriure: > > Hi, > > > > KHealthCertificate is a library for decoding digital vaccination, test and > > recovery certificates. Supported formats/features a

Re: KHealthCertificate in kdereview

2021-07-12 Thread Harald Sitter
My only gripe, besides what Albert already pointed out, is that all the properties are WRITEable but have no NOTIFY signal nor are they CONSTANT. One of those things ought to change. Considering only the certificate objects have properties and they are always constructed by the parsers I guess you

Re: KHealthCertificate in kdereview

2021-07-11 Thread Albert Astals Cid
El diumenge, 11 de juliol de 2021, a les 15:32:27 (CEST), Volker Krause va escriure: > Hi, > > KHealthCertificate is a library for decoding digital vaccination, test and > recovery certificates. Supported formats/features are: > * EU DGC: almost all data found in vaccination, test and recovery

Re: KHealthCertificate in kdereview

2021-07-11 Thread Friedrich W. H. Kossebau
Am Sonntag, 11. Juli 2021, 17:53:31 CEST schrieb Volker Krause: > done, with the exception of switching away from > KDEFrameworksCompilerSettings, that can only be done for 5.85, for earlier > versions that would require copying a bunch of settings it seems. Well, you still have some settings dupl

Re: KHealthCertificate in kdereview

2021-07-11 Thread Volker Krause
On Sonntag, 11. Juli 2021 16:07:37 CEST Friedrich W. H. Kossebau wrote: > Quick feedback after looking at the cmake code: > > * do not explicitly list ECM_KDE_MODULE_DIR, it is part of ECM_MODULE_PATH > * do not use KDEFrameworkCompilerSettings for non-KF projects, only > KDECompilerSettings > * n

Re: KHealthCertificate in kdereview

2021-07-11 Thread Friedrich W. H. Kossebau
Am Sonntag, 11. Juli 2021, 16:07:37 CEST schrieb Friedrich W. H. Kossebau: > * no need to set CMAKE_AUTOMOC & CMAKE_AUTORCC, done by KDECompilerSettings > for required ECM KDECMakeSettings rather :) Cheers Friedrich

Re: KHealthCertificate in kdereview

2021-07-11 Thread Friedrich W. H. Kossebau
Quick feedback after looking at the cmake code: * do not explicitly list ECM_KDE_MODULE_DIR, it is part of ECM_MODULE_PATH * do not use KDEFrameworkCompilerSettings for non-KF projects, only KDECompilerSettings * no need to set CMAKE_AUTOMOC & CMAKE_AUTORCC, done by KDECompilerSettings for requi

KHealthCertificate in kdereview

2021-07-11 Thread Volker Krause
Hi, KHealthCertificate is a library for decoding digital vaccination, test and recovery certificates. Supported formats/features are: * EU DGC: almost all data found in vaccination, test and recovery certificates, verification of ECDSA and RSA/PSS signatures. * India: basic support for vaccinati