Re: Review Request 128659: Proofread/update kfind docbooks

2016-11-05 Thread Burkhard Lück
rces add kf5options + qt5options to refsect1 "See Also" Diffs - kfind/docs/index.docbook 5b84f68 kfind/docs/man-kfind.1.docbook 31222ea Diff: https://git.reviewboard.kde.org/r/128659/diff/ Testing --- passes checkXML5 Thanks, Burkhard Lück

Re: Review Request 128659: Proofread/update kfind docbooks

2016-09-11 Thread Burkhard Lück
separated path", this does not work for me in kf5 master > compiled from sources > add kf5options + qt5options to refsect1 "See Also" > > > Diffs > - > > kfind/docs/index.docbook 5b84f68 > kfind/docs/man-kfind.1.docbook 31222ea > > Diff: ht

Re: Review Request 128659: Proofread/update kfind docbooks

2016-08-22 Thread Burkhard Lück
ove "a colon separated path", this does not work for me in kf5 master > compiled from sources > add kf5options + qt5options to refsect1 "See Also" > > > Diffs > - > > kfind/docs/index.docbook 5b84f68 > kfind/docs/man-kfind.1.docboo

Re: Review Request 128659: Proofread/update kfind docbooks

2016-08-12 Thread Burkhard Lück
quot;, and what does not work for me starting kfind in konsole: 1) "kfind /tmp:/home" -> Look in: prefilled with "file:///tmp:/home" 2) "kfind +/tmp" -> Look in: prefilled with "file:///path/to/startdir/+/tmp" If I start the search 1) or 2) I g

Review Request 128659: Proofread/update kfind docbooks

2016-08-11 Thread Burkhard Lück
. Repository: kde-baseapps Description --- handbook remove ENTITY kappname man page remove "a colon separated path", this does not work for me in kf5 master compiled from sources add kf5options + qt5options to refsect1 "See Also" Diffs - kfind/docs/index.docbook 5

Re: Review Request 128305: [KFind] Use KIO::highlightInFileManager

2016-07-01 Thread Kai Uwe Broulik
highlight the file(s). Diffs - CMakeLists.txt c10342f kfind/kfindtreeview.cpp e546b6e Diff: https://git.reviewboard.kde.org/r/128305/diff/ Testing --- Needs Review 128306 to fully work. While the specs says "The behavior for more than one element is left up to the implement

Re: Review Request 128305: [KFind] Use KIO::highlightInFileManager

2016-06-28 Thread Sebastian Kügler
ated June 28, 2016, 4:09 p.m.) > > > Review request for KDE Base Apps. > > > Repository: kde-baseapps > > > Description > --- > > This has the file manager open the parent folder(s), scroll to and highlight > the file(s). > > > Diffs >

Review Request 128305: [KFind] Use KIO::highlightInFileManager

2016-06-28 Thread Kai Uwe Broulik
--- This has the file manager open the parent folder(s), scroll to and highlight the file(s). Diffs - CMakeLists.txt c10342f kfind/kfindtreeview.cpp e546b6e Diff: https://git.reviewboard.kde.org/r/128305/diff/ Testing --- Needs Review 128306 to fully work. While the

Re: Review Request 127815: [KFind] Disable only tab contents not the entire tab bar

2016-06-06 Thread Kai Uwe Broulik
you couldn't even switch tabs to see what you're actually looking for, eg. if you started searching while on the "Properties" tab you couldn't switch to the "Name/Location" tab. This patch disables only the tab contents while still allowing to switch tabs.

Re: Review Request 127815: [KFind] Disable only tab contents not the entire tab bar

2016-05-29 Thread Kai Uwe Broulik
> switch tabs to see what you're actually looking for, eg. if you started > searching while on the "Properties" tab you couldn't switch to the > "Name/Location" tab. > > This patch disables only the tab contents while still allowing to switch tabs. &

Re: Review Request 127815: [KFind] Disable only tab contents not the entire tab bar

2016-05-04 Thread Thomas Pfeiffer
;re actually looking for, eg. if you started > searching while on the "Properties" tab you couldn't switch to the > "Name/Location" tab. > > This patch disables only the tab contents while still allowing to switch tabs. > > > Diffs > - > >

Re: Review Request 127815: [KFind] Disable only tab contents not the entire tab bar

2016-05-02 Thread Kai Uwe Broulik
quot;Properties" tab you couldn't switch to the "Name/Location" tab. This patch disables only the tab contents while still allowing to switch tabs. Diffs (updated) - kfind/kftabdlg.cpp 3de1bfe Diff: https://git.reviewboard.kde.org/r/127815/diff/ Testing ---

Review Request 127815: [KFind] Disable only tab contents not the entire tab bar

2016-05-02 Thread Kai Uwe Broulik
. This patch disables only the tab contents while still allowing to switch tabs. Diffs - kfind/kftabdlg.cpp 3de1bfe Diff: https://git.reviewboard.kde.org/r/127815/diff/ Testing --- Works. I was surprised to find kde-baseapps master still being 4.x-based. File Attachment

Re: KFind

2014-12-05 Thread Kevin Kofler
laurent Montel wrote: > Indeed it's not finish to port (I worked on it too). > Still depend against kdelibs4support . So what? That will only become a problem when Qt 6 gets released years from now. Kevin Kofler

Re: KFind

2014-12-05 Thread Emmanuel Pescosta
> uses an indexer which only indexes a subset of the system There is a filenamesearch ioslave which is used by Dolphin' search for non indexed and remote paths. But I agree with you that Dolphin's search is not a full replacement for KFind, because a lot of adjustable search option

Re: KFind

2014-12-05 Thread Gregor Mi
Hi, as I started using KDE, it took me some to find out that kfind exists at all. So, would a review request be appreciated which adds an "Alternatives" drop down button to Dolphin's "More options" pane that contains kfind as it's first entry? Simple hand-drawn m

Re: KFind

2014-12-05 Thread laurent Montel
Le Friday 05 December 2014 10:33:07 Martin Gräßlin a écrit : > On Friday 05 December 2014 10:00:24 laurent Montel wrote: > > Hi, > > > > I think that we can use Dolphin to search files. > > I want to remove Kfind from kde-baseapps. > > It was not ported and the

Re: KFind

2014-12-05 Thread Martin Gräßlin
On Friday 05 December 2014 10:00:24 laurent Montel wrote: > Hi, > > I think that we can use Dolphin to search files. > I want to remove Kfind from kde-baseapps. > It was not ported and there is not maintainer. > > If nobody has an objection I will remove it at before chri

KFind

2014-12-05 Thread laurent Montel
Hi, I think that we can use Dolphin to search files. I want to remove Kfind from kde-baseapps. It was not ported and there is not maintainer. If nobody has an objection I will remove it at before christmas. Regards. -- Laurent Montel | laurent.mon...@kdab.com | KDE/Qt Senior Software Engineer

Re: Review Request: add default help menu with all standard help actions to Help button in KFind

2011-06-13 Thread Raphael Kubo da Costa
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101443/#review3869 --- Ship it! Looks OK. Perhaps KFind should actually have a main

Re: Review Request: add default help menu with all standard help actions to Help button in KFind

2011-06-12 Thread Burkhard Lück
y 26, 2011, 12:07 p.m.) > > > Review request for KDE Base Apps. > > > Summary > --- > > The Help button in KFind opens the Handbook, but all usual standard help > actions like bug report, switch language and about kde/kfind are missing. Wth > this patch the H

Review Request: add default help menu with all standard help actions to Help button in KFind

2011-05-26 Thread Burkhard Lück
KFind opens the Handbook, but all usual standard help actions like bug report, switch language and about kde/kfind are missing. Wth this patch the Help in kfind has the default behavior of all other kde applications. ksnaphot has the same button with all standard help actions. This addresses bug