Re: KEditListWidget

2011-03-18 Thread Fabrice Ménard
Le jeudi 17 mars 2011 23:40:32 Christoph Feck a écrit : > Do you need it in 4.6.2? I can apply to trunk, but I won't touch branches > until my git foo matures Trunk is ok for me. Thanks -- Fabrice Ménard

Re: KEditListWidget

2011-03-17 Thread John Layt
On Thursday 17 Mar 2011 22:40:32 Christoph Feck wrote: > Do you need it in 4.6.2? I can apply to trunk, but I won't touch branches > until my git foo matures :) Not too much git-foo required to back or forward port as we can't really merge in kdelibs yet, so we just cherry-pick the commit we need

Re: KEditListWidget

2011-03-17 Thread Christoph Feck
On Thursday 17 March 2011 16:34:15 Fabrice Ménard wrote: > Hi, > > Please, can someone apply this tiny patch to make KEditListWidget work with > KConfigDialogManager. Do you need it in 4.6.2? I can apply to trunk, but I won't touch branches until my git foo matures :) Christoph Feck (kdepepo)

KEditListWidget

2011-03-17 Thread Fabrice Ménard
Hi, Please, can someone apply this tiny patch to make KEditListWidget work with KConfigDialogManager. Best regards, -- Fabrice Ménarddiff --git a/kdeui/dialogs/kconfigdialogmanager.cpp b/kdeui/dialogs/kconfigdialogmanager.cpp index 36f8531..0209f49 100644 --- a/kdeui/dialogs

Re: Review Request: Add support for multiple selection in the KEditListBox and KEditListWidget widgets

2011-01-03 Thread David Faure
On Sunday 26 December 2010, Raphael Kubo da Costa wrote: > /trunk/KDE/kdelibs/kdeui/widgets/keditlistbox.cpp > > > According to kdelibs' coding style, you should #include both module and > class name for Qt includes. Only in public headers

Re: Review Request: Add support for multiple selection in the KEditListBox and KEditListWidget widgets

2010-12-26 Thread George Metaxas
ed to reflect the new behaviour. Summary --- In order to satisfy Bug 219574, the KEditListBox and KEditListWidget widgets need to have multiple item selection support. This patch adds the familiar type of multiple item selection (select items by pressing CTRL + Left Click, and s

Re: Review Request: Add support for multiple selection in the KEditListBox and KEditListWidget widgets

2010-12-26 Thread Raphael Kubo da Costa
e-mail. To reply, visit: > http://svn.reviewboard.kde.org/r/6204/ > --- > > (Updated 2010-12-25 15:13:50) > > > Review request for kdelibs. > > > Summary > --- > > In order to satisfy Bug 219574, the KEdit

Review Request: Add support for multiple selection in the KEditListBox and KEditListWidget widgets

2010-12-26 Thread George Metaxas
, the KEditListBox and KEditListWidget widgets need to have multiple item selection support. This patch adds the familiar type of multiple item selection (select items by pressing CTRL + Left Click, and select consecutive regions with SHIFT + Left click) in both of these widgets. The patch also