Re: KDE Builder: request for review

2024-07-22 Thread Ashark
> any feedback on that? As I already said in previous message: >> Regarding reviews, I am not against them. I just continue directly >> committing changes that do not influence on the behavior, such as for >> example, changes to follow pep8 rules and refactorings. And, as I already said in chat,

Re: KDE Builder: request for review

2024-07-21 Thread christoph
Hi, On 2024-07-15 21:50, christ...@cullmann.io wrote: Hi, On 2024-07-15 20:13, Andrew Shark wrote: You mean new python dependencies? I never added them. Oppositely, I reduce them. For example, I gladly got rid of the "promise" dependency. yes, with dependencies I meant Python libs and the Py

Re: KDE Builder: request for review

2024-07-15 Thread christoph
Hi, On 2024-07-15 20:13, Andrew Shark wrote: You mean new python dependencies? I never added them. Oppositely, I reduce them. For example, I gladly got rid of the "promise" dependency. yes, with dependencies I meant Python libs and the Python version. There was some rather lengthy discussions

Re: KDE Builder: request for review

2024-07-15 Thread christoph
On 2024-07-13 15:52, christ...@cullmann.io wrote: On 2024-07-12 23:01, Thiago Masato Costa Sueto wrote: Hi, I'd like to ask about the status of the KDE Review for kde-builder. The existing issue tracking this has been without activity for a while: https://invent.kde.org/sdk/kde-builder/-/issue

Re: KDE Builder: request for review

2024-07-13 Thread christoph
On 2024-07-12 23:01, Thiago Masato Costa Sueto wrote: Hi, I'd like to ask about the status of the KDE Review for kde-builder. The existing issue tracking this has been without activity for a while: https://invent.kde.org/sdk/kde-builder/-/issues/84 So far ashark seems to have fulfilled what wa

Re: KDE Builder: request for review

2024-07-12 Thread Thiago Masato Costa Sueto
Hi, I'd like to ask about the status of the KDE Review for kde-builder. The existing issue tracking this has been without activity for a while: https://invent.kde.org/sdk/kde-builder/-/issues/84 So far ashark seems to have fulfilled what was asked of them, and I believe they're just waiting for

Re: KDE Builder: request for review

2024-05-07 Thread Andrey Butirsky
On 09.04.2024 13:51, Sune Vuorela wrote: On Mon, Apr 8, 2024 at 10:05 AM wrote: and deprecating the kdesrc-build. That way we can move forward with new tool. I don't think reviewing or not of kde-builder should have any effect on kdesrc-build. I think also we should be slightly wary of changi

Re: KDE Builder: request for review

2024-04-09 Thread Albert Astals Cid
El dimarts, 9 d’abril del 2024, a les 12:51:50 (CEST), Sune Vuorela va escriure: > On Mon, Apr 8, 2024 at 10:05 AM wrote: > > and deprecating the kdesrc-build. That way we can move forward with new > > tool. > I don't think reviewing or not of kde-builder should have any effect on > kdesrc-build.

Re: KDE Builder: request for review

2024-04-09 Thread Sune Vuorela
On Mon, Apr 8, 2024 at 10:05 AM wrote: > and deprecating the kdesrc-build. That way we can move forward with new tool. I don't think reviewing or not of kde-builder should have any effect on kdesrc-build. I think also we should be slightly wary of changing a long-running 20y old tool written by

Re: KDE Builder: request for review

2024-04-09 Thread Harald Sitter
On Tue, Apr 9, 2024 at 11:26 AM Kevin Kofler wrote: > > ash...@linuxcomp.ru wrote: > > I've been working on KDE Builder project. This is a reimplementation of > > kdesrc-build in Python. > > What is the point of rewriting a tool originally written in a stable > language that guarantees long-term b

Re: KDE Builder: request for review

2024-04-09 Thread Kevin Kofler
ash...@linuxcomp.ru wrote: > I've been working on KDE Builder project. This is a reimplementation of > kdesrc-build in Python. What is the point of rewriting a tool originally written in a stable language that guarantees long-term backwards compatibility (since the originally planned incompatibl

Re: KDE Builder: request for review

2024-04-08 Thread Harald Sitter
On Mon, Apr 8, 2024 at 10:05 AM wrote: > > Hi all! > > I've been working on KDE Builder project. This is a reimplementation of > kdesrc-build in Python. At this point, the tool is rather mature, but some > minor bugs may probably be unnoticed. I'd like to officially request a review > of KDE Bu

KDE Builder: request for review

2024-04-08 Thread ashark
Hi all! I've been working on KDE Builder project. This is a reimplementation of kdesrc-build in Python. At this point, the tool is rather mature, but some minor bugs may probably be unnoticed. I'd like to officially request a review of KDE Builder for declaring it official tool, and deprecating th