Re: KConfigDialog

2014-10-29 Thread Jeremy Whiting
27;octubre de 2014, a les 22:22:12, Jeremy Whiting va escriure: >> Hello, >> >> Is there a way to have custom settings mixed with kcfg_ type settings >> in a KConfigDialog? Kanagram does this, but it only works when another >> kcfg_ named widget changes too. The combo

Re: KConfigDialog

2014-10-29 Thread Albert Astals Cid
El Dilluns, 27 d'octubre de 2014, a les 22:22:12, Jeremy Whiting va escriure: > Hello, > > Is there a way to have custom settings mixed with kcfg_ type settings > in a KConfigDialog? Kanagram does this, but it only works when another > kcfg_ named widget changes too. The comb

KConfigDialog

2014-10-27 Thread Jeremy Whiting
Hello, Is there a way to have custom settings mixed with kcfg_ type settings in a KConfigDialog? Kanagram does this, but it only works when another kcfg_ named widget changes too. The combobox to select which language to use gets saved to disk by a slot that's connected to KConfigDia

Re: Review Request: Replicate the existing KConfigDialog constructor and change one argument type

2012-02-21 Thread Commit Hook
o constructors; one with > KConfigSkeleton argument type, and yet another with KCoreConfigSkeleton. It > looks like a situation where the KCoreConfigSkeleton version was added later. > > KConfigDialog does not have a constructor yet with KCoreConfigSkeleton > argument

Re: Review Request: Replicate the existing KConfigDialog constructor and change one argument type

2012-02-21 Thread David Faure
already two constructors; one with > KConfigSkeleton argument type, and yet another with KCoreConfigSkeleton. It > looks like a situation where the KCoreConfigSkeleton version was added later. > > KConfigDialog does not have a constructor yet with KCoreConfigSkeleton > arg

Re: Review Request: Replicate the existing KConfigDialog constructor and change one argument type

2012-02-21 Thread Laszlo Papp
. KConfigDialogManager has apparently already two constructors; one with KConfigSkeleton argument type, and yet another with KCoreConfigSkeleton. It looks like a situation where the KCoreConfigSkeleton version was added later. KConfigDialog does not have a constructor yet with KCoreConfigSkeleton

Re: Review Request: Use KCoreConfigSkeleton argument type where possible inside the KConfigDialog

2012-01-18 Thread Jeremy Paul Whiting
such an approach); one with KConfigSkeleton > argument type, and yet another with KCoreConfigSkeleton. It looks like a > situation where the KCoreConfigSkeleton version was added for good. > > The KConfigDialog constructor does not handle KCoreConfigSkeleton argument > type yet; it has probably someh

Re: Review Request: Use KCoreConfigSkeleton argument type where possible inside the KConfigDialog

2012-01-18 Thread David Faure
ntly already two constructors (ie.: the need > already arised previously for such an approach); one with KConfigSkeleton > argument type, and yet another with KCoreConfigSkeleton. It looks like a > situation where the KCoreConfigSkeleton version was added for good. > > The KConfi

Re: Review Request: Use KCoreConfigSkeleton argument type where possible inside the KConfigDialog

2012-01-18 Thread Jeremy Paul Whiting
zes and complexity for no real need. > > KConfigDialogManager has apparently already two constructors (ie.: the need > already arised previously for such an approach); one with KConfigSkeleton > argument type, and yet another with KCoreConfigSkeleton. It looks like a > situation where

Re: Review Request: Replicate the existing KConfigDialog constructor and change one argument type

2012-01-17 Thread Laszlo Papp
sing it -- or the real reason is > > core/gui split in your libs/apps, which would be a valid point. > > Laszlo Papp wrote: > The desktop application uses kdeui. > > KConfigDialog (QWidget *parent, const QString &name, KConfigSkeleton > *config) -> It i

Re: Review Request: Replicate the existing KConfigDialog constructor and change one argument type

2012-01-17 Thread Laszlo Papp
sing it -- or the real reason is > > core/gui split in your libs/apps, which would be a valid point. The desktop application uses kdeui. KConfigDialog (QWidget *parent, const QString &name, KConfigSkeleton *config) -> It is now impossible to generate only one settings class inherit

Review Request: Use KCoreConfigSkeleton argument type where possible inside the KConfigDialog

2012-01-17 Thread Laszlo Papp
apparently already two constructors (ie.: the need already arised previously for such an approach); one with KConfigSkeleton argument type, and yet another with KCoreConfigSkeleton. It looks like a situation where the KCoreConfigSkeleton version was added for good. The KConfigDialog constructor

Re: Review Request: Replicate the existing KConfigDialog constructor and change one argument type

2012-01-17 Thread David Faure
> module is unlikely welcome on mobile platforms, especially in appstores with > its sizes and complexity for no real need. > > KConfigDialogManager has apparently already two constructors; one with > KConfigSkeleton argument type, and yet another with KCoreConfigSkeleton. It >

Review Request: Replicate the existing KConfigDialog constructor and change one argument type

2012-01-17 Thread Laszlo Papp
apparently already two constructors; one with KConfigSkeleton argument type, and yet another with KCoreConfigSkeleton. It looks like a situation where the KCoreConfigSkeleton version was added later. KConfigDialog does not have a constructor yet with KCoreConfigSkeleton argument type yet; it has

Re: Review Request: Better documentation for KConfigDialog::addPage()

2011-05-22 Thread Commit Hook
org/r/101409/ > --- > > (Updated May 21, 2011, 11:03 a.m.) > > > Review request for kdelibs. > > > Summary > --- > > The documentation of KConfigDialog::addPage() is not very detailed about the > parameter "pixm

Re: Review Request: Better documentation for KConfigDialog::addPage()

2011-05-22 Thread Lukas Sommer
--- Updated diff, using the text from Aaron. Summary --- The documentation of KConfigDialog::addPage() is not very detailed about the parameter "pixmapName". This patch adds to the documentation that it is possible to simply pass the KDE icon name instead of the pixmap pa

Re: Review Request: Better documentation for KConfigDialog::addPage()

2011-05-22 Thread Lukas Sommer
org/r/101409/ > --- > > (Updated May 21, 2011, 11:03 a.m.) > > > Review request for kdelibs. > > > Summary > --- > > The documentation of KConfigDialog::addPage() is not very detailed about the > parameter "pixmapName". This patch adds to the document

Re: Review Request: Better documentation for KConfigDialog::addPage()

2011-05-21 Thread Aaron J. Seigo
request for kdelibs. > > > Summary > --- > > The documentation of KConfigDialog::addPage() is not very detailed about the > parameter "pixmapName". This patch adds to the documentation that it is > possible to simply pass the KDE icon name instead of the pixmap

Review Request: Better documentation for KConfigDialog::addPage()

2011-05-21 Thread Lukas Sommer
KConfigDialog::addPage() is not very detailed about the parameter "pixmapName". This patch adds to the documentation that it is possible to simply pass the KDE icon name instead of the pixmap path. This addresses bug 273723. http://bugs.kde.org/show_bug.cgi?id=273723 Diffs - kde