ewboard.kde.org/r/118366/#review100194
---
On June 23, 2014, 1:46 p.m., shivam makkar wrote:
>
> ---
> This is an automatically generated e-mail. To reply, vi
kcms/keyboard/xkb_rules.h 2be856246cc150abb24775c6d56b8af2a07df94f
kcms/keyboard/xkb_rules.cpp f09e6750130799d6e0cdc380a6dbaa834c43aa43
Diff: https://git.reviewboard.kde.org/r/118366/diff/
Testing
---
Thanks,
shivam makkar
/15/1ec53ee9-f2ac-4a63-bc4f-6180160c20dd__snapshot20.jpg
microsoft natural
https://git.reviewboard.kde.org/media/uploaded/files/2013/11/15/aea0136b-c4f2-412e-9de7-534b64d70af0__snapshot18.jpg
Thanks,
shivam makkar
2be856246cc150abb24775c6d56b8af2a07df94f
kcms/keyboard/xkb_rules.cpp f09e6750130799d6e0cdc380a6dbaa834c43aa43
Diff: https://git.reviewboard.kde.org/r/118366/diff/
Testing
---
Thanks,
shivam makkar
ll add another review dedicated to coding style changes only.
- shivam
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118366/#review60569
---
> On May 28, 2014, 6:10 a.m., Martin Gräßlin wrote:
> > kcms/keyboard/kcmmisc.cpp, lines 77-78
> > <https://git.reviewboard.kde.org/r/118366/diff/2/?file=275630#file275630line77>
> >
> > for new connects I would use the new compile time checked syntax.
>
kcms/keyboard/xkb_rules.cpp f09e675
Diff: https://git.reviewboard.kde.org/r/118366/diff/
Testing
---
Thanks,
shivam makkar
Diff: https://git.reviewboard.kde.org/r/118366/diff/
Testing
---
Thanks,
shivam makkar
://git.reviewboard.kde.org/r/118366/diff/
Testing
---
Thanks,
shivam makkar
980338e
Diff: https://git.reviewboard.kde.org/r/118366/diff/
Testing
---
Thanks,
shivam makkar
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118366/#review58618
-------
On May 29, 2014, 7:53 a.m., shivam makkar wrote:
>
> ---
>
---
Thanks,
shivam makkar
,
shivam makkar
/keyboard/layout_memory_persister.cpp 8a6118a
kcms/keyboard/layouts_menu.cpp fd436c4
kcms/keyboard/xinput_helper.h 343d7ed
kcms/keyboard/xinput_helper.cpp b311579
Diff: https://git.reviewboard.kde.org/r/118366/diff/
Testing
---
Thanks,
shivam makkar
/118365/diff/
Testing
---
Thanks,
shivam makkar
,
shivam makkar
/keyboard/layout_memory_persister.cpp 8a6118a
kcms/keyboard/layouts_menu.cpp fd436c4
kcms/keyboard/xinput_helper.h 343d7ed
kcms/keyboard/xinput_helper.cpp b311579
Diff: https://git.reviewboard.kde.org/r/118365/diff/
Testing
---
Thanks,
shivam makkar
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/113413/#review48292
---
Ship it!
Ship It!
- shivam makkar
On Nov. 15, 2013, 9:37
ttp://git.reviewboard.kde.org/media/uploaded/files/2013/11/15/1ec53ee9-f2ac-4a63-bc4f-6180160c20dd__snapshot20.jpg
microsoft natural
http://git.reviewboard.kde.org/media/uploaded/files/2013/11/15/aea0136b-c4f2-412e-9de7-534b64d70af0__snapshot18.jpg
Thanks,
shivam makkar
out microsoft natural geometry
http://git.reviewboard.kde.org/media/uploaded/files/2013/11/05/8dca14f2-2d00-46d1-95a1-f7eca0ff5831__snapshot18.jpg
Thanks,
shivam makkar
gt; > Some key name doesn't looks correct (F1 - F12), could you use X11keysym.h
> > to get the key name in X11? Or use XKeysymToString in libX11 maybe.
> >
> > Some key string position can be improved, for example, the "Space" in
> > second screenshot.
&g
ew42377
-------
On Oct. 26, 2013, 1:12 p.m., shivam makkar wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r
/26/584a9877-4875-48ce-957e-51b1cc19b76e__snapshot15.jpg
Thanks,
shivam makkar
/26/cc9cae25-2366-4978-98b0-d83b41eabc09__snapshot14.jpg
Thanks,
shivam makkar
/25/2bfcbe59-d152-4bfc-8760-b40c2e4d5181__snapshot12.jpg
Thanks,
shivam makkar
562
kcontrol/keyboard/xkb_rules.cpp 616e7b8
kcontrol/keyboard/xkb_rules.cpp 616e7b8
kwin/tabbox/kwindesktopswitcher.desktop 42cc455
Diff: http://git.reviewboard.kde.org/r/113413/diff/
Testing
---
Thanks,
shivam makkar
26 matches
Mail list logo
