Re: Review Request 111261: [KDE-Workspace]: Possible NULL ptr. deref. in KDM and KCheckPass

2013-06-29 Thread mr. mancha
> On June 29, 2013, 11:37 a.m., Oswald Buddenhagen wrote: > > Ship It! > > Albert Astals Cid wrote: > Mr Mancha Mancha we're going to need your real name and email before we > can submit this for proper attribution. Hello Albert. For the purpose of attribution,

Re: Review Request 111261: [KDE-Workspace]: Possible NULL ptr. deref. in KDM and KCheckPass

2013-06-28 Thread mancha mancha
st be in the else branch of PAM and AIX. This should do it. Do let me know if I missed something though. - mancha --- This is an automatically generated e-mail. To reply, visit: http://git.re

Re: Review Request 111261: [KDE-Workspace]: Possible NULL ptr. deref. in KDM and KCheckPass

2013-06-28 Thread mancha mancha
egfault as shown in log snippets above. After applying the patch, both properly handle NULL returns from crypt() and pw_encrypt(). Thanks, mancha mancha

Re: Review Request 111261: [KDE-Workspace]: Possible NULL ptr. deref. in KDM and KCheckPass

2013-06-27 Thread mancha mancha
> > variable warnings. follow the #ifdef cascade closer. line 543 should fit, > > with the addition of a compound !ultrix clause (mostly for formal > > correctness). Thanks. Hope I got this right, please confirm. - mancha --

Re: Review Request 111261: [KDE-Workspace]: Possible NULL ptr. deref. in KDM and KCheckPass

2013-06-27 Thread mancha mancha
d.kde.org/r/111261/diff/ Testing --- Tests conducted on KDE-Workspace 4.10.4 confirm attached patch corrects the issues described above. Before applying the patch, KDM and KCheckPass segfault as shown in log snippets above. After applying the patch, both properly handle NULL returns from crypt() a

Review Request 111261: [KDE-Workspace]: Possible NULL ptr. deref. in KDM and KCheckPass

2013-06-26 Thread mancha mancha
returns from crypt() and pw_encrypt(). Thanks, mancha mancha

[KDM] Potential NULL pointer deref. w/. glibc 2.17+

2013-06-24 Thread mancha
dow's pw_encrypt(), check return value to avoid a possible NULL pointer dereference. Patch that addresses this issue is submitted for code review (applies cleanly to HEAD@e6dee42e54). --mancha 0001-Handle-NULL-returns-from-glibc-2.17-crypt.patch Description: Binary data