Re: Review Request 116522: Make KAboutDialog looks better under OSX

2014-03-26 Thread Yue Liu
link instead for all platforms and get rid of that > > misused toolbar button altogether. > > Yue Liu wrote: > I feel any contact info feature in about dialog is not very useful. If a > user want to contact developer for software-related stuff, they should go to > a pu

Re: Review Request 116522: Make KAboutDialog looks better under OSX

2014-03-01 Thread Yue Liu
an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116522/#review51557 ----------- On March 1, 2014, 11:06 p.m., Yue Liu wrote: > > --- > This is

Review Request 116522: Make KAboutDialog looks better under OSX

2014-03-01 Thread Yue Liu
90e0c-97f9-448e-b83e-67144773bdbb__after-3.png Thanks, Yue Liu

Re: Review Request: Make Strigi optional on OS X

2013-01-10 Thread Yue Liu
/diff/ Testing --- Compiles. Some apps works. Thanks, Yue Liu

Review Request: Make Strigi optional on OS X

2013-01-10 Thread Yue Liu
http://git.reviewboard.kde.org/r/108315/diff/ Testing --- Compiles. Some apps works. Thanks, Yue Liu

Re: Review Request: Make Strigi optional on OS X

2013-01-10 Thread Yue Liu
o/kio/kfilemetainfo.h 6920ffe Diff: http://git.reviewboard.kde.org/r/108315/diff/ Testing --- Compiles. Some apps works. Thanks, Yue Liu

Re: Review Request: Fix icon generation and installation on OS X

2012-12-21 Thread Yue Liu
> On Dec. 20, 2012, 6:58 p.m., Laszlo Papp wrote: > > Great, thank you for your care! One suggestion to this, and I think then it > > is fine from that point of view: you could write a foreach on top of the > > "copy_icons" macro, and avoid the same function

Re: Review Request: Fix icon generation and installation on OS X

2012-12-21 Thread Yue Liu
> On Dec. 20, 2012, 6:58 p.m., Laszlo Papp wrote: > > Great, thank you for your care! One suggestion to this, and I think then it > > is fine from that point of view: you could write a foreach on top of the > > "copy_icons" macro, and avoid the same function

Re: Review Request: Fix icon generation and installation on OS X

2012-12-21 Thread Yue Liu
wboard.kde.org/r/107752/#review23767 ------- On Dec. 20, 2012, 6:10 p.m., Yue Liu wrote: > > --- > This is an automatically generated e-mail. To reply, vis

Re: Review Request: Fix icon generation and installation on OS X

2012-12-21 Thread Yue Liu
> On Dec. 16, 2012, 1:47 p.m., Laszlo Papp wrote: > > cmake/modules/KDE4Macros.cmake, line 1293 > > <http://git.reviewboard.kde.org/r/107752/diff/1/?file=99544#file99544line1293> > > > > Wouldn't it be nicer to write a loop for this with the icon reso

Re: Review Request: Fix icon generation and installation on OS X

2012-12-20 Thread Yue Liu
hanks, Yue Liu

Re: Review Request: Fix icon generation and installation on OS X

2012-12-16 Thread Yue Liu
> On Dec. 16, 2012, 1:47 p.m., Laszlo Papp wrote: > > cmake/modules/KDE4Macros.cmake, line 1293 > > <http://git.reviewboard.kde.org/r/107752/diff/1/?file=99544#file99544line1293> > > > > Wouldn't it be nicer to write a loop for this with the icon reso

Re: Review Request: Fix icon generation and installation on OS X

2012-12-16 Thread Yue Liu
--------- On Dec. 16, 2012, 7:26 a.m., Yue Liu wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/107752/ >

Review Request: Fix icon generation and installation on OS X

2012-12-16 Thread Yue Liu
Diffs - cmake/modules/KDE4Macros.cmake 0753879 Diff: http://git.reviewboard.kde.org/r/107752/diff/ Testing --- Works well on 4.9 branch. Not sure if some changes breaks other platforms. Thanks, Yue Liu