Re: Review Request: Hide empty additional information lines in icons view mode

2012-09-04 Thread Todd Jennings
mlistwidget.cpp 7ae7e2efcffc2f68c72a05cdbc3b29abc4c3aff4 Diff: http://git.reviewboard.kde.org/r/106304/diff/ Testing --- Tested and it works Thanks, Todd Jennings

Re: Review Request: Hide empty additional information lines in icons view mode

2012-09-03 Thread Todd Jennings
generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106304/#review18454 --- On Sept. 2, 2012, 10:41 a.m., Todd Jennings wrote: > > --- > This is an automa

Re: Review Request: Hide empty additional information lines in icons view mode

2012-09-02 Thread Todd Jennings
the loop does essentially nothing - > > if it finds an empty string in the hash, it puts an empty string with the > > same key into the hash. Am I overlooking something, or could the entire > > loop be removed? > > Todd Jennings wrote: > That depends on whether we can

Re: Review Request: Hide empty additional information lines in icons view mode

2012-09-02 Thread Todd Jennings
Testing --- Tested and it works Thanks, Todd Jennings

Re: Review Request: Hide empty additional information lines in icons view mode

2012-09-01 Thread Todd Jennings
can guarantee it will always be a string, then does it really need to be a qvariant? - Todd --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106304/#review18407 ----

Re: Review Request: Hide empty additional information lines in icons view mode

2012-09-01 Thread Todd Jennings
ted and it works Thanks, Todd Jennings

Re: Review Request: Hide empty additional information lines in icons view mode

2012-09-01 Thread Todd Jennings
Tested and it works Thanks, Todd Jennings