Re: Review Request 128854: Add a Tools button above the process list of System Monitor

side! - Thomas Pfeiffer On Sept. 7, 2016, 12:24 p.m., Gregor Mi wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard

Re: Review Request 127815: [KFind] Disable only tab contents not the entire tab bar

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127815/#review95153 --- Makes sense! - Thomas Pfeiffer On May 2, 2016, 7:04 p.m

Re: Review Request 122249: libksysguard: add Kill Window to End Process button and show correct keyboard shortcut

ided where possible => this > > patch factors some information out of a tooltip which in itself is > > desirable. > > 4. For the user, the discoverability of the feature after applying this > > patch is better than before (though not perfect, sure). > > Thoma

Re: Review Request 122249: libksysguard: add Kill Window to End Process button and show correct keyboard shortcut

ided where possible => this > > patch factors some information out of a tooltip which in itself is > > desirable. > > 4. For the user, the discoverability of the feature after applying this > > patch is better than before (though not perfect, sure). > > Thoma

Re: Review Request 122249: libksysguard: add Kill Window to End Process button and show correct keyboard shortcut

ided where possible => this > > patch factors some information out of a tooltip which in itself is > > desirable. > > 4. For the user, the discoverability of the feature after applying this > > patch is better than before (though not perfect, sure). > > Thoma

Re: Review Request 122249: libksysguard: add Kill Window to End Process button and show correct keyboard shortcut

-mail. To reply, visit: > https://git.reviewboard.kde.org/r/122249/ > --- > > (Updated April 20, 2015, 10:24 p.m.) > > > Review request for KDE Base Apps, Martin Gräßlin, John Tapsell, and Thomas > Pfeiffer. > >

Re: Review Request 122249: libksysguard: add Kill Window to End Process button and show correct keyboard shortcut

> On April 20, 2015, 10:36 p.m., Thomas Pfeiffer wrote: > > What would likely be confusing is that the two button modes have different > > interaction flows: The "End Process" mode requires to first select a > > process and then press the button to work, whereas

Re: Review Request 122249: libksysguard: add Kill Window to End Process button and show correct keyboard shortcut

> On April 20, 2015, 10:36 p.m., Thomas Pfeiffer wrote: > > What would likely be confusing is that the two button modes have different > > interaction flows: The "End Process" mode requires to first select a > > process and then press the button to work, whereas

Re: Review Request 123806: [klipper] Ignore empty / blank entries

> On May 17, 2015, 6:22 p.m., Martin Gräßlin wrote: > > klipper/generalconfig.ui, lines 36-45 > > > > > > unrelated to the discussion about how to call the entries: I would call > > the config option differently

Re: Review Request 123806: [klipper] Ignore empty / blank entries

the menu. An option that says "Replace whitespace > with symbols" is highly confusing next to an option that says "Trim > whitespace". > > Kai Uwe Broulik wrote: > Btw I just pushed the highlight feature to the Klipper plasmoid and I > don't

Re: Review Request 123806: [klipper] Ignore empty / blank entries

> On May 16, 2015, 9:37 p.m., Patrick Eigensatz wrote: > > klipper/historyitem.cpp, line 91 > > > > > > I'm not sure if I can access "Klipper" from here. If I have a look at > > how this is done at other options

Re: Review Request 123806: [klipper] Ignore empty / blank entries

copied when you "select" > it (with the mouse) and that's pasted w/ MMB clicks. > > http://en.wikipedia.org/wiki/X_Window_selection > > I assume the timeout and history size items don't belong into that box, > which could then be a checkabl

Re: Review Request 123806: [klipper] Ignore empty / blank entries

copied when you "select" > it (with the mouse) and that's pasted w/ MMB clicks. > > http://en.wikipedia.org/wiki/X_Window_selection > > I assume the timeout and history size items don't belong into that box, > which could then be a checkabl

Re: Review Request 123806: [klipper] Ignore empty / blank entries

copied when you "select" > it (with the mouse) and that's pasted w/ MMB clicks. > > http://en.wikipedia.org/wiki/X_Window_selection > > I assume the timeout and history size items don't belong into that box, > which could then be a checkabl

Re: Review Request 123806: [klipper] Ignore empty / blank entries

> On May 16, 2015, 4:37 p.m., Christoph Feck wrote: > > klipper/klipper.kcfg, line 32 > > > > > > It would be immensely useful, if Klipper also showed leading/trailing > > whitespace, i.e. for items that aren't c

Re: Review Request 123806: [klipper] Ignore empty / blank entries

is is a placeholder? > > Patrick Eigensatz wrote: > I think the idea of (colored) placeholders is great! I've started to > create an option in the configuration dialog, we could add an option for > whitespace placeholders, too. > > Thomas Pfeiffer wrote: > This is indee

Re: Review Request 123806: [klipper] Ignore empty / blank entries

is is a placeholder? > > Patrick Eigensatz wrote: > I think the idea of (colored) placeholders is great! I've started to > create an option in the configuration dialog, we could add an option for > whitespace placeholders, too. > > Thomas Pfeiffer wrote: > This is indee

Re: Review Request 123806: [klipper] Ignore empty / blank entries

is is a placeholder? > > Patrick Eigensatz wrote: > I think the idea of (colored) placeholders is great! I've started to > create an option in the configuration dialog, we could add an option for > whitespace placeholders, too. > > Thomas Pfeiffer wrote: > This is indee

Re: Review Request 123806: [klipper] Ignore empty / blank entries

> On May 15, 2015, 7:31 p.m., Martin Gräßlin wrote: > > thanks for rebasing! > > > > I just had a look at the bug report and have to agree with comment #1: I do > > from time to time copy on purpose whitespaces (yes I'm weird). I also tend > > to copy newlines and I do want to have them in the

Re: Review Request 122249: libksysguard: add Kill Window to End Process button and show correct keyboard shortcut

> On April 20, 2015, 10:36 p.m., Thomas Pfeiffer wrote: > > What would likely be confusing is that the two button modes have different > > interaction flows: The "End Process" mode requires to first select a > > process and then press the button to work, whereas

Re: Review Request 122249: libksysguard: add Kill Window to End Process button and show correct keyboard shortcut

> On April 20, 2015, 10:36 p.m., Thomas Pfeiffer wrote: > > What would likely be confusing is that the two button modes have different > > interaction flows: The "End Process" mode requires to first select a > > process and then press the button to work, whereas

Re: Review Request 122249: libksysguard: add Kill Window to End Process button and show correct keyboard shortcut

> On April 20, 2015, 10:36 p.m., Thomas Pfeiffer wrote: > > What would likely be confusing is that the two button modes have different > > interaction flows: The "End Process" mode requires to first select a > > process and then press the button to work, whereas

Re: Review Request 122249: libksysguard: add Kill Window to End Process button and show correct keyboard shortcut

d when "End Process..." is clicked, a dialog could be opened where the process to kill would be selected. Of course the current flow of ending a process could and should still work. - Thomas Pfeiffer On April 20, 2015, 10:24 p.m., Gregor Mi wrote: > > -

Re: Placement of config files for Plasma 5 and KF5-based applications

On Wednesday 28 January 2015 18:07:14 Thomas Lübking wrote: > On Mittwoch, 28. Januar 2015 08:43:41 CET, Martin Gräßlin wrote: > > c) I simply don't care whether users have a "problem" with ~/.config > > containing many files, it's a directory for applications, not for the user > > I don't think t

Placement of config files for Plasma 5 and KF5-based applications

Hi everyone, first of all, I think it's a great step in the right direction that we're now putting our config files in ~/.config instead of ~/.kde(4), we're now finally "standard-compliant". However, where we still could - and imho should - do better is with where exactly we put them. If I look

Re: Review Request 108504: [High-dpi issues] Fix KIconDialog

> On Jan. 20, 2013, 11:53 a.m., Thomas Pfeiffer wrote: > > File Attachment: Icon Dialog with 200dpi > > <http://git.reviewboard.kde.org/r/108504/#fcomment5> > > > > Why is that icon smaller than the others? Is it because the bigger > > version of

Re: Review Request 108504: [High-dpi issues] Fix KIconDialog

ttp://git.reviewboard.kde.org//r/108504/#fcomment3> Why is that icon smaller than the others? Is it because the bigger version of it does not exist? Other than that, it looks great to me! - Thomas Pfeiffer On Jan. 20, 2013, 11:15 a.m., Kai Uwe Broulik