Re: KBibTeX in KDE Review

2014-05-14 Thread Thomas Fischer
et to the sysadmins. Bye, Thomas On Wed, Mar 26, 2014 at 07:37:02PM +0100, Thomas Fischer wrote: > Hello, > > KBibTeX is a BibTeX editor to edit bibliographies used with LaTeX. > > After being under development for nearly 10 years, KBibTeX moved a > few months ago from its pr

Re: KBibTeX in KDE Review

2014-04-10 Thread Thomas Fischer
Hello, > Basically by specifiying noMerge (you should basically not have it). You are > saying "I don't want to follow the standard orders of menus defined by KDE, > i'll define my own". > > Which is usually not what you want. Ok, I changed that as of commit 1d661da. Bye, Thomas signature.a

Re: KBibTeX in KDE Review

2014-04-09 Thread Thomas Fischer
Hello Albert, On 04/07/2014 11:55 PM, Albert Astals Cid wrote: > El Dimecres, 26 de març de 2014, a les 19:37:02, Thomas Fischer va escriure: >> Hello, >> >> KBibTeX is a BibTeX editor to edit bibliographies used with LaTeX. >> >> [ text cut ] > You don't

KBibTeX in KDE Review

2014-03-26 Thread Thomas Fischer
Hello, KBibTeX is a BibTeX editor to edit bibliographies used with LaTeX. After being under development for nearly 10 years, KBibTeX moved a few months ago from its previous hosting platform Gna! to KDE's playground. Being a mature project already when entering the playground, it may be time to c

Re: Review Request 112068: KCharSelect: Show LaTeX commands for Unicode characters

2014-01-13 Thread Thomas Fischer
cally. Maybe someone else could take the step of porting my KDE 4.11+ code to KF5. - Thomas --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/112068/#review42148 ---------

Re: Review Request 112068: KCharSelect: Show LaTeX commands for Unicode characters

2013-08-16 Thread Thomas Fischer
/kcharselectdata.cpp 41eab5b kdeui/widgets/kcharselectdata_p.h c6f7a3a Diff: http://git.reviewboard.kde.org/r/112068/diff/ Testing --- Thanks, Thomas Fischer

Re: Review Request 112068: KCharSelect: Show LaTeX commands for Unicode characters

2013-08-14 Thread Thomas Fischer
de9e184 kdeui/widgets/kcharselect.cpp e00d001 kdeui/widgets/kcharselectdata.cpp 41eab5b kdeui/widgets/kcharselectdata_p.h c6f7a3a Diff: http://git.reviewboard.kde.org/r/112068/diff/ Testing --- Thanks, Thomas Fischer

Review Request 112068: KCharSelect: Show LaTeX commands for Unicode characters

2013-08-13 Thread Thomas Fischer
between both projects. Diffs - kdeui/widgets/kcharselect.h de9e184 kdeui/widgets/kcharselectdata.cpp 41eab5b kdeui/widgets/kcharselectdata_p.h c6f7a3a Diff: http://git.reviewboard.kde.org/r/112068/diff/ Testing --- Thanks, Thomas Fischer

Review Request 109748: kioslave/sftp: Show correct port number when connecting to default port

2013-03-26 Thread Thomas Fischer
est fails. The attached patch address this issue by testing for port number 0. If the port number is invalid, the default port number is shown instead. Diffs - kioslave/sftp/kio_sftp.cpp f493477 Diff: http://git.reviewboard.kde.org/r/109748/diff/ Testing --- Thanks, Thomas Fischer

Re: Review Request 107356: Fix in documentation (comment in header): QPrinter::PaperSize instead of QPrinter::PageSize

2013-03-06 Thread Thomas Fischer
n Nov. 17, 2012, 10:31 a.m., Thomas Fischer wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/107356/ > --- &

Re: Review Request: Rewrite Google's tracking URLs in search results

2012-12-25 Thread Thomas Fischer
t from that a lot of other > > usefull scripts in userscripts.org. > > > > I do not understand the rationale behind targeting one specific website > > this way! Just my 2c :) > > Thomas Fischer wrote: > > userscripts plugin for KHTML > Do you mean this on

Re: Review Request: Rewrite Google's tracking URLs in search results

2012-12-25 Thread Thomas Fischer
tart. As I stated in the code as a TODO comment: more cases to add! - Thomas --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107867/#review23899 ----------

Review Request: Rewrite Google's tracking URLs in search results

2012-12-23 Thread Thomas Fischer
ml/khtml_settings.h 0faec6d khtml/khtml_settings.cpp b5693b4 khtml/xml/dom_docimpl.cpp bb65a89 Diff: http://git.reviewboard.kde.org/r/107867/diff/ Testing --- Thanks, Thomas Fischer

Review Request: Fix in documentation (comment in header): QPrinter::PaperSize instead of QPrinter::PageSize

2012-11-17 Thread Thomas Fischer
e() and setPaperSize(..), respectively? Diffs - kdecore/localization/klocale.h cdbc3d3 Diff: http://git.reviewboard.kde.org/r/107356/diff/ Testing --- Thanks, Thomas Fischer

Re: Review Request: Proper "All files" option when using mime types as filters for KFileDialog's functions

2011-04-21 Thread Thomas Fischer
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101075/ --- (Updated April 20, 2011, 8:50 p.m.) Review request for kdelibs. Changes

Review Request: Proper "All files" option when using mime types as filters for KFileDialog's functions

2011-04-10 Thread Thomas Fischer
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101075/ --- Review request for kdelibs. Summary --- When using mimetypes instead