Re: Kup in KDE Review

2020-04-14 Thread Simon Persson
On 2020-04-07 05:09, Adriaan de Groot wrote: On Monday, 6 April 2020 12:32:54 CEST Simon Persson wrote: Please help to review kup. - It's probably worthwhile looking at REUSE licensing compliance (see reuse.software, or ask on IRC #kde-devel) so that the license is machine- readabl

Re: Kup in KDE Review

2020-04-14 Thread Simon Persson
On 2020-04-08 16:53, Christophe Giboudeaux wrote: 'COPYING' only covers the GPL-2.0-only part of the code. You also need the GPL-3.0-only and the LicenseRef-KDE-Accepted-GPL reference. Note that we're slowly moving from the monolithic license blocks to SPDX statements. See https://community.k

Re: Kup in KDE Review

2020-04-14 Thread Simon Persson
Hello! On 2020-04-07 06:01, Nicolas Fella wrote: Hi, I briefly skimmed trough the codebase. Looks all sane to me. A few minor observations: - You may want to look into KConfigXT. It should be able to generate the classes from settings/ from an XML description. I think that I looked at it

Re: Kup in KDE Review

2020-04-14 Thread Simon Persson
On 2020-04-07 21:28, Jonathan Riddell wrote: This looks great.  I think the other comments have covered the main issues so I'll just make a cheeky feature request and suggest it gets the ability to upload to cloud storage since I would guess that's the main way to do backups these days. Talki

Re: Kup in KDE Review

2020-04-08 Thread Simon Persson
On 2020-04-07 06:02, Albert Astals Cid wrote: When in the kcm i go to add new plan i get the "Versioned backup" disabled because bup is not installed *BUT* it is still the selected radio button, i guess in that case it would make more sense if the "Synchronized backup" was the selected one, no

Kup in KDE Review

2020-04-06 Thread Simon Persson
Hello! Please help to review kup. It is a backup scheduler tightly integrated with plasma (has system setting kcm, systray plasmoid, kioslave). It supports saving backups either with bup or with rsync. It has been developed outside of KDE for many years and only now is being incubated. I

Re: Review Request 110662: Add dbus signal to ksmserver, used for requesting session saving from services.

2013-10-29 Thread Simon Persson
signal emitted on manual "save session" activation but not on log out. Thanks, Simon Persson

Re: Review Request 110663: Don't save state of running activities unless asked to by the session manager

2013-05-29 Thread Simon Persson
change would be that a power failure or crash of ksmserver would now result in the current state of running activities not getting saved, hardly critical I would say). Also saw that "restore manually saved session" now restores activities as they were when the session was saved. Thanks, Simon Persson

Review Request 110663: Don't save state of running activities unless asked to by the session manager

2013-05-27 Thread Simon Persson
tores activities as they were when the session was saved. Thanks, Simon Persson

Review Request 110662: Add dbus signal to ksmserver, used for requesting session saving from services.

2013-05-27 Thread Simon Persson
session compiled from master, logging of the signal with qbusviewer. With "restore previous session" set: signal emitted at all logouts. "save session" button is not available. With "restore manually saved session" set: signal emitted on manual "save session" activation but not on log out. Thanks, Simon Persson

Re: Review Request: Export the function isShiftAsModifierAllowed() from KKeySequenceWidget

2011-07-02 Thread Simon Persson
On Thursday 30 June 2011 02.39.01 Michael Jansen wrote: > > > > I forgot that there's a kglobalaccel in kdelibs when I wrote the > > summary.. therefore I didn't specify that this function is needed by > > the daemon kglobalaccel from kde-runtime. > > > > I went ahead and commited today, in retr

Re: Review Request: Export the function isShiftAsModifierAllowed() from KKeySequenceWidget

2011-06-29 Thread Simon Persson
and commited today, in retrospect I should probably have written this email first... Let me know if you still have concerns regarding this! Simon > On June 6, 2011, 8:46 a.m., Simon Persson wrote: > > --- > &

Re: Review Request: Fix global shortcuts that needs shift key, like for example ctrl+% (ctrl+shift+5 on many keyboards)

2011-06-08 Thread Simon Persson
.org/r/101520/#review3751 --- On June 6, 2011, 11:02 a.m., Simon Persson wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > ht

Re: Review Request: Fix meta+shift+tab and similar global shortcuts.

2011-06-08 Thread Simon Persson
tp://git.reviewboard.kde.org/r/101523/#review3752 --- On June 6, 2011, 11:24 a.m., Simon Persson wrote: > > --- > This is an automatically generated e-mail. To reply, vi

Review Request: Allow use of shift together with multimedia keys in shortcuts

2011-06-07 Thread Simon Persson
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101530/ --- Review request for kdelibs and Michael Jansen. Summary --- Make this

Review Request: Fix meta+shift+tab and similar global shortcuts.

2011-06-06 Thread Simon Persson
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101523/ --- Review request for KDE Runtime and Michael Jansen. Summary --- When e

Review Request: Fix global shortcuts that needs shift key, like for example ctrl+% (ctrl+shift+5 on many keyboards)

2011-06-06 Thread Simon Persson
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101520/ --- Review request for KDE Runtime and Michael Jansen. Summary --- Second

Review Request: Export the function isShiftAsModifierAllowed() from KKeySequenceWidget

2011-06-06 Thread Simon Persson
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101515/ --- Review request for kdelibs and Michael Jansen. Summary --- First of t