Re: Review Request 117345: Fix crash in KIO due to exposing inconsistent views of internal data.

2015-04-20 Thread Simeon Bird
this for kdelibs 4, but the code seems unchanged in kdelibs 5. Diffs - kio/kio/kdirlister.cpp aad6893f47eba81c3f78ed1ca7327adf6fb587bb Diff: https://git.reviewboard.kde.org/r/117345/diff/ Testing --- It fixes the crash! It might break something else. Thanks, Simeon Bird

Re: Review Request 117345: Fix crash in KIO due to exposing inconsistent views of internal data.

2015-04-20 Thread Simeon Bird
kdelibs 5. Diffs - kio/kio/kdirlister.cpp aad6893f47eba81c3f78ed1ca7327adf6fb587bb Diff: https://git.reviewboard.kde.org/r/117345/diff/ Testing --- It fixes the crash! It might break something else. Thanks, Simeon Bird

Re: Review Request 117345: Fix crash in KIO due to exposing inconsistent views of internal data.

2015-04-20 Thread Simeon Bird
//git.reviewboard.kde.org/r/117345/#review79240 --- On Dec. 19, 2014, 6:50 p.m., Simeon Bird wrote: > > --- > This is an automatically generated e-mail. To

Review Request 121599: Fix crash in KIO due to exposing inconsistent views of internal data.

2014-12-19 Thread Simeon Bird
Thanks, Simeon Bird

Re: Review Request 117345: Fix crash in KIO due to exposing inconsistent views of internal data.

2014-12-19 Thread Simeon Bird
kdelibs 4, but the code seems unchanged in kdelibs 5. Diffs - kio/kio/kdirlister.cpp aad6893f47eba81c3f78ed1ca7327adf6fb587bb Diff: https://git.reviewboard.kde.org/r/117345/diff/ Testing --- It fixes the crash! It might break something else. Thanks, Simeon Bird

Re: Review Request 117345: Fix crash in KIO due to exposing inconsistent views of internal data.

2014-04-05 Thread Simeon Bird
fferent. - Simeon --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117345/#review55040 --- On April 3, 2014, 2:29 a.m., Simeon Bird wrote: > > ---

Re: Review Request 117345: Fix crash in KIO due to exposing inconsistent views of internal data.

2014-04-05 Thread Simeon Bird
://git.reviewboard.kde.org/r/117345/#review54950 ------- On April 3, 2014, 2:29 a.m., Simeon Bird wrote: > > --- > This is an automatically generated e-mail. To

Review Request 117345: Fix crash in KIO due to exposing inconsistent views of internal data.

2014-04-02 Thread Simeon Bird
/kdirlister.cpp aad6893f47eba81c3f78ed1ca7327adf6fb587bb Diff: https://git.reviewboard.kde.org/r/117345/diff/ Testing --- It fixes the crash! It might break something else. Thanks, Simeon Bird

Re: Nepomuk in 4.13 and beyond

2013-12-15 Thread Simeon Bird
> Could you please enumerate what all that involves? From what I know there is - > > 1. Metadata model for running queries > 2. Timeline based stuff - again, queries > 3. Showing File metadata - There is a File class and a FileFetchJob > 4. File ratings/comments - There is no API right now as I ha

Re: Review Request 110898: Remove unused strigi dependency from tree, along with unused strigi FontAnalyzer.

2013-06-09 Thread Simeon Bird
> On June 9, 2013, 10:27 a.m., Albert Astals Cid wrote: > > Being past the Feature Freeze doesn't seem a good idea to me to remove a > > feature. > > Simeon Bird wrote: > It isn't really removing a feature - the code in question does nothing at > all

Re: Review Request 110898: Remove unused strigi dependency from tree, along with unused strigi FontAnalyzer.

2013-06-09 Thread Simeon Bird
95 Diff: http://git.reviewboard.kde.org/r/110898/diff/ Testing --- Compiled, ran Thanks, Simeon Bird

Re: Review Request 110898: Remove unused strigi dependency from tree, along with unused strigi FontAnalyzer.

2013-06-09 Thread Simeon Bird
---- On June 9, 2013, 1:53 a.m., Simeon Bird wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/110898/ > -

Re: Review Request 110898: Remove unused strigi dependency from tree, along with unused strigi FontAnalyzer.

2013-06-09 Thread Simeon Bird
eviewboard.kde.org/r/110898/#review33969 --- On June 9, 2013, 1:53 a.m., Simeon Bird wrote: > > --- > This is an automatically generated e-mail. To reply, visit: >

Review Request 110898: Remove unused strigi dependency from tree, along with unused strigi FontAnalyzer.

2013-06-08 Thread Simeon Bird
05a2a75b18e9ec9 kcontrol/kfontinst/strigi-analyzer/FontThroughAnalyzer.cpp ffa22a9ad09617b6ab87652ee0a9f246e0502227 plasma/desktop/applets/kickoff/CMakeLists.txt e9e288866ecdcfd7aa35c086dfe78d4252748995 Diff: http://git.reviewboard.kde.org/r/110898/diff/ Testing --- Compiled, ran

Re: Review Request: Make Sonnet::Speller::setLanguage threadsafe, fixing segfaults in krunner

2012-09-19 Thread Simeon Bird
gt; > the spelling (or even just moveToThread it if you have to) and instead of > > calling setLanguage from another thread create a signal/slot combination > > between the parent thread and the speller thread and send a language change > > request by emitting a signal fro

Re: Review Request: Make Sonnet::Speller::setLanguage threadsafe, fixing segfaults in krunner

2012-09-19 Thread Simeon Bird
gt; > the spelling (or even just moveToThread it if you have to) and instead of > > calling setLanguage from another thread create a signal/slot combination > > between the parent thread and the speller thread and send a language change > > request by emitting a signal fro

Re: Review Request: Make Sonnet::Speller::setLanguage threadsafe, fixing segfaults in krunner

2012-09-19 Thread Simeon Bird
gt; > the spelling (or even just moveToThread it if you have to) and instead of > > calling setLanguage from another thread create a signal/slot combination > > between the parent thread and the speller thread and send a language change > > request by emitting a signal fro

Re: Review Request: Make Sonnet::Speller::setLanguage threadsafe, fixing segfaults in krunner

2012-09-19 Thread Simeon Bird
tomatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106242/#review18865 --- On Sept. 9, 2012, 10:06 p.m., Simeon Bird wrote: > > --

Re: Review Request: Make Sonnet::Speller::setLanguage threadsafe, fixing segfaults in krunner

2012-09-11 Thread Simeon Bird
sentence... > > > > Maybe it would make more sense to "post" the language change operation to > > the spell-checking thread using the same mechanism as the one used to > > "post" spellchecking requests to it? (Disclaimer: I know nothing of the > &

Re: Review Request: Make Sonnet::Speller::setLanguage threadsafe, fixing segfaults in krunner

2012-09-11 Thread Simeon Bird
sentence... > > > > Maybe it would make more sense to "post" the language change operation to > > the spell-checking thread using the same mechanism as the one used to > > "post" spellchecking requests to it? (Disclaimer: I know nothing of the > &

Re: Review Request: Make Sonnet::Speller::setLanguage threadsafe, fixing segfaults in krunner

2012-09-10 Thread Simeon Bird
sting --- Compiled, installed, used for a week or so, spellchecked a bunch of things. Thanks, Simeon Bird

Re: Review Request: Make Sonnet::Speller::setLanguage threadsafe, fixing segfaults in krunner

2012-09-10 Thread Simeon Bird
ame dictLock to lock, and use it for > > all members. Ok - this makes the locking around update() a bit complex. (That was why I didn't do it before: it is not necessary for the krunner spelling fix, and I was lazy) - Simeon

Review Request: Make Sonnet::Speller::setLanguage threadsafe, fixing segfaults in krunner

2012-08-27 Thread Simeon Bird
03831 Diffs - kdecore/sonnet/speller.cpp b19e74d Diff: http://git.reviewboard.kde.org/r/106242/diff/ Testing --- Compiled, installed, used for a week or so, spellchecked a bunch of things. Thanks, Simeon Bird