Re: Review Request 125476: Fix QUrl usage when calling QFileDialog::getExistingDirectory()

marked as submitted. Review request for kdelibs and David Faure. Changes --- Submitted with commit e46dc22d5fe84ed0a64e0712d8083756f99b3fa5 by Sergio Martins to branch master. Repository: kio Description --- - Passing openUrl.toString() is wrong, it should have been openUrl.path

Re: Review Request 125476: Fix QUrl usage when calling QFileDialog::getExistingDirectory()

for local files, innit ? - Sergio --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125476/#review86216 --- On Oct. 1, 20

Review Request 125476: Fix QUrl usage when calling QFileDialog::getExistingDirectory()

local file string, which we then were re-converting to QUrl again, so instead just call getExistingDirectoryUrl() directly. Diffs - src/widgets/kurlrequester.cpp 1b3bbdf Diff: https://git.reviewboard.kde.org/r/125476/diff/ Testing --- Thanks, Sergio Martins

Using nullptr instead of Q_NULLPTR

Hi, https://community.kde.org/Frameworks/Policies#Frameworks_compiler_requirements_and_C.2B.2B11 states gcc 4.5 as the minimum version, meaning we can't use nullptr. However, since some time now, kf5 libraries are full of nullptr (~400 occurrences) and nobody noticed. We can either: - Bump t

Re: Replacement for KDateTime

On Monday, August 03, 2015 14:59:59 Dāvis Mosāns wrote: > Sorry for injecting myself, but IMO there's no such thing as Date-only and > what you need is something like QDateTimeRange (just made up) where you > would have start QDateTime, end QDateTime and it could represent any > Event/Interval. Lik

Re: Replacement for KDateTime

On Tuesday, August 04, 2015 14:48:02 John Layt wrote: > On 4 August 2015 at 10:45, John Layt wrote: > > Most of this discussion is very very off-topic, it belongs on the Qt > > development list, can we get back to the main topic of KCalCore and > > QDateTime? I have limited time to spare and I'd r

Re: [Kde-pim] Coding style: block braces in switch cases

On Monday, January 13, 2014 17:05:04 Kevin Krammer wrote: > > I've looked around and found quite a variation: > > e.g. qdatetime.cpp: > switch (...) { > case Foo: { > } > } > > e.g. qrasterizer.cpp: > switch (...) { > case Foo: > { > } > } > e.g. qcommandlineparser.cpp: > switch (

Re: Review Request: Add a QSplitter between the places view and the directory tree in KDirSelectDialog

--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/758/#review10092 --- trunk/KDE/kdelibs/kfile/kdirselectdialog.cpp