Re: Review Request 110514: Me more precise about the error message in case KSaveFile fails.

2013-05-18 Thread Sergio Luis Martins
marked as submitted. Review request for kdelibs and David Faure. Description --- "Unable to open temporary file" isn't very informative. Diffs - kdecore/io/ksavefile.cpp 6cdd41e Diff: http://git.reviewboard.kde.org/r/110514/diff/ Testing --- yep Thank

Re: Review Request 110514: Me more precise about the error message in case KSaveFile fails.

2013-05-18 Thread Sergio Luis Martins
isit: http://git.reviewboard.kde.org/r/110514/#review32757 ------- On May 18, 2013, 7:43 p.m., Sergio Luis Martins wrote: > > --- > This is an automatically generated

Review Request 110514: Me more precise about the error message in case KSaveFile fails.

2013-05-18 Thread Sergio Luis Martins
nable to open temporary file" isn't very informative. Diffs - kdecore/io/ksavefile.cpp 6cdd41e Diff: http://git.reviewboard.kde.org/r/110514/diff/ Testing --- yep Thanks, Sergio Luis Martins

Re: Review Request 109245: Remove duplicated calendar classes from calendar plasmoid

2013-03-03 Thread Sergio Luis Martins
plasma/generic/dataengines/calendar/eventdatacontainer.cpp 63db4df Diff: http://git.reviewboard.kde.org/r/109245/diff/ Testing --- Used "plasmoidviewer calendar" to test. Thanks, Sergio Luis Martins

Review Request 109245: Remove duplicated calendar classes from calendar plasmoid

2013-03-03 Thread Sergio Luis Martins
t; to test. Thanks, Sergio Luis Martins

Re: Review Request: New Date/Time Widgets in kdelibs/kdeui

2011-06-11 Thread Sergio Luis Martins
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101575/#review3844 --- kdeui/widgets/kdatecombobox.h

Re: Review Request: Fix DAV jobs bug

2011-02-20 Thread Sergio Luis Martins
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100694/#review1537 --- kio/kio/davjob.cpp

Re: Review Request: Enable kDebug/kWarning/kError colors when sending output to file instead of tty

2011-02-18 Thread Sergio Luis Martins
-- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100675/#review1488 --- On Feb. 17, 2011, 8:49 p.m., Sergio Luis Martins wrote: > > -

Re: Review Request: Enable kDebug/kWarning/kError colors when sending output to file instead of tty

2011-02-18 Thread Sergio Luis Martins
r other you can just set it to 0, 1, 2. People might even use "never" and think it would disable colors. We should use either a set/unset approach or an approach with full strings for every option: "always", "never" (default), "onlytty&quo

Re: Review Request: Enable kDebug/kWarning/kError colors when sending output to file instead of tty

2011-02-18 Thread Sergio Luis Martins
---------- On Feb. 17, 2011, 8:49 p.m., Sergio Luis Martins wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/100675/ > ---

Review Request: Enable kDebug/kWarning/kError colors when sending output to file instead of tty

2011-02-17 Thread Sergio Luis Martins
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100675/ --- Review request for kdelibs. Summary --- The existing KDE_COLOR_DEBUG