Re: Review Request 112099: [kcontrol/locale] update the sample when input changed

2013-08-15 Thread Santeri Piippo
/diff/ Testing --- replaced kcm_locale.so in kubuntu 13.04 with git-compiled one, works fine for me. Thanks, Santeri Piippo

Re: Review Request 112099: [kcontrol/locale] update the sample when input changed

2013-08-15 Thread Santeri Piippo
, Santeri Piippo

Re: Review Request 112099: [kcontrol/locale] update the sample when input changed

2013-08-15 Thread Santeri Piippo
; > it. Also makes sure you don't introduce subtle bugs in the future if > > someone expands a function to do something else but forgets to add an | enum > > > > Anyone else has an opinion? > > Santeri Piippo wrote: > Without the filtering I had some seve

Re: Review Request 112099: [kcontrol/locale] update the sample when input changed

2013-08-15 Thread Santeri Piippo
; > it. Also makes sure you don't introduce subtle bugs in the future if > > someone expands a function to do something else but forgets to add an | enum > > > > Anyone else has an opinion? > > Santeri Piippo wrote: > Without the filtering I had some seve

Re: Review Request 112099: [kcontrol/locale] update the sample when input changed

2013-08-15 Thread Santeri Piippo
way to filter things like that... 4 bools would just be flat out confusing IMO. - Santeri --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112099/#review37845 -------