Re: Review Request: fix infinite recurssion in kcategorizedview

2011-12-04 Thread Ruurd Pels
. If readability suffers... yet another reason for refactoring. - Ruurd Pels On Dec. 4, 2011, 8:42 a.m., Jaime Torres Amate wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.

Re: Review Request: fix infinite recurssion in kcategorizedview

2011-12-03 Thread Ruurd Pels
as easy as moving the rest of the function in the else clause AFAICS on short notice. - Ruurd Pels On Dec. 3, 2011, 10:55 a.m., Jaime Torres Amate wrote: > > --- > This is an automatically generated e-mail. To

Re: Review Request: Fix crash in KonqView

2011-11-17 Thread Ruurd Pels
ode it looks like m_service should always be initialized beforehand, so why is it that that did not happen for that particular website. Maybe an errormessage is in order? - Ruurd Pels On Nov. 17, 2011, 8:33 p.m., Dawit Alemayehu

Re: detection if applet is running

2011-10-29 Thread Ruurd Pels
g the applet expose something over DBUS or by any other means necessary and add that to KDE and/or Qt. -- Ruurd Pels, Boogerd 1, 1791 GW Den Burg - Texel, The Netherlands ru...@kde.nl http://about.me/ruurdpels +31612914545

Re: detection if applet is running

2011-10-28 Thread Ruurd Pels
dbus on plasma to > query running applets (which would the easiest way to implement what I > need) but could not find anything like that in org.kde.plasma-desktop -- Ruurd Pels, Boogerd 1, 1791 GW Den Burg - Texel, The Netherlands ru...@kde.nl http://about.me/ruurdpels +31612914545

Re: Review Request: Avoid possible null pointer dereferences in khtml

2011-10-07 Thread Ruurd Pels
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102794/#review7169 --- Ship it! Ship It! - Ruurd Pels On Oct. 7, 2011, 4:25 p.m

Re: Review Request: Avoid possible null pointer dereferences in khtml

2011-10-07 Thread Ruurd Pels
> On Oct. 7, 2011, 2:35 p.m., Ruurd Pels wrote: > > Revert the whitespace changes with git. Other than that I dislike multiple > > exit points even in trivially short functions. It really does not hurt to > > create a local variable holding the result of the function and

Re: Review Request: Avoid possible null pointer dereferences in khtml

2011-10-07 Thread Ruurd Pels
fer conditions always yielding true, for example if ( xxx->isEmpty() == false) ) instead. - Ruurd Pels On Oct. 7, 2011, 2:13 p.m., Jaime Torres Amate wrote: > > --- > This is an automatically generated e-mail. To reply

Re: Review Request: Avoid possible null pointer dereferences in khtml

2011-10-07 Thread Ruurd Pels
fer conditions always yielding true, for example if ( xxx->isEmpty() == false) ) instead. - Ruurd Pels On Oct. 7, 2011, 2:13 p.m., Jaime Torres Amate wrote: > > --- > This is an automatically generated e-mail. To reply

Re: X11 expert help needed

2011-07-26 Thread Ruurd Pels
On Tuesday 26 July 2011 22.43.33 Alexander Neundorf wrote: > > Should the stuff we do just be merged into the cmake version ? > > Can somebody who knows more about X11 please have a look at these two > > files, one in kdelibs, the other one in cmake 2.8.5 or git HEAD ? > > http://cmake.org/gitweb?