Re: KOpeningHours in kdereview

> For the flex/bison code it might be possible to factor out these parts, as > it's largely very basic C++ code anyway. You'd need to rebuild most of the > logic around that though I'm afraid. Everything that works and can help me spot syntax errors help. If I can't parse some things then it is n

Re: KOpeningHours in kdereview

> but meanwhile it's also being > evaluated for use in OSM validation tooling: > https://github.com/osm-fr/osmose-backend/issues/555. That has already > resulted in a number of contributions increasing the tolerance for > non-conforming expressions, which benefits all other use-cases as well. I wa

Re: KOSMIndoorMap in kdereview

Am Donnerstag, 22. Oktober 2020, 17:25:32 CEST schrieb Volker Krause: > Hi, > > KOSMIndoorMap is a QML component for showing multi-floor OSM indoor maps (as > its very creative name might suggest). It's using maps.kde.org as a data > source (same as Marble), and has been created to show interactiv

Re: Information regarding upcoming Gitlab Migration

Bhushan Shah wrote: I've worked on draft "move" of the current set of the repositories in their respective subgroups at the repo-metadata project's branch [1]. You can browse the directory structure to get idea of how final structure on Gitlab would look like. No objection, just a request for

Re: Installing qml caches

Am 2018-06-01 13:10, schrieb Alexander Volkov: Hi all, It would be nice to install .qmlc files in addition to .qml files to reduce start-up time of applications. They are generated with qmlcachegen. For Qt 5.11: qmlcachegen -o example.qmlc qxample.qml Currently qml files are usually installed t

Re: Symmy in kde-review

Am Montag, 4. Dezember 2017, 22:14:14 schrieb Elvis Angelaccio: > On lunedì 4 dicembre 2017 10:25:48 CET, Tomaz Canabrava wrote: > > On Sun, Dec 3, 2017 at 11:14 PM, Albert Astals Cid wrote: > > El dijous, 23 de novembre de 2017, a les 10:34:41 CET, Elvis Angelaccio va > > > > escriure: > >> Hi,

Re: Review Request 130193: [cmake]: De-duplicate "else" to fix build with cmake-3.9

from the else() and endif() calls. - Rolf Eike Beer On Juli 20, 2017, 7:59 nachm., Heiko Becker wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

Re: kdereview: ksmtp

Am Donnerstag, 11. Mai 2017, 17:03:01 schrieb Daniel Vrátil: > Hi, > > please review ksmtp, which is now in kdereview. -the CMakeLists.txt has a mix of spaces inside () or not -in loginjob, line 173, you check for code 25. Should this be 250? Or is that 25*? Where is ServerResponse actually def

Re: Review Request 128941: ZLIB dependency is in libkonq since 7635179

tps://git.reviewboard.kde.org/r/128941/#comment66843> If Konqueror directly uses these symbols it needs to explicitely link to it, even if libkonq does. - Rolf Eike Beer On Sept. 18, 2016, 11:36 nachm., Andreas Sturmlechner wrote: > > ---

Re: kconfig_compiler help ( reproducible builds )

Am Freitag, 27. Mai 2016, 09:18:25 schrieb Scarlett Clark: > I still need help with this, hacking the packaging was not accepted. > Here is the exact problem: > https://reproducible-builds.org/docs/locales/#collation-order > > Looking at kconfig_compiler code that only thing that is standing out i

Re: Review Request 104960: KJS: fix behaviour on allocation errors

used for calculations (which is (void*)-1), other will have 0. This will make the allocator have a sane default behaviour: just return 0. Diffs - kjs/collector.cpp 70e4757 Diff: https://git.reviewboard.kde.org/r/104960/diff/ Testing --- Thanks, Rolf Eike Beer

Re: Change to Mail Infrastructure - SPF and DKIM verification will now be enforced

Am Freitag, 4. Dezember 2015, 16:14:10 schrieb Nicolás Alvarez: > 2015-12-04 16:07 GMT-03:00 Rolf Eike Beer : > > Ben Cooksley wrote: > >> It is an extreme pity these mailing list providers have demonstrated > >> such an extreme disregard for standards which aim to e

Re: Change to Mail Infrastructure - SPF and DKIM verification will now be enforced

Ben Cooksley wrote: > On Fri, Dec 4, 2015 at 11:28 PM, Jan Kundrát wrote: > > On Friday, 4 December 2015 10:56:42 CET, Ben Cooksley wrote: > >> Note that in the long run with DMARC looming you will need to switch > >> to #2 anyway, and keeping your current behaviour will likely lead to > >> mail f

Re: Change to Mail Infrastructure - SPF and DKIM verification will now be enforced

Am 04.12.2015 11:08, schrieb Ben Cooksley: On Fri, Dec 4, 2015 at 9:01 AM, Rolf Eike Beer wrote: Think of SPF: I sent an email to a kde.org email address only some weeks ago. My domain sets a SPF policy. The KDE server accepts this (it's actually correct), and then sends the ma

Re: Change to Mail Infrastructure - SPF and DKIM verification will now be enforced

Am Donnerstag, 3. Dezember 2015, 11:54:43 schrieb Jan Kundrát: > On Thursday, 3 December 2015 07:13:07 CET, Ben Cooksley wrote: > > I will be re-enabling DKIM validation in one week's time - which will > > then break subscriptions to Debian mailing lists (as any email from > > anyone who has enable

Re: Review Request 124824: [OS X] FindKDE4Internal.cmake : reintroduce a cmake_minimum_required statement

Am Mittwoch, 19. August 2015, 21:14:38 schrieb Heiko Becker: > I stumbled upon the same, it's actually a bug in cmake fixed by this commit: > > http://www.cmake.org/gitweb?p=cmake.git;a=commit;h=b9ec9392da21a3421e48c6961 > 976060d872faffb But the short fix for this is indeed to put cmake_minimum_

Re: Review Request 122987: Allow user to specify path to myspell dictionary files

> On März 17, 2015, 1:07 nachm., Laurent Montel wrote: > > src/plugins/hunspell/hunspellclient.cpp, line 27 > > > > > > #include "..." > > we use local file. No, the file is in an include path, not in the sam

Re: KDE4 & SSL

Am Dienstag 21 Oktober 2014, 10:52:38 schrieb Thiago Macieira: > On Monday 20 October 2014 21:00:51 Pali Rohár wrote: > > Hello! > > > > Do you know which KDE4 libraries are using SSL and TLS protocols? > > And it is now possible to disable SSLv2 and SSLv3 protocols in > > KDE4 libraries? > > Tha

Re: Review Request 120543: Update FindPostgreSQL.cmake

Am 10.10.2014 08:46, schrieb Jaroslaw Staniek: On 10 October 2014 08:05, Rolf Eike Beer wrote: Update FindPostgreSQL.cmake to make is useful. Based on cmake's (3.x) one but further improved PostgreSQL_TYPE_INCLUDE_DIR lookup. The fix comes from libpredicate (master). I see no upstrea

Re: Review Request 120543: Update FindPostgreSQL.cmake

> Update FindPostgreSQL.cmake to make is useful. Based on cmake's (3.x) one > but further improved PostgreSQL_TYPE_INCLUDE_DIR lookup. The fix comes from > libpredicate (master). I see no upstream bug report for this. Eike signature.asc Description: This is a digitally signed message part.

Re: Review Request 120202: [OS X] improvements to the kwallet/OSX keychain integration

> OK, implementation question. > > How do I declare a slot in a private class that doesn't have a specific > header file? Putting `private QSLOT` above the function definition makes > things compile, but the runtime complains about a missing slot (curiously > even expecting it in KWallet::Wallet).

Re: Review Request 120287: [OS X] make kde-workspace build

Am Freitag, 19. September 2014, 22:57:40 schrieb René J.V. Bertin: > > On Sept. 20, 2014, 12:26 a.m., Christoph Feck wrote: > > > You added APPLE to the if() but not always to the matching endif()... > > True. But that's optional, no? The endif needs to have either a matching argument to the last

Re: Review Request 119498: Report crashes of KDE apps in Apple OS X (2)

> In this review we have three portability problems: > > 1. On Apple OS X, Dr Konqi's dialog box hides itself underneath the main > window of the app that has just crashed, so is effectively useless. This > appears to be because Dr Konqi is started by a Linux/Unix method (fork() + > exec()?). If a

Re: Review Request 116097: No longer use strlcpy in kstartupconfig

fopen/fgets/fixed size buffer stuff and replace it with std streams or something like that? - Rolf Eike Beer On Feb. 26, 2014, 6:11 p.m., Alexander Richardson wrote: > > --- > This is an automatically generated e-mail. To rep

Re: Review Request 115651: Fix HTTP redirection handling (3XX status code)

Am Mittwoch, 12. Februar 2014, 17:10:49 schrieb Andrea Iacovitti: > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/115651/#review49669 > ---

Re: Review Request 115689: Fix khtml/ecma/xmlhttprequest.cpp to properly handle HEAD requests

Am 12.02.2014 10:56, schrieb Dawit Alemayehu: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115689/ --- (Updated Feb. 12, 2014, 9:56

Re: Moving Baloo forward

Am Dienstag, 28. Januar 2014, 20:10:13 schrieb Ivan Čukić: > > To move a file to another machine and have the metadata be copied and re- > > indexed on that new machine as well. The copy process just needs to take > > care of transfering the xattr. This can even work when using a USB stick > > or s

Re: Moving Baloo forward

Am Freitag, 24. Januar 2014, 15:59:12 schrieb Vadim Zhukov: > 2014/1/24 Sebastian Kügler : > > On Friday, January 24, 2014 01:24:54 Vadim Zhukov wrote: > >> in the best case you'll have two totally different codepaths > >> that you'll have to manage. > > > > This should be "worst case", I think. I

Re: Review Request 114737: KInfocenter/OpenGL: reimplement the ReadPipe() function with QProcess

nitpick (that doesn't deserve a new diff): you could make the FileName argument to that function "const QString &". - Rolf Eike Beer On Jan. 4, 2014, 4:54 p.m., Wolfgang Bauer wrote: > > --- > This is an automa

Re: Review Request 114737: KInfocenter/OpenGL: reimplement the ReadPipe() function with QProcess

tps://git.reviewboard.kde.org/r/114737/#comment33389> This allocates a new object on the heap that is never freed. Just use "QProcess pipe;" - Rolf Eike Beer On Jan. 4, 2014, 9 a.m., Wolfgang Bauer wrote: > > --- > This is an

Re: Review Request 113779: KInfocenter/OpenGL: fix ReadPipe() in the case that the command cannot be run

> ReadPipe() doesn't return 0 as expected in the case that the command is not > found. but the length of sh's output which is "command not found" in this > case. This is because popen() does not fail if the command is not found, > because it _can_ run "sh". (according to the man page, popen calls "

Re: Review Request 112528: Make it possible to preserve mtime for copy jobs not just move ones

Am Donnerstag 05 September 2013, 08:43:48 schrieb Rolf Eike Beer: > > Diffs > > - > > > > kio/kio/job.cpp 8ff088c > > > > Diff: http://git.reviewboard.kde.org/r/112528/diff/ > > Is it reviewboard fooling me or is there no diff? This one does exis

Re: Review Request 112528: Make it possible to preserve mtime for copy jobs not just move ones

> Diffs > - > > kio/kio/job.cpp 8ff088c > > Diff: http://git.reviewboard.kde.org/r/112528/diff/ Is it reviewboard fooling me or is there no diff? Eike signature.asc Description: This is a digitally signed message part.

Re: Review Request 111648: Fix for GroupExpander that overlaps application icon

Testing --- Works for me Have you tested this with a vertical panel? File Attachments Before patch http://git.reviewboard.kde.org/media/uploaded/files/2013/07/23/snapshot11.png After patch http://git.reviewboard.kde.org/media/uploaded/files/2013/07/23/snapshot12.p

Re: KDirWatch bug and the analysis. Help is welcome!

David Faure wrote: > On Thursday 01 August 2013 01:30:08 Mark wrote: > > However, we have been given the power of inotify which gives more detailed > > signals and lets us know which files have been created/added/modified > > which > > we should be used imho. > > OK. First let's imagine that it's

Re: Supported Compilers / C++11 Support in KF5

Am Montag, 22. Juli 2013, 19:14:10 schrieb Alexander Neundorf: > On Sunday 21 July 2013, Rolf Eike Beer wrote: > > I totally agree with that. As I said: detection of this is trivial at > > CMake time, maybe I get my C++ feature detection package ready even to be > > included

Re: Supported Compilers / C++11 Support in KF5

Am Sonntag, 21. Juli 2013, 14:11:07 schrieb Volker Krause: > On Sunday 21 July 2013 13:52:06 Rolf Eike Beer wrote: > > Volker Krause wrote: > > > - GCC >= 4.5 > > > > > > - override > > > > Explicit virtual overrides require g++ 4.7: > >

Re: Supported Compilers / C++11 Support in KF5

Volker Krause wrote: > - GCC >= 4.5 > - override Explicit virtual overrides require g++ 4.7: http://gcc.gnu.org/projects/cxx0x.html This is trivially to work around by a CMake time check and then just define override to empty. Eike signature.asc Description: This is a digitally signed messa

Re: Review Request 110687: DrKonqi should check for disabled version as the very first step in the reporting assistant.

Martin Gräßlin wrote: Could you please get some feedback from packagers. I'm not sure whether they like words like "unmaintained" and "upgrade". The fact that we as upstream don't accept bugs doesn't mean it's unmaintained by the distro and it's not said that one could upgrade (think of Debian S

Re: KDE Workspace broken due to upstream CMake changes

Am 27.05.2013 09:13, schrieb Ben Cooksley: Hi all, It seems that a recent upstream change in CMake has now broken the build of KDE Workspace. Can someone please fix or prod CMake upstream into revising their policies? The lack of warning here concerning the change is a little irritating. -- Lo

Re: Review Request 110633: Don't report crashes if version is disabled in Bugzilla

Am Samstag 25 Mai 2013, 10:19:37 schrieb Jekyll Wu: > Well, DrKonqi uses Product.get API to fetch product information from > bugs.kde.org, including all available versions (either active or disabled). > But that is not the point of those "escaped" reports which shouldn't be > accepted. Even if DrK

Re: libs/kworkspace/kdisplaymanager.cpp mess

Am Dienstag, 7. Mai 2013, 22:21:46 schrieb Àlex Fiestas: > Would be nice to have some kind of unittests on this, that will make a > different with the current implementation (which afaik it has none) Even better would be to have them first to prove that nothing changed afterwards ;) Eike signatu

Re: NepomukCore - Do not merge KDE/4.10 into master

Am Dienstag, 7. Mai 2013, 00:30:25 schrieb Albert Astals Cid: > El Dissabte, 4 de maig de 2013, a les 14:01:45, Vishesh Handa va escriure: > > Hey everyone > > > > As you might have heard there was a fiasco in the nepomuk-core repository > > where the 'master' branch was accidentally merged into K

Re: Review Request 110091: clean up and update FreeBSD support for kinfocenter

Am 02.05.2013 15:12, schrieb Max Brazhnikov: On Wed, 01 May 2013 14:44:39 +0200 Rolf Eike Beer wrote: On April 20, 2013, 2:11 p.m., Rolf Eike Beer wrote: kinfocenter/Modules/base/info_fbsd.cpp, line 136 <http://git.reviewboard.kde.org/r/110091/diff/1/?file=139992#file139992l ine136>>

Re: Review Request 110271: libusb-1 support in kcmusb (kinfocenter)

Am 02.05.2013 15:49, schrieb Max Brazhnikov: Use libusb-1 to query info about usb devices in kinfocenter. Remove *BSD specific code: it doesn't work on all supported FreeBSD versions. In principle it can be saved for NetBSD, but NetBSD could use libusb-1, thus drop it for simplification. Remove

Re: Review Request 110091: clean up and update FreeBSD support for kinfocenter

> > On April 20, 2013, 2:11 p.m., Rolf Eike Beer wrote: > > > kinfocenter/Modules/base/info_fbsd.cpp, line 136 > > > <http://git.reviewboard.kde.org/r/110091/diff/1/?file=139992#file139992l > > > ine136>> > > > > Why not just

Re: Review Request 110110: Add Musics , Downloads , Videos, Pictures places bookmarks to kfileplacesmodal

Am Sonntag 21 April 2013, 02:54:30 schrieb Ömer Fadıl Usta: > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/110110/ > --- > > Revie

Re: Review Request 110091: clean up and update FreeBSD support for kinfocenter

ttp://git.reviewboard.kde.org/r/110091/#comment23355> This line is flagged to have inconsistent whitespace. kinfocenter/Modules/info/CMakeLists.txt <http://git.reviewboard.kde.org/r/110091/#comment23357> I miss a include_directories(${DEVINFO_INCLUDE_DIRS}) or something like

Re: Review Request 110042: Find Qt5 version of DBusMenuQt

Am Dienstag 16 April 2013, 13:26:23 schrieb Frederik Gladhorn: > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/110042/ > --- > > Re

Re: [kdelibs] kded: Disable KHostnameD in KDED

Am 15.04.2013 12:43, schrieb Àlex Fiestas: Git commit 8d99f863724c6fe76d008da4455fa177af2ee3ee by Àlex Fiestas. Committed on 15/04/2013 at 12:24. Pushed by afiestas into branch 'master'. Disable KHostnameD in KDED KHostnameD monitors the hostname by polling gethostname every 5 seconds to adap

Re: Progress notifications questions

Am 04.04.2013 11:31, schrieb Mirko Boehm: Hi guys, Danimo and I have been working on desktop progress feedback for Creator in Plasma desktop and Unity. See the attached screenshot for the current state. After discussions in #kde-devel, I implemented an adapted KJob and used KUiServerJobTracke

Re: Password strengh meter in KNewPasswordDialog

Am Mittwoch 03 April 2013, 18:47:17 schrieb Cristian Tibirna: > On Wednesday 03 April 2013 22:39:47 Rolf Eike Beer wrote: > > Hi all, > > > > the current issue of (German) Linux Magazin has an article comparing some > > GnuPG frontends. One issue discussed ther

Re: Password strengh meter in KNewPasswordDialog

Am Mittwoch 03 April 2013, 14:53:40 schrieb Thiago Macieira: > On quarta-feira, 3 de abril de 2013 22.39.47, Rolf Eike Beer wrote: > > Also punish all passwords harder > > that do not contain all types of characters, so a password containing only > > lowercase characters an

Password strengh meter in KNewPasswordDialog

Hi all, the current issue of (German) Linux Magazin has an article comparing some GnuPG frontends. One issue discussed there is the "password strength meter" that gives e.g. 25% strength indication for things like 123456789. I don't know about Kleopatra, but KGpg uses KNewPasswordDialog and it'

Re: Review Request 109549: port KRun away from KProcess

549/#comment21955> Whitespacing around braces is inconsistent. kio/kio/krun.cpp <http://git.reviewboard.kde.org/r/109549/#comment21954> Trailing whitespace - Rolf Eike Beer On March 17, 2013, 4:19 p.m., Martin Tobias Holmedahl San

Re: cxx11-cmake-modules in kdereview

Am Freitag, 1. März 2013, 16:06:38 schrieb Ivan Čukić: > Hi all! > > The CMake modules for detecting C++11 features are going to get in kdereview > soon. The target for the repository is kdesupport. There is a feature request for CMake itself to provide such a module, and I have half of the implem

Re: Review Request 108929: khtml/kjs: Implement typed-arrays

needed. khtml/ecma/kjs_arraybufferview.h <http://git.reviewboard.kde.org/r/108929/#comment20679> size_t - Rolf Eike Beer On Feb. 13, 2013, 8:18 p.m., Bernd Buschinski wrote: > > --- > This is an automatically generated

Re: Login for bug reporting

Kevin Krammer wrote: > Hi folks, > > at FOSDEM I was approached by a person who asked me to relay his > dissatisfaction with the requirement of having a KDE Bugzilla account to > report crashes via the KDE crash handler dialog. > > The issue in his case was kind of made worse by having this obsta

Re: cmake.git (Re: [Kde-pim] Boost vs cmake 2.8.8 vs kdepimlibs master)

Am Montag, 17. Dezember 2012, 23:11:14 schrieb David Faure: > [How many lists do I need to read this thread on? Cutting the cross-posting > off] > > On Monday 17 December 2012 17:46:51 Laszlo Papp wrote: > > PS.: If only the entry barrier was not so high for even a basic tool like > > cmake. It is

Re: Review Request: Do not wait for remaining Dr.Konqi instances without timeout when ending the KDE session

Am , schrieb Jekyll Wu: 于 2012年12月10日 19:27, Rolf Eike Beer 写道: The only downside is some backtrace might be lost. But I don't think that is a big deal. Crashes during shutdown are rare cases nowadays(I hope I'm right), and users noticing those crashes only hours later are the ra

Re: Review Request: Do not wait for remaining Dr.Konqi instances without timeout when ending the KDE session

The only downside is some backtrace might be lost. But I don't think that is a big deal. Crashes during shutdown are rare cases nowadays(I hope I'm right), and users noticing those crashes only hours later are the rare case in rare cases (but very annoying). I regularly get them, most times so

Re: Review Request: parenthesis and not null checking

ions and look if the result is still the same. - Rolf Eike Beer On Nov. 5, 2012, 3:13 p.m., Jaime Torres Amate wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://

Re: CMake 2.8.8 will be required for kdelibs 4.10 starting October 30th

Am Dienstag 30 Oktober 2012, 22:45:18 schrieb Alexander Neundorf: > On Tuesday 30 October 2012, Rolf Eike Beer wrote: > > Am Dienstag 30 Oktober 2012, 20:24:19 schrieb Alexander Neundorf: > > > On Friday 26 October 2012, Alexander Neundorf wrote: > > > > On Thurs

Re: CMake 2.8.8 will be required for kdelibs 4.10 starting October 30th

Am Dienstag 30 Oktober 2012, 20:24:19 schrieb Alexander Neundorf: > On Friday 26 October 2012, Alexander Neundorf wrote: > > On Thursday 18 October 2012, Alexander Neundorf wrote: > > > Hi, > > > > > > in kdelibs we require since more than 2 years cmake .2.6.4, since then > > > many improvements a

Re: Moving libkfacebook to extragear

Am Samstag, 27. Oktober 2012, 11:00:42 schrieb Martin Klapetek: > Hi, > > I'd like to move libkfacebook, the foundation for akonadi-facebook > resource, into extragear. It's been in use for a while, lots of distro ship > it bundled with akonadi-facebook resource, which is now becaming part of > kd

Re: Review Request: Add pkgconfig hints to FindSamba.cmake

1/#comment16105> HINTS - Rolf Eike Beer On Oct. 14, 2012, 11:43 p.m., Rex Dieter wrote: > > --- > This is an automatically generated e-mail. To reply, visit: &g

Re: Requiring cmake 2.8.9 for kdelibs 4.10 ?

Am Samstag 29 September 2012, 12:12:43 schrieb André Wöbbeking: > On Saturday 29 September 2012 11:59:04 Rolf Eike Beer wrote: > > Am Samstag 29 September 2012, 11:48:16 schrieb André Wöbbeking: > > > Hi Alex, > > > > > > On Saturday 29 September 2012 10:36:55

Re: Requiring cmake 2.8.9 for kdelibs 4.10 ?

Am Samstag 29 September 2012, 11:48:16 schrieb André Wöbbeking: > Hi Alex, > > On Saturday 29 September 2012 10:36:55 Alexander Neundorf wrote: > > I know this will cause some effort, because I guess only few distributions > > already come with CMake 2.8.9, but doing this once again after 2 1/2 yea

Re: Requiring cmake 2.8.9 for kdelibs 4.10 ?

Am Samstag 29 September 2012, 10:36:55 schrieb Alexander Neundorf: > Hi, > > since May 2010 kdelibs requires CMake 2.6.4 for building. > > This version is quite old in the meantime, and we are missing on new CMake > features and also run into problems with some cmake modules where we have an > ow

Re: Review Request: In Konqueror's session restore dialog, allow user to chose which sessions to restore

> * If all available sessions are unselected, > presssing "Restore Session" button will behave like "Do not Restore". What about just disabling "Restore Session" then? Eike signature.asc Description: This is a digitally signed message part.

Disconnects not working in KListWidget?

I'm experiencing a strange behavior when testing a KListWidget. I opened KGpg's Key Server configuration dialog, which uses a KListWidget. Then I opened the mouse settings and changed the settings there. There is the following strange behavior: if the new mouse selection behavior is "single cli

Re: Review Request: konqueror: strip new line character from URL on paste automatically

g/r/106184/#comment14232> Please normalize the connect: connect(edit, SIGNAL(textEdited(QString)), this, SLOT(slotTextEdited(QString))); - Rolf Eike Beer On Aug. 25, 2012, 7:40 p.m., Martin Koller wrote: > > ---

Re: Review Request: Remember current desktop when changing activity

Michail Vourlakos wrote: > Rolf Eike Beer wrote: > > Am Samstag, 18. August 2012, 20:19:55 schrieb makism: > >> Yeah i read a bug report about this (new) behavior. It would be fair to > >> support all perceptions of activities (because of their abstract > >> m

Re: Review Request: Remember current desktop when changing activity

Am Samstag, 18. August 2012, 20:19:55 schrieb makism: > Yeah i read a bug report about this (new) behavior. It would be fair to > support all perceptions of activities (because of their abstract meaning). > Ivan mentioned that in @4.10 there will be a KCM for activities, i believe > that we could a

Re: Review Request: Remember current desktop when changing activity

Am Dienstag, 13. März 2012, 18:53:29 schrieb makis marimpis: > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/104261/ > --- > > Revie

Re: Review Request: Fix hang in kcm_useraccount

Am Samstag, 11. August 2012, 01:11:52 schrieb Michael Palimaka: > On 2012-08-11 01:02, Rolf Eike Beer wrote: > > Am Samstag 11 August 2012, 00:11:37 schrieb Michael Palimaka: > >> So you are saying: > >> > >> - readAll clears the buffer > >

Re: Review Request: Fix hang in kcm_useraccount

Am Samstag 11 August 2012, 00:11:37 schrieb Michael Palimaka: > On 2012-08-10 02:46, Rolf Eike Beer wrote: > > Ehm, no. readLine() unconditionally calls readAll(). But that will also > > clear the input buffer of the process object. So there is nothing left to > > read on t

Re: Review Request: Fix hang in kcm_useraccount

Am Donnerstag, 9. August 2012, 20:24:26 schrieb Michael Palimaka: > On 2012-08-09 19:57, Rolf Eike Beer wrote: > > Ehm, no. If you don't unreadLine() but readLine() you will now discard > > the data previously read in by readAll() and only have the new input > > from read

Re: Review Request: Fix hang in kcm_useraccount

Am 2012-08-09 09:41, schrieb Michael Palimaka: On 2012-08-09 17:06, Rolf Eike Beer wrote: Just one thing: you do unreadLine(line), which adds "true" as second argument, so a needless newline is appended that wasn't there before (and which causes a deep copy of all that stuff f

Re: Review Request: Fix hang in kcm_useraccount

Michael Palimaka wrote: > On 2012-08-09 02:59, Rolf Eike Beer wrote: > > Now we have the following situation in case the program has exited (if not > > the behavior is unchanged): > > > > -we read in one line, if it is empty we break. What happens if the first >

Re: Review Request: Fix hang in kcm_useraccount

Am Mittwoch 08 August 2012, 07:59:07 schrieb Michael Palimaka: > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/105895/ > --- > > (U

Re: Review Request: Fix hang in kcm_useraccount

Michael Palimaka wrote: Switching to mail as reviewboard is once again playing tricks at me or my Konqueror. > Changes > --- > > Restore original diff, and add comments explaining it. That comment would explain what you are doing, but the idea was to explain _why_ you are doing it. But s

Re: Review Request: Fix hang in kcm_useraccount

> On Aug. 6, 2012, 4:55 p.m., Rolf Eike Beer wrote: > > kdepasswd/kcm/chfnprocess.cpp, line 68 > > <http://git.reviewboard.kde.org/r/105895/diff/1/?file=76314#file76314line68> > > > > Why unread the line if you read it again just 3 lines below? Why not >

Re: Review Request: Fix hang in kcm_useraccount

org/r/105895/#comment13338> Why unread the line if you read it again just 3 lines below? Why not just put the readline() below in an else clause? - Rolf Eike Beer On Aug. 6, 2012, 1:20 p.m., Michael Palimaka wrote: > > ---

Re: playground/games/picmi moved to KDE Review

Am 25.07.2012 10:50, schrieb Patrick Spendrin: Am 25.07.2012 10:13, schrieb Andras Mantia: I keep telling to Patrick to just use Linux, but he is hard headed, so he has to leave with the pain and fix our mess. ;) :-D If I ever stop working on KDE on Windows I will switch. Looks like we wi

Re: playground/games/picmi moved to KDE Review

Am Samstag 21 Juli 2012, 10:48:47 schrieb Jakob Gruber: > On 07/21/2012 12:02 AM, Raphael Kubo da Costa wrote: > > Jakob Gruber writes: > >> Building with KDE trunk will require the patch from > >> http://lists.kde.org/?l=kde-games-devel&m=134201653803914&w=2. > > > > BTW, the "config.h" part of

Re: Review Request: kjs: Implement Date.toJSON

g/r/105631/#comment12766> toJSON is already present and you add toISOString? Are you sure this is the right diff? - Rolf Eike Beer On July 20, 2012, 6:57 p.m., Bernd Buschinski wrote: > > --- > This is an automatically gener

Re: Review Request: konqueror shall allow to click a mailto: link without showing a (...this URL is untrusted...) confirmation dialog

Am Donnerstag, 12. Juli 2012, 16:15:53 schrieb David Faure: > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/105395/#review15734 > --

Re: Review Request: kjs: Implement JSON.parse

/jsonlexer.cpp <http://git.reviewboard.kde.org/r/105056/#comment11995> If "we" are in parse...? kjs/jsonlexer.cpp <http://git.reviewboard.kde.org/r/105056/#comment11996> Can those 3 just be merged and use "return UChar(cur.uc);"? - Rolf Eike Beer On

Re: Compiler version

Am Donnerstag, 28. Juni 2012, 10:20:42 schrieb Thiago Macieira: > On quinta-feira, 28 de junho de 2012 10.14.03, Ivan Cukic wrote: > > Well, nullptr is a compile time check, right (like explicit override)? So, > > you compile your code with a compiler that supports it, making your code > > safe in

Re: Compiler version

> Hi all, > > I've tested the waters some time ago [1] what would people say if we > started asking for more modern compilers. I've stated there I'll start > the discussion on k-c-d once we branch out 4.9, so I'm doing as > promised. The post was only about kactivities, but the same could be > appl

Re: Review Request: KJS: Implement Object.GetOwnPropertyDescriptor & Object.DefineProperty

> On April 29, 2012, 6:26 p.m., Maks Orlovich wrote: > > kjs/object.cpp, line 433 > > > > > > more * inconsistency > > Bernd Buschinski wrote: > I don't get the problem here, could you please explain? GetterSe

Re: Review Request: kjs: Implement JSON.stringify

/json_object.cpp <http://git.reviewboard.kde.org/r/105057/#comment11211> Duplicate newline - Rolf Eike Beer On May 25, 2012, 8:19 p.m., Bernd Buschinski wrote: > > --- > This is an automatically generated e-mail. To reply

Re: Review Request: kjs: Implement JSON.parse

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105056/#review14177 --- You forgot to change kjs/tests/ecmatest_broken_* - Rolf Eike

Re: KDELibsNightly.cmake

Am Sonntag, 20. Mai 2012, 12:55:54 schrieb Volker Krause: > On Sunday 20 May 2012 10:08:11 Andreas Pakulat wrote: > > Anyway, I guess the guys ultimately knowning how this is done for kdelibs > > are Alex or Volker... > > I'm not using those scripts either. My nightly build just calls ctest > dir

Re: KDELibsNightly.cmake

Am Donnerstag, 17. Mai 2012, 13:30:24 schrieb Andreas Pakulat: > Hi, > > I think this techbase article is pretty much up-to-date. I guess the > KDElibsNighly.cmake file should simply be deleted. > http://techbase.kde.org/Development/CMake/DashboardBuilds This points to quality/nightly-support/KDE

Review Request: KJS: improve regex flag scanning

: http://git.reviewboard.kde.org/r/104974/diff/ Testing --- Run ECMA testsuite. These 2 tests now pass, no other changes. Thanks, Rolf Eike Beer

KDELibsNightly.cmake

I wanted to run a (single) nightly build of kdelibs to see how the coverage changes when the ECMAtest is used. There is a KDELibsNightly.cmake file in the root directory of kdelibs, but that still talks about svn. Changing that may be easy, but the KDECTestNightly.cmake referenced in there that

Review Request: KJS: fix behaviour on allocation errors

behaviour: just return 0. Diffs - kjs/collector.cpp 70e4757 Diff: http://git.reviewboard.kde.org/r/104960/diff/ Testing --- Thanks, Rolf Eike Beer

Re: Review Request: dataprotocol: make charset recoding work

delete that. - Rolf Eike --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104874/#review13603 --- On May 6, 2012, 6:14 p.m., Rolf Eike Beer wrote: > &

  1   2   >