Re: Review Request: Remove redundant SSL certificate hostname mismatch check in KIO::TCPSlaveBase

2012-08-30 Thread Richard J. Moore
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106268/#review18272 --- Ship it! Ship It! - Richard J. Moore On Aug. 29, 2012, 5

Re: Review Request: Fix for potential source of crash in KJavaAppletServer

2011-11-20 Thread Richard J. Moore
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103188/#review8335 --- Ship it! Makes sense to me. - Richard J. Moore On Nov. 19

Re: Review Request: Disallow names of files containing '/' or being equal to "." or "..".

2011-05-30 Thread Richard J. Moore
> On May 28, 2011, 9:29 a.m., David Faure wrote: > > The handling of '/' could use KIO::encodeFileName instead, for consistency. > > I agree about "." and ".." though ;) > > Mark Gaiser wrote: > I wonder.. don't we need a "isFilename" function that checks if a > filename meets all the char