Re: libqaccessibilityclient now in kdereview

2017-07-25 Thread Rex Dieter
Jonathan Riddell wrote: > libqaccessibilityclient is now in kdereview. It's in a git repo > called libkdeaccessibilityclient but we filed a sysadmin request to > rename it. > > We just released 0.2.0 in unstable (for some reason 0.1.1 was released > in stable some years ago). I'd personally str

Re: Review Request 122987: Allow user to specify path to myspell dictionary files

2015-10-19 Thread Rex Dieter
de in in repo already, for example, https://quickgit.kde.org/?p=sonnet.git&a=commit&h=0e6edac621fbd366b126ebd851fbea21355e02d0 - Rex Dieter On April 27, 2015, 1:30 p.m., Eugene Shalygin wrote: > > --- > This is an aut

Re: Review Request 122987: Allow user to specify path to myspell dictionary files

2015-08-05 Thread Rex Dieter
when I noticed this already-open reviewboard submission). Given the polish and feedback already (and lack of any notable objections), let's get it committed asap. - Rex Dieter On April 27, 2015, 1:30 p.m., Eugene Shalygin

Re: Review Request 122987: Allow user to specify path to myspell dictionary files

2015-08-05 Thread Rex Dieter
> On April 7, 2015, 1:44 a.m., Aleix Pol Gonzalez wrote: > > This doesn't let the user change the path but the distributor, that's quite > > a different thing. Maybe it should be a runtime check? Ideally yes, but the approach taken here so far is at least an incremental improvement over the st

Re: Review Request 110328: Add config option to silently create initial password-less wallet

2014-06-11 Thread Rex Dieter
se > > this patch but then they should rename kwallet because it won't be doing > > what it was design to do. > > Rex Dieter wrote: > By that logic, kwallet shouldn't support password-less operation *at > all*, yet it does. (In case its not obvious, I do

Re: Review Request 109675: Make sure that the KDE prefix comes first in XDG_DATA_DIRS

2014-03-13 Thread Rex Dieter
e.org/show_bug.cgi?id=332107 - Rex Dieter On March 25, 2013, 7:14 p.m., Andreas Hartmetz wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard

Re: KDM + ConsoleKit + Logind

2014-02-17 Thread Rex Dieter
Harald Sitter wrote: > Right, but short of patching KDM to gain proper logind support, should > one build with or without CK, build without it. > i.e. does CK add anything useful if the > rest of the system is not using it anyway no. As I understand it, this is the only case where you'd want

Re: Change in application desktop file prefix

2014-02-14 Thread Rex Dieter
Alex Merry wrote: > Given that applications with clashing desktop file names are almost > certainly going to cause clashing binary names anyway, my view is that > the kde4 directory causes more issues than it solves. We may still want > to prefix things like system settings, though (like > kde-sy

Re: Best practice for libraries supporting both Qt4 and Qt5

2013-12-01 Thread Rex Dieter
Allan Sandfeld Jensen wrote: > > On Thursday 28 November 2013, Michael Palimaka wrote: >> >> Any thoughts? >> > In an ideal world we would convince the distros to enable Qt namespace on > Qt5, so that Qt4 and Qt5 symbols does not clash, and does not cause > crashes when loaded as plugins etc.

Re: Adopting AppData in KDE?

2013-11-03 Thread Rex Dieter
Rex Dieter wrote: > Matthias Klumpp wrote: > >> The current >> AppStream library uses GObject/GLib, which can be used without >> problems from any Qt app > > this one? https://gitorious.org/appstream/ > > Are there any formal releases/tarballs? (I'm

Re: Adopting AppData in KDE?

2013-11-03 Thread Rex Dieter
Matthias Klumpp wrote: > The current > AppStream library uses GObject/GLib, which can be used without > problems from any Qt app this one? https://gitorious.org/appstream/ Are there any formal releases/tarballs? (I'm having trouble finding any) It appears apper needs this to enable appstream

Re: Dependency to unreleased versions

2013-10-22 Thread Rex Dieter
Alexander Neundorf wrote: > On Sunday 20 October 2013, Torgny Nyblom wrote: >> Hi, >> >> What is the policy of depending on unreleased libraries? And is that >> written down somewhere? ... > IMO it's a pain to depend on unreleased versions of anything. As this seems to be semi-regular occurrence

Re: Review Request 110875: kcm_useraccount: support accountsservice

2013-06-11 Thread Rex Dieter
> On June 11, 2013, 4:12 p.m., Rex Dieter wrote: > > Note too: this patch adds 2 new build dependencies, dbus-devel (aka dbus > > pkgconfig file: dbus-1.pc) and accountsservice itself (owner of the xml > > interface files) and, unfortunately, qdbusxml2cpp doesn'

Re: Review Request 110875: kcm_useraccount: support accountsservice

2013-06-11 Thread Rex Dieter
(aka dbus pkgconfig file: dbus-1.pc) and accountsservice itself (owner of the xml interface files) - Rex Dieter On June 10, 2013, 4:58 p.m., Greg T wrote: > > --- > This is an automatically generated e-mail. To reply, visi

Re: Review Request 110328: Add config option to silently create initial password-less wallet

2013-05-25 Thread Rex Dieter
> On May 25, 2013, 5:25 p.m., Àlex Fiestas wrote: > > I'm 100% against this patch, it is a no go. > > > > What we have to provide is a way for distributions to open the wallet in a > > SECURE way without asking the user for a password. Distros are free to use > > this patch but then they shoul

Re: Review Request 106861: Add pkgconfig hints to FindSamba.cmake

2013-01-31 Thread Rex Dieter
61/#review26461 --- On Jan. 31, 2013, 4:58 p.m., Rex Dieter wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.r

Re: Review Request 106861: Add pkgconfig hints to FindSamba.cmake

2013-01-31 Thread Rex Dieter
against samba-4.0-rc2 Thanks, Rex Dieter

Re: Review Request: Add pkgconfig hints to FindSamba.cmake

2012-10-21 Thread Rex Dieter
tp://git.reviewboard.kde.org/r/106861/#review20611 ----------- On Oct. 15, 2012, 12:24 p.m., Rex Dieter wrote: > > --- > This is an automatically generated e-mail.

Re: Review Request: Add pkgconfig hints to FindSamba.cmake

2012-10-15 Thread Rex Dieter
://git.reviewboard.kde.org/r/106861/diff/ Testing --- Tested on fedora 18 against samba-4.0-rc2 Thanks, Rex Dieter

Re: Review Request: Add pkgconfig hints to FindSamba.cmake

2012-10-15 Thread Rex Dieter
-- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106861/#review20357 ------- On Oct. 14, 2012, 11:43 p.m., Rex Dieter wrote: > > -

Review Request: Add pkgconfig hints to FindSamba.cmake

2012-10-14 Thread Rex Dieter
FindSamba.cmake, helps find samba4 libs on non-standard-ish locations. Diffs - cmake/modules/FindSamba.cmake 16522c6 Diff: http://git.reviewboard.kde.org/r/106861/diff/ Testing --- Tested on fedora 18 against samba-4.0-rc2 Thanks, Rex Dieter

Re: phonon javascript

2012-02-10 Thread Rex Dieter
Harald Sitter wrote: > On Thu, Feb 9, 2012 at 4:39 AM, Shaun Reich > wrote: >> anyone know how can i access phonon through javascript? > > javascript? qtscript you mean? > > I think you will need http://code.google.com/p/qtscriptgenerator/ for that If that's the only option, don't get your hop

Re: Review Request: Don't set an RPATH when installed into multiarch dir

2012-02-08 Thread Rex Dieter
t; 2.8.5 (with this commit cerry-picked: > http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=317d077f) and 2.8.6. Same > output on both. > What should it look like? > > Rex Dieter wrote: > For what it's worth, on my fedora 16 x86_64 box: > CMAKE_PLATFO

Re: Review Request: Don't set an RPATH when installed into multiarch dir

2012-02-08 Thread Rex Dieter
> On Dec. 16, 2011, 4:40 p.m., Alexander Neundorf wrote: > > Actually this looks more like a cmake bug, the contents of > > CMAKE_PLATFORM_IMPLICIT_LINK_DIRECTORIES seem to be quite wrong. > > What version of cmake are you using ? > > > > Felix Geyer wrote: > 2.8.5 (with this commit cerry-p

Re: Request: remove libkactivites from kdelibs (in experimental/)

2011-11-07 Thread Rex Dieter
On 11/04/2011 05:05 PM, Aaron J. Seigo wrote: we currently have libkactivities in kdelibs/experimental. due to upcoming changs and frameworks 5 development, it has been moved into its own git repository: kactivities. i would like to request approval to remove it from kdelibs/experimental and mak

Re: Qt 4.8 QUrl.toLocalFile behavior change, impacts to KUrl (and friends)

2011-10-28 Thread Rex Dieter
Milian Wolff wrote: > Could someone maybe explain a few points on this issue for me? > > 1) When does it manifest? Apparently when using QUrl("...") directly, if > I'm not mistaken. But what if we use KUrl? KUrl uses QUrl behind the scenes for several cases. -- rex

Re: Qt 4.8 QUrl.toLocalFile behavior change, impacts to KUrl (and friends)

2011-10-27 Thread Rex Dieter
Thiago Macieira wrote: > On Thursday, 27 de October de 2011 13:32:51 Rex Dieter wrote: >> See also, >> http://bugs.kde.org/285028 >> ( and https://bugreports.qt.nokia.com/browse/QTBUG-22382 ) >> >> In Qt 4.8, QUrl.toLocalFile now seems, by design, to return NU

Qt 4.8 QUrl.toLocalFile behavior change, impacts to KUrl (and friends)

2011-10-27 Thread Rex Dieter
See also, http://bugs.kde.org/285028 ( and https://bugreports.qt.nokia.com/browse/QTBUG-22382 ) In Qt 4.8, QUrl.toLocalFile now seems, by design, to return NULL for urls lacking any scheme. Discovered this the hard way figuring out why all my audio knotifications were quiet. Since audio event

Re: Review Request: KActivities requires Soprano 2.7 to compile

2011-10-17 Thread Rex Dieter
> On Oct. 17, 2011, 3:16 p.m., Rex Dieter wrote: > > Wouldn't it make more sense to up the minimum kdelibs requirement to 4.7 > > (which already depends on the newer soprano?) nevermind, kdelibs' CMakeLists.txt only has set(SOPRANO_MIN_VERSION "2.5.60") curr

Re: Review Request: KActivities requires Soprano 2.7 to compile

2011-10-17 Thread Rex Dieter
elibs requirement to 4.7 (which already depends on the newer soprano?) - Rex Dieter On Oct. 16, 2011, 10:29 a.m., Ralf Jung wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard

Re: Review Request: Fix docs generation with docbook-xslt >= 1.76

2011-06-29 Thread Rex Dieter
org/r/101791/ > --- > > (Updated June 27, 2011, 11:16 p.m.) > > > Review request for kdelibs, Burkhard Lück, Rex Dieter, and Albert Astals Cid. > > > Summary > --- > > Previously, local.l10n.xml was defined to use a bu

Re: Dependencies Policy?

2011-03-18 Thread Rex Dieter
John Layt wrote: > I was wondering if we need to define a "New Dependencies" policy, or at > least some guidelines to remind people what to think about when choosing > or creating new dependencies? I would welcome a formal policy. here's some references I found to related existing documents and

Re: Review Request: Adjust the kde "fake" mimetype fonts/package so desktop-file-utils/shared-mime-info do not complain

2010-12-20 Thread Rex Dieter
rg/r/6111/#review9347 --- On 2010-12-20 21:52:20, Rex Dieter wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://svn.revie

Re: Review Request: Adjust the kde "fake" mimetype fonts/package so desktop-file-utils/shared-mime-info do not complain

2010-12-20 Thread Rex Dieter
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/6111/ --- (Updated 2010-12-20 21:52:20.637316) Review request for kdelibs. Changes -

Re: Review Request: Adjust the kde "fake" mimetype fonts/package so desktop-file-utils/shared-mime-info do not complain

2010-12-14 Thread Rex Dieter
e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/6111/#review9248 ------- On 2010-12-13 17:07:48, Rex Dieter wrote: > > --- > This is an autom

Re: Review Request: Adjust the kde "fake" mimetype fonts/package so desktop-file-utils/shared-mime-info do not complain

2010-12-13 Thread Rex Dieter
> On 2010-12-13 16:48:31, Ingo Klöcker wrote: > > How about using vnd.kde.fontspackage instead of x-kde-fontspackage? > > Rex Dieter wrote: > I only used x-kde-fontspackage at aaron's suggestion in one of the > aforementioned bugs, I'm not attached to it

Re: Review Request: Adjust the kde "fake" mimetype fonts/package so desktop-file-utils/shared-mime-info do not complain

2010-12-13 Thread Rex Dieter
th me too. - Rex --- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/6111/#review9232 --- On 2010-12-13 17:07:4

Re: Review Request: Adjust the kde "fake" mimetype fonts/package so desktop-file-utils/shared-mime-info do not complain

2010-12-13 Thread Rex Dieter
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/6111/ --- (Updated 2010-12-13 17:07:48.354415) Review request for kdelibs. Changes -

Review Request: Adjust the kde "fake" mimetype fonts/package so desktop-file-utils/shared-mime-info do not complain

2010-12-13 Thread Rex Dieter
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/6111/ --- Review request for kdelibs. Summary --- This patch adjusts the kde "fak