Re: Review Request 126413: FindPyKDE4: Make PYKDE4_INSTALL_PYTHON_FILES use PYTHON_INSTALL.

2015-12-18 Thread Raphael Kubo da Costa
marked as submitted. Review request for Build System, kdelibs, Alex Merry, and Luca Beltrame. Changes --- Submitted with commit 016841aeb0b180981122085e9b1d49ae66951670 by Raphael Kubo da Costa to branch KDE/4.14. Repository: kdelibs Description --- Review Request 126345

Review Request 126413: FindPyKDE4: Make PYKDE4_INSTALL_PYTHON_FILES use PYTHON_INSTALL.

2015-12-18 Thread Raphael Kubo da Costa
honCompile.py`, so all callers should work now. Thanks, Raphael Kubo da Costa

Re: Review Request 126345: PythonMacros: specify destination directory in byte-compiled files

2015-12-16 Thread Raphael Kubo da Costa
marked as submitted. Review request for Build System, kdelibs and Alex Merry. Changes --- Submitted with commit 94f1d2fa9582a2942d5154b85c849cc3c6140e31 by Raphael Kubo da Costa to branch KDE/4.14. Repository: kdelibs Description --- The `PYTHON_INSTALL()` macro is a wrapper around

Re: Review Request 126345: PythonMacros: specify destination directory in byte-compiled files

2015-12-14 Thread Raphael Kubo da Costa
> On Dec. 14, 2015, 8:24 p.m., Alex Merry wrote: > > Seems sensible to me. Are there any potential Python2 vs Python3 issues? > > Raphael Kubo da Costa wrote: > I don't think there are any -- the `.pyc/.pyo` files are installed with a > different name into a di

Re: Review Request 126345: PythonMacros: specify destination directory in byte-compiled files

2015-12-14 Thread Raphael Kubo da Costa
org/r/126345/#review89485 --- On Dec. 14, 2015, 6:48 p.m., Raphael Kubo da Costa wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > htt

Review Request 126345: PythonMacros: specify destination directory in byte-compiled files

2015-12-14 Thread Raphael Kubo da Costa
ro in pykde4, FreeBSD and openSUSE contain wrong paths in its .pyc files. With this patch, I was able to verify with `hexdump` that the right path is present in the .pyc files installed by pykde4. Thanks, Raphael Kubo da Costa

Re: Review Request 125236: FindQt4: Use CHECK_CXX_SYMBOL_EXISTS instead of CHECK_C_SYMBOL_EXISTS.

2015-11-29 Thread Raphael Kubo da Costa
- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125236/#review85550 ----------- On Sept. 15, 2015, 11:59 a.m., Raphael Kubo da Costa wrote: > > -

Re: Review Request 125236: FindQt4: Use CHECK_CXX_SYMBOL_EXISTS instead of CHECK_C_SYMBOL_EXISTS.

2015-11-29 Thread Raphael Kubo da Costa
of a C one. Diffs - cmake/modules/FindQt4.cmake e439a72f82c51758830b057b368407e11a6a541e Diff: https://git.reviewboard.kde.org/r/125236/diff/ Testing --- Adding something C++-specific to qglobal.h (e.g. `#include `) works and the right flags are still detected. Thanks, Raphael Kubo da Costa

Review Request 125236: FindQt4: Use CHECK_CXX_SYMBOL_EXISTS instead of CHECK_C_SYMBOL_EXISTS.

2015-09-15 Thread Raphael Kubo da Costa
e11a6a541e Diff: https://git.reviewboard.kde.org/r/125236/diff/ Testing --- Adding something C++-specific to qglobal.h (e.g. `#include `) works and the right flags are still detected. Thanks, Raphael Kubo da Costa

Re: Review Request 120900: kio_sftp: Use the right type for timeout_sec and timeout_usec.

2014-10-30 Thread Raphael Kubo da Costa
set()` and make the ioslave always say that it failed to set the timeout value. With this change, everything works as expected. Thanks, Raphael Kubo da Costa

Review Request 120900: kio_sftp: Use the right type for timeout_sec and timeout_usec.

2014-10-29 Thread Raphael Kubo da Costa
nge, everything works as expected. Thanks, Raphael Kubo da Costa

Re: Review Request 119454: Make FindPyKDE4 work with PyQt's new build system.

2014-07-29 Thread Raphael Kubo da Costa
Testing --- Modules such as Kate's Pate plugin detects and builds fine without pyqtconfig and pykdeconfig on the system. Thanks, Raphael Kubo da Costa

Re: Review Request 119025: Actually pass IBUS_DEFINITIONS when compiling ibus-panel

2014-07-28 Thread Raphael Kubo da Costa
On July 19, 2014, 12:17 a.m., Vadim Zhukov wrote: > > (As a general note, for build system related stuff like this you can also > > try including the "buildsystem" group, which can be more responsive at > > times) > > > > > The ibus-panel can't build on OpenBSD because some required definition

Review Request 119454: Make FindPyKDE4 work with PyQt's new build system.

2014-07-24 Thread Raphael Kubo da Costa
pyqtconfig and pykdeconfig on the system. Thanks, Raphael Kubo da Costa

Re: Review Request 119025: Actually pass IBUS_DEFINITIONS when compiling ibus-panel

2014-07-18 Thread Raphael Kubo da Costa
ved in cache, and thus isn't available at > compile time This doesn't make much sense; all values found at configuration time in CMake are then used to generate your make/ninja/whatever files, regardless of whether they are cached or not. - Raphael Kubo da Cost

Re: Review Request 119302: Make FindPyQt4 work with PyQt's new build system.

2014-07-16 Thread Raphael Kubo da Costa
and on a Debian system with `pyqtconfig.py` worked as before. Thanks, Raphael Kubo da Costa

Re: Review Request 119302: Make FindPyQt4 work with PyQt's new build system.

2014-07-16 Thread Raphael Kubo da Costa
roken with this change -- it also assumes `pyqtconfig.py` exists. Fixing it is probably going to be more difficult. - Raphael Kubo da Costa On July 16, 2014, 4:21 p.m., Raphael Kubo da Costa wrote: > > --- > This is an automatical

Re: Review Request 119302: Make FindPyQt4 work with PyQt's new build system.

2014-07-16 Thread Raphael Kubo da Costa
t) > > else: > > pyqt_sip_dir = None > > > > print(pyqt_sip_dir) > > # prints /usr/share/sip/PyQt4 > > > > We should use something similar. > > Scott Kitterman wrote: > So markdown and python code comments don't mix. The bolded th

Re: Review Request 119302: Make FindPyQt4 work with PyQt's new build system.

2014-07-16 Thread Raphael Kubo da Costa
ing `FindPyQt.py` by hand on a Debian system with `pyqtconfig.py` worked as before. Thanks, Raphael Kubo da Costa

Re: Review Request 119302: Make FindPyQt4 work with PyQt's new build system.

2014-07-16 Thread Raphael Kubo da Costa
default values (`sys.prefix/sip` on Windows, `sys.prefix/share/sip` elsewhere), which in the worst case can be a different installation unrelated to the one used by the PyQt version we're using. I didn't see much value in just working out of the box in some specific cases. - Rap

Review Request 119302: Make FindPyQt4 work with PyQt's new build system.

2014-07-15 Thread Raphael Kubo da Costa
I was able to make Kate find PyQt by passing `-DPYQT4_SIP_DIR=<...>` with my PyQt installation without `pyqtconfig.py`, and calling `FindPyQt.py` by hand on a Debian system with `pyqtconfig.py` worked as before. Thanks, Raphael Kubo da Costa

Re: FindKDE4Internal.cmake & clang & c++11 & -fdelayed-template-parsing

2013-11-18 Thread Raphael Kubo da Costa
Milian Wolff writes: >> > Also, have you reported the errors that clang outputs to the developers? >> > If >> > it's correct analysis, it should be fixed - even if it's error-prone >> > work. >> >> In this case, I don't think there's a bug: I haven't investigated in >> depth, but clang seems to b

Re: FindKDE4Internal.cmake & clang & c++11 & -fdelayed-template-parsing

2013-11-17 Thread Raphael Kubo da Costa
Milian Wolff writes: > There is no alternative, see above. Rather have bigger binaries than not being > able to compile at all. Finally fixed: http://commits.kde.org/kdelibs/daa54a25 > Also, have you reported the errors that clang outputs to the developers? If > it's correct analysis, it should

Re: FindKDE4Internal.cmake & clang & c++11 & -fdelayed-template-parsing

2013-10-22 Thread Raphael Kubo da Costa
Milian Wolff writes: > Hey Raphael! > > Thank you for working on clang support in FindKDE4Internal.cmake. > > Since recently though I have build issues with clang due to the -fdelayed- > template-parsing flag passed in FindKDE4Internal.cmake. A simple example such > as this: > > #include > int m

Re: Backporting Clang support to KDE 4.11 FindKDE4Internal.cmake

2013-08-17 Thread Raphael Kubo da Costa
Milian Wolff writes: > Btw, is there still no BSD using clang by default to build KDE? How > did they manage to get this to work without the patch? FreeBSD's the first BSD to move towards having clang as the official compiler in future releases. We've been patching FindKDE4Internal.cmake locally

Re: Review Request 110090: Clean up kickoff from stale bits

2013-08-17 Thread Raphael Kubo da Costa
> On May 8, 2013, 5:57 p.m., Raphael Kubo da Costa wrote: > > Thanks for the cleanup. You might also want to remove the references to > > Strigi in DESIGN-GOALS and STATUS-TODO, but I guess they're very outdated > > anyway. Please include a descriptive commit me

Re: Review Request 110090: Clean up kickoff from stale bits

2013-05-08 Thread Raphael Kubo da Costa
remove the references to Strigi in DESIGN-GOALS and STATUS-TODO, but I guess they're very outdated anyway. Please include a descriptive commit message explaining that this patch also fixes build problems for people without Strigi. - Raphael Kubo da Costa On April 20, 2013, 1:13 a.m., Max Brazh

Re: Review Request: Add pkgconfig hints to FindSamba.cmake

2012-10-24 Thread Raphael Kubo da Costa
Alexander Neundorf writes: > On Monday 22 October 2012, Rex Dieter wrote: >> > On Oct. 21, 2012, 9:27 a.m., Raphael Kubo da Costa wrote: >> > > cmake/modules/FindSamba.cmake, line 23 >> > > <http://git.reviewboard.kde.org/r/106861/dif

Re: Review Request: Add pkgconfig hints to FindSamba.cmake

2012-10-21 Thread Raphael Kubo da Costa
org/r/106861/#comment16254> Please note that support for the QUIET keyword was added in CMake 2.8.2 -- it is probably OK for the 4.10 branch once we start depending on CMake 2.8.8, but not for the other ones. - Raphael Kubo da Costa On Oct. 15, 2012, 12:24 p.m., Rex Dieter

Re: Review Request: Fix hang in kcm_useraccount

2012-08-06 Thread Raphael Kubo da Costa
/104439 ? - Raphael Kubo da Costa On Aug. 6, 2012, 5:03 p.m., Michael Palimaka wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.

Re: Review Request: Add CamelCase wrapper for kcodecaction.h

2012-08-02 Thread Raphael Kubo da Costa
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105818/#review16789 --- Ship it! Ship It! - Raphael Kubo da Costa On Aug. 1, 2012

Re: Review Request: properly pass the NOGUI flag

2012-07-29 Thread Raphael Kubo da Costa
;who uses NOGUI", http://lxr.kde.org/search?filestring=&string=kde4_add_unit_test+NOGUI - Raphael Kubo da Costa On July 29, 2012, 11:14 p.m., Aleix Pol Gonzalez wrote: > > --- > This is an automatically generate

Re: playground/games/picmi moved to KDE Review

2012-07-21 Thread Raphael Kubo da Costa
Jakob Gruber writes: > I've replaced all std::shared_pointers with QSharedPointers this morning > and removed the -std=c++11 flag. I'm now getting a few errors and warnings when trying to build picmi with g++ 4.2.1, 4.6.3 and clang 3.1: some of them are related to -pedantic being used + Qt and k

Re: playground/games/picmi moved to KDE Review

2012-07-20 Thread Raphael Kubo da Costa
Jakob Gruber writes: > Building with KDE trunk will require the patch from > http://lists.kde.org/?l=kde-games-devel&m=134201653803914&w=2. BTW, the "config.h" part of the patch should go in regardless of the rest, as config.h should be the first header included by the source files anyway. I've

Re: Compiler version

2012-06-28 Thread Raphael Kubo da Costa
Martin Gräßlin writes: > What about freebsd? Personally I am not willing to support that platform > anymore if it would mean that we have to restrict ourself to an outdated gcc > version. Reasons why in general I would find it acceptable to drop support for > non-linux in KWin are outlined in a r

Re: Compiler version

2012-06-27 Thread Raphael Kubo da Costa
Ivan Čukić writes: > Now, my proposal here is to update the required versions for > Frameworks 4 to reflect those of KDE Frameworks 5 / Qt 5. Now, I've > found different information for this - skelly says [2] the requirement > is GCC 4.6 while some other places state it is GCC 4.5, so I'm not > s

Re: Review Request: Added fallback for real username in kcm module to use KUser::FullName

2012-06-27 Thread Raphael Kubo da Costa
> On June 27, 2012, 4:50 p.m., Raphael Kubo da Costa wrote: > > Makes sense, please commit to master. > > Aleksey Yermakov wrote: > I'm afraid, I don't have write rights. Could you please point me to some > documentation which will help me commit this patch

Re: Review Request: Added fallback for real username in kcm module to use KUser::FullName

2012-06-27 Thread Raphael Kubo da Costa
Kubo da Costa On June 27, 2012, 4:29 p.m., Aleksey Yermakov wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.

Re: Review Request: Added fallback for real username in kcm module to use KUser::FullName

2012-06-26 Thread Raphael Kubo da Costa
statements): if (foo) { bar(); } - Raphael Kubo da Costa On May 16, 2012, 7:09 a.m., Aleksey Yermakov wrote: > > --- > This is an automatically generated e-mail. To reply, visit: >

Re: Review request: moving libkgoogle to extragear

2012-05-26 Thread Raphael Kubo da Costa
Dan Vratil writes: > Hi, > > LibKGoogle is a new optional dependency of kdepim-runtime. It's used by the > new Akonadi Google resources. > > It's now in kdereview [0] and I'd like to move it to extragear, so I'm asking > for a review on the library. One thing I have noticed is that libkgoogle se

Re: Moving libsolid-hal to unmaintained?

2012-04-23 Thread Raphael Kubo da Costa
Alex Fiestas writes: > On Monday, April 23, 2012 11:18:14 AM todd rme wrote: >> Is there a way to have it so HAL is enabled by default on BSD systems, >> but on Linux systems you need to manually use a cmake flag to enable >> it? > Well I don't see why we need HAL on Linux, so unless you can give

Re: Moving libsolid-hal to unmaintained?

2012-04-21 Thread Raphael Kubo da Costa
Alex Fiestas writes: > So real question is, who is using libsolid-hal nowdays? At least the BSD people are; nobody came up with a BSD implementation of the *kit/u* stuff from Linux, so we're still using Hal. > Once we know the answer to that question I will: > -Make HAL backend option only avai

Re: Pairs going to KDE Edu

2012-04-16 Thread Raphael Kubo da Costa
Aleix Pol writes: > Hi, > Last friday Pairs [1] was moved from playground/edu to kdereview > because we want it to be moved to kdeedu. We have been working on it > for a while already and we would like it to move to kde edu and to be > included in the next KDE release. > > If someone is intereste

Re: Review Request: kdepasswd KCM: fixed freeze when changing user name

2012-03-31 Thread Raphael Kubo da Costa
output is/was being parsed? kdepasswd/kcm/chfnprocess.cpp <http://git.reviewboard.kde.org/r/104439/#comment9517> Unrelated. kdepasswd/kcm/chfnprocess.cpp <http://git.reviewboard.kde.org/r/104439/#comment9518> You're missing a closing ')' here. - Raphael

Re: Review Request: Port shutdown dialog to QML

2012-01-30 Thread Raphael Kubo da Costa
ksmserver/FindKDeclarative.cmake <http://git.reviewboard.kde.org/r/103621/#comment8434> Can you elaborate on why KDECLARATIVE_LIBRARY is being used/set? - Raphael Kubo da Costa On Jan. 30, 2012, 4:35 p.m., Lamarque Vieira Souza wrote: > > -

Re: Review Request: Port shutdown dialog to QML

2012-01-30 Thread Raphael Kubo da Costa
d.kde.org/r/103621/#comment8423> I don't see these being used anywhere in the patch, does it make sense to keep deprecated declarations in a new file? ksmserver/FindKDeclarative.cmake <http://git.reviewboard.kde.org/r/103621/#comment8425> Missing KDECLARATIVE_LIBRARIES?

Re: Review Request: Report file errors when extracting files using karchive

2012-01-28 Thread Raphael Kubo da Costa
-1) { d->fileError = f.error(); break; } } - Raphael Kubo da Costa On Jan. 28, 2012, 4:46 p.m., Theofilos Intzoglou wrote: > > --- > This is an automatically generated e-mail. To reply,

Re: a confusion beetwen cmake/ccmake and FindKDE4Internal.cmake

2011-10-08 Thread Raphael Kubo da Costa
Guy Maurel writes: > The tool ccmake is showing something erroness: The values of > CMAKE_C_FLAGS and CMAKE_CXX_FLAGS are shown with -g > One may change these values to another value. > BUT the file FindKDE4Internal.cmake is stronger. > The generated files flags.make contains the values from the

Re: Review Request: Change konqueror tabs look and feel

2011-09-04 Thread Raphael Kubo da Costa
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102519/#review6256 --- Would it fix any bug report/wishlist item? - Raphael On Sept.

kdeutils has migrated to git

2011-08-20 Thread Raphael Kubo da Costa
Hello there, kdeutils has (mostly) finished its migration to git. SVN now only holds MOVED_TO_GIT files which point to the git repositories. Each application (ark, filelight, kcalc, kcharselect, kfloppy, kgpg, kremotecontrol, ktimer, kwallet, printer-applet, superkaramba, sweeper) has its own git

Re: buildsystem BoF at Desktop Summit

2011-08-07 Thread Raphael Kubo da Costa
Alexander Neundorf writes: > On Tuesday 02 August 2011, Alexander Neundorf wrote: >> On Friday 29 July 2011, Alexander Neundorf wrote: >> > Hi, > ... >> > I have set up a doodle poll here: >> > http://www.doodle.com/v53bgft9xkffdnft >> > >> > Please enter when you can attend (the earlier the bett

Re: buildsystem BoF at Desktop Summit

2011-08-07 Thread Raphael Kubo da Costa
Raphael Kubo da Costa writes: > So either you'll just be there at 8:00PM, or we walk there together. Then > let's meet here at the registration at &.30PM. Addendum: &.30PM = 6.30PM.

Re: buildsystem BoF at Desktop Summit

2011-08-07 Thread Raphael Kubo da Costa
Sending it only to the lists so it isn't held for approval. --- Begin Message --- Alexander Neundorf writes: > On Tuesday 02 August 2011, Alexander Neundorf wrote: >> On Friday 29 July 2011, Alexander Neundorf wrote: >> > Hi, > ... >> > I have set up a doodle poll here: >> > http://www.doodle.co

Re: Review Request: Only include nepomuk directories if nepomuk is available

2011-07-16 Thread Raphael Kubo da Costa
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101949/#review4751 --- Ship it! Looks OK to me. - Raphael On July 14, 2011, 2:40 p.

Re: Review Request: add default help menu with all standard help actions to Help button in KFind

2011-06-13 Thread Raphael Kubo da Costa
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101443/#review3869 --- Ship it! Looks OK. Perhaps KFind should actually have a main wi

Re: Review Request: kcm-grub2

2011-06-04 Thread Raphael Kubo da Costa
Konstantinos Smanis writes: > I have talked with Alberto Mattea (the maintainer of kcmgrub2) and he > has agreed to give up his request for inclusion in extragear. > > Our conversation has been over plain e-mails, so I cannot prove this. > Perhaps I should contact him to confirm this? That sound

Re: Review Request: Update KActionCollection member documentation

2011-06-02 Thread Raphael Kubo da Costa
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101494/#review3646 --- Ship it! Looks OK, the new apidox even looks similar to its cou

Re: Review Request: kcm-grub2

2011-06-02 Thread Raphael Kubo da Costa
Konstantinos Smanis writes: > On Thu, May 26, 2011 at 00:03, Konstantinos Smanis > wrote: >>> The following line should probably be simplified (see >>> http://websvn.kde.org/?revision=1184860&view=revision): >>> >>> src/kcm_grub2.cpp:113:                    QTreeWidgetItem *item = new >>> QTreeW

Re: KDE/kdeadmin/system-config-printer-kde

2011-05-13 Thread Raphael Kubo da Costa
Ozan Çağlayan writes: > 23-02-2011 17:09 tarihinde, Jonathan Riddell yazdı: >> SVN commit 1222403 by jriddell: >> >> Add samba browsing >> https://bugs.launchpad.net/ubuntu/+source/kdeadmin/+bug/295065 >> BUG:259283 >> >> >> M +1 -0 CMakeLists.txt >> A pysmb.py >> M +363

Re: svn -> git transition status ?

2011-05-08 Thread Raphael Kubo da Costa
Alexander Neundorf writes: > what's the current status with our svn to git transition ? > There are still several modules in svn (kdeaccessibility, kdeadmin, > kdeartwork, kdebindings, kdegames, kdegraphics, kdemultimedia, kdenetwork, > kdesdk, kdetoys, kdeutils, kdewebdev). kdeutils: The conv

Re: Kcmgrub2

2011-04-22 Thread Raphael Kubo da Costa
Alberto Mattea writes: > Hi, kcmgrub2 has been under review for two weeks now. I've done all the > suggested changes. > Would it be possible to move it to kdemain/sysadmin or (if that's not > possible) to extragear/sysadmin? By the way, is there any relationship between kcmgrub2 and kcm-grub2?

Review Request: Fix directory navigation in Dolphin::Terminal.

2011-04-11 Thread Raphael Kubo da Costa
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101096/ --- Review request for KDE Base Apps. Summary --- Fix directory navigatio

Re: git and commitfilter ?

2011-04-10 Thread Raphael Kubo da Costa
Alexander Neundorf writes: > is commitfilter (http://commitfilter.kde.org) actually working with git ? > Just today I figured that there is such silence wrt. to commit emails for > kdelibs/cmake/modules/ because probably commitfilter is not working with > git ? IIRC the filters are supposed to

Re: Review request: Kcmgrub2

2011-04-06 Thread Raphael Kubo da Costa
Alberto Mattea writes: > In data mercoledì 6 aprile 2011 00:28:21, Raphael Kubo da Costa ha scritto: >> Buildsystem-wise: >> >> * I did not understand why you used include() instead of >> find_package() in, for example, >> >> include(FindPyQt4) &g

Re: Review request: Kcmgrub2

2011-04-05 Thread Raphael Kubo da Costa
Alberto Mattea writes: > Hi all, > after 4 releases I think kcmgrub2 has reached an acceptable level of maturity, > so I'd ask for a move to kdereview. It is currently in playground-sysadmin > (git). I only took a quick look, as my Py{Qt,KDE}-fu is not that good. Buildsystem-wise: * I did no

Re: Top 15 Mailinglists with messages in moderation

2011-03-01 Thread Raphael Kubo da Costa
Tom Albers writes: > 34 kfm-devel I could help with this one.

Re: prison - a barcode library now in kdereview

2011-02-16 Thread Raphael Kubo da Costa
Hey there, Sune Vuorela writes: > Hi peoples > > I have added prison (git clone kde:prison) to kdereview, targetting > kdesupport. > > Please review. As said on IRC, the cmake/modules directory is missing the copyright file, and the FindFoo.cmake modules could be simplified with FindPackageHand

Re: git workflow draft

2011-02-16 Thread Raphael Kubo da Costa
On Wednesday 16 February 2011 10:58:48 John Layt wrote: > # ===[ Subject ]===| > # ---[ One line only, short meaningful description to show in logs ]---| Personally, I find that starting this short description with the "module", "library" or wha

Re: Review Request: Workaround for the hang (freeze) when opening VLC's file dialog under KDE...

2011-02-03 Thread Raphael Kubo da Costa
"Pino Toscano" writes: > kdecore/services/kmimetyperepository.cpp > > > I guess you should also add the /usr/local equivalent, and enclose both > in a > #ifdef Q_OS_UNIX > ... > #endif > block By the way, how welcome wou

Re: KDE library compile error (on the ARM CORTEX-A8)

2011-01-19 Thread Raphael Kubo da Costa
On Wed, Jan 19, 2011 at 6:57 PM, Thiago Macieira wrote: > On Wednesday, 19 de January de 2011 15:32:41 Thiago Macieira wrote: >> On Wednesday, 19 de January de 2011 09:21:29 Александр > Куземко wrote: >> > localhost temp # scanelf -qT /usr/lib/libkhtml.so.5.6.0 >> > scanelf: scanelf_file_textrels(

Re: RESOLVED vs CLOSED

2011-01-15 Thread Raphael Kubo da Costa
On Sat, Jan 15, 2011 at 3:15 PM, Hugo Pereira Da Costa wrote: > Hello all, > sorry for this newbye question. > I was pointed out that RESOLVED bugs on bugs.kde.org can be further tagged as > CLOSED. ... which I did not know. > > Right now, there are 432 bug reports related to oxygen which are RESO

Re: Suspending mailinglists due to lack of moderators.

2011-01-01 Thread Raphael Kubo da Costa
At Sat, 1 Jan 2011 21:25:23 + (UTC), Tom Albers wrote: > 40 kdelibs-bugs > 28 plasma-bugs Aren't these the default assignees for most kdelibs and plasma bugs? Would they then be assigned to unassigned-b...@?

Re: About remove nfs filesharing support

2010-12-28 Thread Raphael Kubo da Costa
On Tuesday 28 December 2010 12:56:01 Rodrigo Belém wrote: > On Tue, Dec 28, 2010 at 10:12 AM, Alex Fiestas wrote: > > On 12/28/2010 03:06 PM, Rodrigo Belém wrote: > >> Hello everybody, > >> > >> I've been working on kubuntu team to update the samba file sharing > >> code and code is already in tr

Re: Review Request: Adding "net usershare" suport for KSambaShare

2010-12-28 Thread Raphael Kubo da Costa
rd.kde.org/r/4320/ > --- > > (Updated 2010-12-28 01:39:28) > > > Review request for kdelibs, Raphael Kubo da Costa, Jonathan Thomas, Aurélien > Gâteau, Jonathan Riddell, Adenilson Cavalcanti, loureiro, and Daniel > Nicoletti. > > > Summary > --- > > KDE n

Re: Need help with "This module still uses K_EXPORT_COMPONENT_FACTORY"

2010-12-27 Thread Raphael Kubo da Costa
On Mon, Dec 27, 2010 at 2:18 PM, Andriy Rysin wrote: > I need some help with KCModuleLoader: when I try to load kcm_keyboard in 4.6 > I get this warning > > $ kcmshell4 kcm_keyboard > kcmshell(946)/kcontrol KCModuleLoader::loadModule: This module still uses > K_EXPORT_COMPONENT_FACTORY. Please por

Re: Review Request: Add support for multiple selection in the KEditListBox and KEditListWidget widgets

2010-12-26 Thread Raphael Kubo da Costa
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/6204/#review9419 --- /trunk/KDE/kdelibs/kdeui/widgets/keditlistbox.h

Re: Review Request: Adding "net usershare" suport for KSambaShare

2010-12-22 Thread Raphael Kubo da Costa
t; http://svn.reviewboard.kde.org/r/4320/ > --- > > (Updated 2010-12-04 15:28:00) > > > Review request for kdelibs, Raphael Kubo da Costa, Jonathan Thomas, Aurélien > Gâteau, Jonathan Riddell, Adenilson Cavalcanti, loureiro, and Daniel > Nicoletti. > > > Summary > -

Re: Review request

2010-12-16 Thread Raphael Kubo da Costa
At Mon, 6 Dec 2010 14:51:12 +0100, Thomas Baumgart wrote: > Hi folks, > > I have just moved libalkimia as part of Alkimia (see > http://techbase.kde.org/Projects/KdeFinance/Alkimia for details) to > kdereview > for further processing by the community. alkvalue.h == #define ALKIMIA_

Re: Review Request: Adding "net usershare" suport for KSambaShare

2010-12-01 Thread Raphael Kubo da Costa
-- > This is an automatically generated e-mail. To reply, visit: > http://svn.reviewboard.kde.org/r/4320/ > ----------- > > (Updated 2010-12-01 01:56:04) > > > Review request for kdelibs, Raphael Kubo da Costa, Jo

Re: Review Request: Adding "net usershare" suport for KSambaShare

2010-11-18 Thread Raphael Kubo da Costa
-- > This is an automatically generated e-mail. To reply, visit: > http://svn.reviewboard.kde.org/r/4320/ > --- > > (Updated 2010-11-19 01:13:16) > > > Review request for kdelibs, Raphael Kubo da Costa, Jonat

Re: Review Request: Social About Dialog implementation for KDElibs

2010-11-09 Thread Raphael Kubo da Costa
> On 2010-11-09 00:33:12, Raphael Kubo da Costa wrote: > > * It would be nice to have unit tests for the new code. > > > > * See the documentation for KAboutData::setTranslator -- it is currently > > not possible to add any data besides the names and emails of th

Re: Review Request: Social About Dialog implementation for KDElibs

2010-11-08 Thread Raphael Kubo da Costa
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5794/#review8574 --- * It would be nice to have unit tests for the new code. * See the

Re: Removing kbugbuster from kdesdk

2010-11-06 Thread Raphael Kubo da Costa
On Saturday 06 November 2010 20:28:27 Burkhard Lück wrote: > Am Samstag, 6. November 2010, um 22:57:42 schrieb Raphael Kubo da Costa: > > Hi, > > > > kbugbuster has not seen a bug fix or feature commit in several years, and > > hasn't worked at all for a long

tags/unmaintained/4 trunk/KDE/kdesdk

2010-11-06 Thread Raphael Kubo da Costa
SVN commit 1193777 by rkcosta: Move kbugbuster from kdesdk to tags/unmaintained/4. It has not seen any bug fix or feature commit for several years and does not work with KDE's bugzilla anymore. Approved by mattr, kdesdk coordinator. CCMAIL: release-t...@kde.org CCMAIL: kde-core-devel@kde.org CC

Removing kbugbuster from kdesdk

2010-11-06 Thread Raphael Kubo da Costa
Hi, kbugbuster has not seen a bug fix or feature commit in several years, and hasn't worked at all for a long time (the URLs it uses for KDE's bugzilla do not work, to start with). I asked mattr as the kdesdk coordinator if he was OK with moving kbugbuster to tags/unmaintained/4, and he has ap

Re: Automoc and Cagibi moved to git.kde.org

2010-11-02 Thread Raphael Kubo da Costa
At Sun, 31 Oct 2010 23:14:09 +, David Jarvie wrote: > > [1 ] > On Saturday 30 October 2010 10:49:33 Christophe Giboudeaux wrote: > > Hi, > > > > Automoc and Cagibi moved to git.kde.org. > > > > Please update your local checkouts: > > > > - Automoc: http://projects.kde.org/projects/kdesuppo