Re: Review Request 127823: Allow building without strigi on Linux

were a couple of missing symbols -- see commit e328a020645899f25d0afccc196928783d6b59d1 which I just pushed. Otherwise, +1 (and the patch is landing in Debian soon). - Pino Toscano On May 3, 2016, 12:06 p.m., Antonio Rojas wrote

Re: libkgeomap

ed by other applications -- Pino Toscano

Re: libkgeomap

nds *bad* to me, especially that digikam is released so often, that having to release some extra library from time to time (*) should not be an huge overload. (*) not all the "extra" libraries bundled with digikam get changes in each release, so doing released only when having enough bugfixes/features is the best way to go -- Pino Toscano

Re: libkgeomap

gikam) has been built as standalone on build.kde.org for years, and digikam (and now kphotoalbum as well) are able to use it fine as "separate" library. IMHO this is just matter of doing own releases of libkgeomap, possibly taking care of not breaking API/ABI in each release. -- Pino Toscano

Re: libkgeomap

gikam) has been built as standalone on build.kde.org for years, and digikam (and now kphotoalbum as well) are able to use it fine as "separate" library. IMHO this is just matter of doing own releases of libkgeomap, possibly taking care of not breaking API/ABI in each release. -- Pino Toscano

Re: Review Request 121286: Adding support for lldb in DrKonqi (step 1)

> On Nov. 29, 2014, 10:20 p.m., Pino Toscano wrote: > > drkonqi/backtracegenerator.cpp, line 97 > > <https://git.reviewboard.kde.org/r/121286/diff/3/?file=331098#file331098line97> > > > > Still hardcodes the debugger name; I'm not a drkonqui developer,

Re: Review Request 121286: Adding support for lldb in DrKonqi (step 1)

tps://git.reviewboard.kde.org/r/121286/#comment49664> startsWith("libsystem_") && endsWith(".dynlib") drkonqi/parser/backtraceparser.cpp <https://git.reviewboard.kde.org/r/121286/#comment49665> This does not need a regexp. -

Re: Review Request 121286: Adding support for lldb in DrKonqi (step 1)

> On Nov. 28, 2014, 11:09 p.m., Pino Toscano wrote: > > drkonqi/backtracegenerator.cpp, lines 97-100 > > <https://git.reviewboard.kde.org/r/121286/diff/1/?file=331014#file331014line97> > > > > Shouldn't this rather be some attribute in the rc fil

Re: Review Request 121286: Adding support for lldb in DrKonqi (step 1)

will handle them. drkonqi/backtracegenerator.cpp <https://git.reviewboard.kde.org/r/121286/#comment49642> Shouldn't this rather be some attribute in the rc file, instead of hardcoding the lldb behaviour in the code? - Pino Toscano On Nov. 28, 2014, 10:50 p.m., René J.V. B

Re: Review Request 121147: Define _DEFAULT_SOURCE together with _BSD_SOURCE.

GCC versions: GNU libc, not GCC, actually. - Pino Toscano On Nov. 17, 2014, 3:29 p.m., Milian Wolff wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.k

Re: Review Request 121134: make KGlobal reference counting threadsafe

e same. - Pino Toscano On Nov. 16, 2014, 7:01 p.m., René J.V. Bertin wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboar

Re: Review Request 120195: [OS X] make sure the appropriate menu items get put in the Application menu's About and Preferences items

g/r/120195/#comment47343> Extra debug left? - Pino Toscano On Set. 25, 2014, 2:06 p.m., René J.V. Bertin wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboar

Re: Review Request 120149: [OS X] improved menubar experience: protected Preferences menu and cleaner "system tray"

> On Set. 17, 2014, 6:13 p.m., Pino Toscano wrote: > > kdeui/actions/kaction.cpp, lines 150-179 > > <https://git.reviewboard.kde.org/r/120149/diff/3/?file=312869#file312869line150> > > > > The whole setTextWithCorrectMenuRole is totally broken from an i18n

Re: Review Request 120149: [OS X] improved menubar experience: protected Preferences menu and cleaner "system tray"

> On Set. 17, 2014, 6:13 p.m., Pino Toscano wrote: > > Two general notes: > > - please respect the kdelibs coding style, for example removing the extra > > spaces in instructions > > - please remove the extra kDebug Oops, I accidentally checked "Ship it!"

Re: Review Request 120149: [OS X] improved menubar experience: protected Preferences menu and cleaner "system tray"

rg/r/120149/#comment46567> What is this used for? If it is not used, please remove it, otherwise just include it unconditionally at the top (and not in the middle of the file, and just for Q_OS_MAC). - Pino Toscano

Re: Review Request 114298: prevent ksplashqml crash when a theme does not exist or cannot be loaded

ttp://git.reviewboard.kde.org/r/114298/#comment32271> What about just calling ::exit(2) to reach the stdlib function, avoiding the exitNow "wrapper"? - Pino Toscano On Dec. 4, 2013, 1:54 p.m., Harald Sitter wrote: > > --- >

Re: Review Request 111341: Oxygenify KNetattach

knetattach icon). - Pino Toscano On July 1, 2013, 3:12 p.m., Rohan Garg wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.review

Re: Review Request 110328: Add config option to silently create initial password-less wallet

d QString::clear() { if (!isNull()) *this = QString(); } -- Pino Toscano signature.asc Description: This is a digitally signed message part.

Re: kdev-python move to extragear -- once more

ere this fork specifically would > be a problem. There were many, provided by Sune Vuorela or myself, in various emails of this and the intial review thread [1]. [1] «Review of kdev-python for move to extragear» -- Pino Toscano signature.asc Description: This is a digitally signed message part.

Re: kdev-python move to extragear -- once more

when the software copied is something critical as python. As said in previous emails, this would put a non- trivial burden over packagers (and potentially also over self-compiling users). [1] OTOH you are not the only one -- hello Gilles Caulier! -- Pino Toscano signature.asc Description: This is a digitally signed message part.

Re: Review Request 108592: Added some more operations in analitza

orry about because of some "anal litza" (because > "analyza" is close to the "anal lisa" then; ftr: litza actually /is/ > a female name) > > Regardless of that and just out of curiosity: > do you mind explaining the "litza" part? IIRC it derives from the catalan verb "analitzar" (= analyze), see also http://www.catalandictionary.org/eng/?q=conjugator/analitzar/regular -- Pino Toscano signature.asc Description: This is a digitally signed message part.

Re: KDEREVIEW: share like connect and plasmate

Alle giovedì 3 gennaio 2013, Giorgos Tsiapaliokas ha scritto: > On 3 January 2013 01:51, Pino Toscano wrote: > > - PasswordAsker sounds like could be implemented on top of > > KPasswordDialog > > we have asked in #kde-devel and we have been informed that > kdia

Re: KDEREVIEW: share like connect and plasmate

Alle giovedì 3 gennaio 2013, Giorgos Tsiapaliokas ha scritto: > On 2 January 2013 23:38, Pino Toscano wrote: > > > - BranchDialog sounds like could be replaced with > > > KInputDialog::getText with a custom validator > > > > Still there. > > > >

Re: KDEREVIEW: share like connect and plasmate

Hi, apparently some people consider that all the issues of this review have been fixed, but really they were not. Alle sabato 3 novembre 2012, Pino Toscano ha scritto: > - PasswordAsker sounds like could be implemented on top of > KPasswordDialog Still there. > - BranchDialog so

Re: Review of kdev-python for move to extragear

explained by my > follow-up email, or does anyone think this issue needs further > discussion? I still think the modified copy of the python sources is really a bad idea, from both a security and a maintaineance points of view, and thus it gets my -1. -- Pino Toscano signature.asc Descr

Re: kdepimlibs dependency on nepomuk-core breaks build for Calligra and kdeplasma-addons

Alle lunedì 17 dicembre 2012, Alexander Neundorf ha scritto: > On Monday 17 December 2012, Pino Toscano wrote: > > Alle lunedì 17 dicembre 2012, Ben Cooksley ha scritto: > > > Currently build.kde.org is unable to successfully complete builds > > > of kdeplasma-addons

Re: kdepimlibs dependency on nepomuk-core breaks build for Calligra and kdeplasma-addons

> find_package(NepomukCore) Simple: nepomuk-core/NepomukCoreConfig.cmake.in is broken (see NEPOMUK_CORE_LIB_DIR and NEPOMUK_CORE_LIBRARY). -- Pino Toscano signature.asc Description: This is a digitally signed message part.

Re: Review of kdev-python for move to extragear

n gets some CVE from time to time, so this would impose an extra burden on packagers (and self-compiling users which need to patch and upgrade on their own). -- Pino Toscano signature.asc Description: This is a digitally signed message part.

Re: Review Request: Fix KIO listDir entries batching

> On Nov. 29, 2012, 7:48 p.m., Pino Toscano wrote: > > kioslave/file/file_unix.cpp, line 363 > > <http://git.reviewboard.kde.org/r/107520/diff/1/?file=96853#file96853line363> > > > > This would be QFile::decodeName, not QString::fromLocal8Bit... but you &g

Re: Review Request: Fix KIO listDir entries batching

g/r/107520/#comment17395> This would be QFile::decodeName, not QString::fromLocal8Bit... but you don't need it either, since you have "path" already. - Pino Toscano On Nov. 29, 2012, 7:33 p.m., Mark Gaiser wrote: > > -

kde-workspace/4.9 messed up

Hi, somehow the master branch of kde-workspace has been merged in the KDE/4.9 branch, with obvious consequences. Can anyone please fix this mess? Thanks, -- Pino Toscano signature.asc Description: This is a digitally signed message part.

Re: KDEREVIEW: share like connect and plasmate

tually understand what I'm referring to? -- Pino Toscano signature.asc Description: This is a digitally signed message part.

Re: KDE-GTK-Config to KDEReview

ric name for hicolor, I renamed it to kde-gtk-config.png -- Pino Toscano signature.asc Description: This is a digitally signed message part.

Re: KDE-GTK-Config to KDEReview

Hi, Alle mercoledì 7 novembre 2012, Aleix Pol ha scritto: > On Wed, Nov 7, 2012 at 12:49 AM, Pino Toscano wrote: > > Alle lunedì 5 novembre 2012, Aleix Pol ha scritto: > >> Some months ago I pushed this project quite intensively so that > >> right now we have a sta

Re: KDE-GTK-Config to KDEReview

don't need FindMSGFMT.cmake, since cmake and kdelibs have FindGettext.cmake - the differences between gtkproxies/preview.c and gtk3proxies/preview3.c seem minimal; is there really no way to have just one source with at most 1-2 «#if GTK_IS_VERSION(...)» blocks? also, doesn't glib/gtk o

Re: Moving libkfacebook to extragear

erInfo has no getters for city and country - in UserInfo picture is a QUrl but website a QString? - remember to remove the qjson includes from public headers [1] http://techbase.kde.org/Policies/Library_Code_Policy/Shared_D-Pointer_Example -- Pino Toscano signature.asc Description: This is a digitally signed message part.

Re: KDEREVIEW: share like connect and plasmate

Alle lunedì 5 novembre 2012, Giorgos Tsiapaliokas ha scritto: > On 4 November 2012 16:55, Pino Toscano wrote: > > - the following binaries are installed in $prefix/bin: > > - plasmaengineexplorer > > - plasmakconfigxteditor > > - plasmaremot

Re: KDEREVIEW: share like connect and plasmate

Hi, Alle lunedì 5 novembre 2012, Giorgos Tsiapaliokas ha scritto: > On 3 November 2012 19:35, Pino Toscano wrote: > > - a numer of .ui files sets bold/bigger texts, but using a qt rich > > text which forces a font size (and in few cases also the font > > face) > > a

Re: KDEREVIEW: share like connect and plasmate

Hi, Alle sabato 3 novembre 2012, Pino Toscano ha scritto: > Alle giovedì 1 novembre 2012, Aaron J. Seigo ha scritto: > > This is to inform everyone that the plasmate and share-like-connect > > repositories have been moved into KDE Review so that, if all goes > > according

Re: KDEREVIEW: share like connect and plasmate

for actions (never ever compare to translated strings, especially when coming from other components) I think that's enough for now. -- Pino Toscano signature.asc Description: This is a digitally signed message part.

Re: Review Request: In Konqueror's session restore dialog, allow user to chose which sessions to restore

e correct icon. konqueror/src/konqsessionmanager.cpp <http://git.reviewboard.kde.org/r/106503/#comment15545> i18n: remove the space before the question mark, please - Pino Toscano On Sept. 28, 2012, 4:45 p.m., Dawit Alemayehu wrote: > >

Re: Compiler version

> into line - Slackware) > > ... > Debian Stable (Squeeze) is also 4.5 by default. Debian Stable (Squeeze) is 4.4.5 by default, with GCC 4.3.5 being provided too. -- Pino Toscano signature.asc Description: This is a digitally signed message part.

Re: Binary compatiblity for liboxygenstyle.so

way you can tell users to just run any application from terminal to see which oxygen style plugin is loaded. Or for example you can add a "version" string property to any instance of the OxygenStyle (any QStyle is a QObject), then in oxygen-settings load a new oxygen style (if not already loaded) and print the version string of that instance, to easily see which style is loaded. -- Pino Toscano signature.asc Description: This is a digitally signed message part.

Re: Binary compatiblity for liboxygenstyle.so

Alle venerdì 24 febbraio 2012, Hugo Pereira Da Costa ha scritto: > On 02/24/2012 12:01 PM, Pino Toscano wrote: > > Alle venerdì 24 febbraio 2012, Hugo Pereira Da Costa ha scritto: > >> On 02/24/2012 11:43 AM, Pino Toscano wrote: > >>> Alle venerdì 24 febbraio 2012, Hu

Re: Binary compatiblity for liboxygenstyle.so

Alle venerdì 24 febbraio 2012, Hugo Pereira Da Costa ha scritto: > On 02/24/2012 11:43 AM, Pino Toscano wrote: > > Alle venerdì 24 febbraio 2012, Hugo Pereira Da Costa ha scritto: > >> no there is no guarantee for liboxygenstyle.so.4, and I don't plan > >> to guara

Re: Binary compatiblity for liboxygenstyle.so

he same SONAME (liboxygenstyle.so.4) for API-/ABI- incompatible new versions of it. -- Pino Toscano signature.asc Description: This is a digitally signed message part.

Re: Klipper

pper a potential target for the upcoming > modularization efforts, then? Yay for buzzwords used at random! In other news, passing -DBUILD_klipper=OFF to cmake for kde-workspace should already make klipper not being compiled. -- Pino Toscano signature.asc Description: This is a digitally signed message part.

Re: Review Request: fix wrong file extension for kmplot

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101059/#review2740 --- Ship it! I guess some typo when in created kde.xml (more than 4

Re: new kdevelop sessions runner for review

7;ve left some review in RB. -- Pino Toscano signature.asc Description: This is a digitally signed message part.

Re: KShutdown got to kde-runtime without review

Alle giovedì 17 febbraio 2011, Pino Toscano ha scritto: > Alle giovedì 17 febbraio 2011, Ralf Habacker ha scritto: > > Am 17.02.2011 09:32, schrieb Pino Toscano: > > > Alle giovedì 17 febbraio 2011, Ralf Habacker ha scritto: > > >> Am 17.02.2011 09:18, schrieb Ralf H

Re: KShutdown got to kde-runtime without review

Alle giovedì 17 febbraio 2011, Ralf Habacker ha scritto: > Am 17.02.2011 09:32, schrieb Pino Toscano: > > Alle giovedì 17 febbraio 2011, Ralf Habacker ha scritto: > >> Am 17.02.2011 09:18, schrieb Ralf Habacker: > >>> Am 16.02.2011 20:40, schrieb Albert Astals Cid

Re: KShutdown got to kde-runtime without review

y :-) > > If you insist on following the formal process I can submit a review > request and will do the review Can you please rename it to e.g. kdewin-shutdown or similar, given that there's already a kshutdown application for KDE for years? -- Pino Toscano signature.asc Description: This is a digitally signed message part.

www/sites/www/announcements/changelogs

SVN commit 1220053 by pino: upate the changelog.xsl to support gitweb links kind of abstract the "web $vcs" name and link generation, deducing the repository type from the revision string: - less than 7 chars, svn - 40 chars, git additionally, introduce a new "reponame" attribute for "module",

Re: Review Request: Workaround for the hang (freeze) when opening VLC's file dialog under KDE...

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100539/#review1230 --- Ship it! Looks ok now. - Pino On Feb. 4, 2011, 6:22 p.m., Da

Re: Review Request: Workaround for the hang (freeze) when opening VLC's file dialog under KDE...

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100539/#review1199 --- Still the coding style issues to fix in the new code. kdecore/

Re: Review Request: Workaround for the hang (freeze) when opening VLC's file dialog under KDE...

> On Feb. 4, 2011, 8:02 a.m., Pino Toscano wrote: > > Please also add the { } around single line blocks (as per kdelibs coding > > style). > > Dawit Alemayehu wrote: > Lets us forget about such nitpicks, okay... If such unnecessary coding > styles were to be

Re: Review Request: Workaround for the hang (freeze) when opening VLC's file dialog under KDE...

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100539/#review1190 --- Please also add the { } around single line blocks (as per kdelib

Re: Review Request: Workaround for the hang (freeze) when opening VLC's file dialog under KDE...

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100539/#review1188 --- kdecore/services/kmimetyperepository.cpp

Re: Review Request: Workaround for the hang (freeze) when opening VLC's file dialog under KDE...

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100539/#review1186 --- kdecore/services/kmimetyperepository.cpp

Re: Merge or Cherry-Pick?

n this ml, before commit it, thanks. -- Pino Toscano signature.asc Description: This is a digitally signed message part.

Re: kdelibs, kdebase moving to Git this Saturday

ory, past tags and branches), where are the wallpapers now? -- Pino Toscano signature.asc Description: This is a digitally signed message part.

Re: proposal: remove KTextEditor interface from kdelibs repository

kdelibs piece-by-piece is something useful to do over time: either you split the whole at once, or you don't. -- Pino Toscano signature.asc Description: This is a digitally signed message part.