, KDE Usability and Patrick Eigensatz.
Changes
---
Patch compiles, needs to be tested!
Bugs: 159267 and 192922
https://bugs.kde.org/show_bug.cgi?id=159267
https://bugs.kde.org/show_bug.cgi?id=192922
Repository: plasma-workspace
Description
---
[PATCH] plasma-workspace: klipper
> On Mai 21, 2015, 5:02 nachm., Patrick Eigensatz wrote:
> > klipper/klipper.kcfg, line 24
> > <https://git.reviewboard.kde.org/r/123806/diff/7/?file=370396#file370396line24>
> >
> > **Question:** Compiled plasma-workspace using *kdesrc-build
> >
> On Mai 21, 2015, 5:02 nachm., Patrick Eigensatz wrote:
> > klipper/klipper.kcfg, line 24
> > <https://git.reviewboard.kde.org/r/123806/diff/7/?file=370396#file370396line24>
> >
> > **Question:** Compiled plasma-workspace using *kdesrc-build
> >
> On Mai 21, 2015, 5:02 nachm., Patrick Eigensatz wrote:
> > klipper/klipper.kcfg, line 24
> > <https://git.reviewboard.kde.org/r/123806/diff/7/?file=370396#file370396line24>
> >
> > **Question:** Compiled plasma-workspace using *kdesrc-build
> >
> On Mai 21, 2015, 5:02 nachm., Patrick Eigensatz wrote:
> > klipper/klipper.kcfg, line 24
> > <https://git.reviewboard.kde.org/r/123806/diff/7/?file=370396#file370396line24>
> >
> > **Question:** Compiled plasma-workspace using *kdesrc-build
> >
mbers. (I didn't change anything, original
kconfig_compiler output)
- Patrick Eigensatz
On Mai 21, 2015, 5 nachm., Patrick Eigensatz wrote:
>
> ---
> This is an automatically generated e-mail. To reply, vis
Usability and Patrick Eigensatz.
Changes
---
Fixed some C++ compiling issues. (nullptr needs to be static_casted)
Bugs: 159267 and 192922
https://bugs.kde.org/show_bug.cgi?id=159267
https://bugs.kde.org/show_bug.cgi?id=192922
Repository: plasma-workspace
Description
> On Mai 18, 2015, 7:28 nachm., Patrick Eigensatz wrote:
> > klipper/historyitem.cpp, line 92
> > <https://git.reviewboard.kde.org/r/123806/diff/6/?file=370091#file370091line92>
> >
> > Not sure if *text.isEmpty()* returns true if text=="\n\t \n&q
tps://git.reviewboard.kde.org/r/123806/#comment55268>
Not sure if *text.isEmpty()* returns true if text=="\n\t \n"
QT Documentation says: "Returns true if the string has no characters"
I'm not sure if we could omit *.trimmed()*.
- Patrick Eigensatz
On Mai 18, 2015,
, KDE Usability and Patrick Eigensatz.
Changes
---
Added option: "Allow whitespace entries" which is false by default.
I'm sorry as I still could not even compile this one :(
Bugs: 159267 and 192922
https://bugs.kde.org/show_bug.cgi?id=159267
https://bugs.kde.org/show_bu
would call
> > the config option differently as the code is not trimming whitespaces but
> > rather ignoring whitespace entries.
>
> Patrick Eigensatz wrote:
> Are we trimming whitespace? Or are we going to simplify it? I try to call
> the option as sensible/useful as possible
would call
> > the config option differently as the code is not trimming whitespaces but
> > rather ignoring whitespace entries.
>
> Patrick Eigensatz wrote:
> Are we trimming whitespace? Or are we going to simplify it? I try to call
> the option as sensible/useful as possible
> On Mai 16, 2015, 9:37 nachm., Patrick Eigensatz wrote:
> > klipper/historyitem.cpp, line 91
> > <https://git.reviewboard.kde.org/r/123806/diff/5/?file=369605#file369605line91>
> >
> > I'm not sure if I can access "Klipper" from here. If
would call
> > the config option differently as the code is not trimming whitespaces but
> > rather ignoring whitespace entries.
>
> Patrick Eigensatz wrote:
> Are we trimming whitespace? Or are we going to simplify it? I try to call
> the option as sensible/useful as possible
> On Mai 16, 2015, 9:37 nachm., Patrick Eigensatz wrote:
> > klipper/historyitem.cpp, line 91
> > <https://git.reviewboard.kde.org/r/123806/diff/5/?file=369605#file369605line91>
> >
> > I'm not sure if I can access "Klipper" from here. If
> On Mai 16, 2015, 9:37 nachm., Patrick Eigensatz wrote:
> > klipper/historyitem.cpp, line 91
> > <https://git.reviewboard.kde.org/r/123806/diff/5/?file=369605#file369605line91>
> >
> > I'm not sure if I can access "Klipper" from here. If
> On Mai 16, 2015, 9:37 nachm., Patrick Eigensatz wrote:
> > klipper/historyitem.cpp, line 91
> > <https://git.reviewboard.kde.org/r/123806/diff/5/?file=369605#file369605line91>
> >
> > I'm not sure if I can access "Klipper" from here. If
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123806/#review80532
-----------
On Mai 16, 2015, 9:31 nachm., Patrick Eigensatz wrote:
>
>
> On Mai 16, 2015, 9:37 nachm., Patrick Eigensatz wrote:
> > klipper/historyitem.cpp, line 91
> > <https://git.reviewboard.kde.org/r/123806/diff/5/?file=369605#file369605line91>
> >
> > I'm not sure if I can access "Klipper" from here. If
t; > whitespace, i.e. for items that aren't completely whitespace.
> >
> > Firefox loves to add leading whitespace when copying double-clicked
> > text, but Klipper does not show this in the menu.
>
> Christoph Feck wrote:
> See bug 159267.
>
> P
t; > whitespace, i.e. for items that aren't completely whitespace.
> >
> > Firefox loves to add leading whitespace when copying double-clicked
> > text, but Klipper does not show this in the menu.
>
> Christoph Feck wrote:
> See bug 159267.
>
> P
t; > whitespace, i.e. for items that aren't completely whitespace.
> >
> > Firefox loves to add leading whitespace when copying double-clicked
> > text, but Klipper does not show this in the menu.
>
> Christoph Feck wrote:
> See bug 159267.
>
> P
ss the setting. (Pass it? Check it in
the klipper class?)
Thank you :)
- Patrick Eigensatz
On Mai 16, 2015, 9:31 nachm., Patrick Eigensatz wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
>
, KDE Usability and Patrick Eigensatz.
Changes
---
This patch should add the config option and fix the issue. I'm not 100% sure it
will work...
Bugs: 159267 and 192922
https://bugs.kde.org/show_bug.cgi?id=159267
https://bugs.kde.org/show_bug.cgi?id=192922
Repository: plasma-work
t; > whitespace, i.e. for items that aren't completely whitespace.
> >
> > Firefox loves to add leading whitespace when copying double-clicked
> > text, but Klipper does not show this in the menu.
>
> Christoph Feck wrote:
> See bug 159267.
>
> P
t; > whitespace, i.e. for items that aren't completely whitespace.
> >
> > Firefox loves to add leading whitespace when copying double-clicked
> > text, but Klipper does not show this in the menu.
>
> Christoph Feck wrote:
> See bug 159267.
>
> P
f he wants to see "blank"
entries.
Seems like the best solution to me. :)
- Patrick
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123806/#review80466
--------
, KDE Usability and Patrick Eigensatz.
Changes
---
Fixed issue
Bugs: 159267 and 192922
https://bugs.kde.org/show_bug.cgi?id=159267
https://bugs.kde.org/show_bug.cgi?id=192922
Repository: plasma-workspace
Description
---
[PATCH] plasma-workspace: klipper: Fix #192922 Ignore
, KDE Usability and Patrick Eigensatz.
Changes
---
New diff: Added enabling/disabling of options in the config dialog
Bugs: 192922
https://bugs.kde.org/show_bug.cgi?id=192922
Repository: plasma-workspace
Description
---
[PATCH] plasma-workspace: klipper: Fix #192922 Ignore blank
newlines and I do want to have them in the history. If I understand
> > your commit description correctly this "feature" would break.
> >
> > Given that I think we need more input on whether we want to break that
> > feature or whether we want to crea
, KDE Usability and Patrick Eigensatz.
Changes
---
Working draft patch
Bugs: 192922
https://bugs.kde.org/show_bug.cgi?id=192922
Repository: plasma-workspace
Description
---
[PATCH] plasma-workspace: klipper: Fix #192922 Ignore blank entries
QString::isEmpty() is used to check if
newlines and I do want to have them in the history. If I understand
> > your commit description correctly this "feature" would break.
> >
> > Given that I think we need more input on whether we want to break that
> > feature or whether we want to crea
newlines and I do want to have them in the history. If I understand
> > your commit description correctly this "feature" would break.
> >
> > Given that I think we need more input on whether we want to break that
> > feature or whether we want to crea
newlines and I do want to have them in the history. If I understand
> > your commit description correctly this "feature" would break.
> >
> > Given that I think we need more input on whether we want to break that
> > feature or whether we want to crea
newlines and I do want to have them in the history. If I understand
> > your commit description correctly this "feature" would break.
> >
> > Given that I think we need more input on whether we want to break that
> > feature or whether we want to crea
newlines and I do want to have them in the history. If I understand
> > your commit description correctly this "feature" would break.
> >
> > Given that I think we need more input on whether we want to break that
> > feature or whether we want to crea
newlines and I do want to have them in the history. If I understand
> > your commit description correctly this "feature" would break.
> >
> > Given that I think we need more input on whether we want to break that
> > feature or whether we want to crea
newlines and I do want to have them in the history. If I understand
> > your commit description correctly this "feature" would break.
> >
> > Given that I think we need more input on whether we want to break that
> > feature or whether we want to crea
newlines and I do want to have them in the history. If I understand
> > your commit description correctly this "feature" would break.
> >
> > Given that I think we need more input on whether we want to break that
> > feature or whether we want to crea
ough I've never done this before and I would surely need some assistance...
- Patrick
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123806/#review80423
-------
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123806/
---
Review request for kde-workspace and Patrick Eigensatz.
Bugs: 192922
discarded.
Review request for kde-workspace and Patrick Eigensatz.
Bugs: 192922
http://bugs.kde.org/show_bug.cgi?id=192922
Repository: kde-workspace
Description
---
[PATCH] kde-workspace: klipper: Fix #192922 Ignore blank entries
QString::isEmpty() is used to check if the string
Patrick Eigensatz.
Changes
---
The new patchfile. Note: I can't upload it as diff because it file structures
in plasma-workspace are different than in kde-workspace.
Please see the **attached file**.
Bugs: 192922
http://bugs.kde.org/show_bug.cgi?id=192922
Repository: kde-work
> On Mai 15, 2015, 6:01 nachm., Martin Gräßlin wrote:
> > This patch is against kde-workspace, but the development happens in
> > plasma-workspace nowadays. Could you please rebase against the newer
> > repository?
>
> Patrick Eigensatz wrote:
> Sorry, I s
r/123797/#review80412
---
On Mai 15, 2015, 6:05 nachm., Patrick Eigensatz wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https:/
Patrick Eigensatz.
Changes
---
Uploaded the patchfile containing 2 commits:
1. Fix the issue
2. Code Cleanup
Bugs: 192922
http://bugs.kde.org/show_bug.cgi?id=192922
Repository: kde-workspace
Description
---
[PATCH] kde-workspace: klipper: Fix #192922 Ignore blank entries
> On Mai 15, 2015, 2:27 nachm., Kai Uwe Broulik wrote:
> > plasma-workspace/klipper/historyitem.cpp, line 89
> > <https://git.reviewboard.kde.org/r/123797/diff/1/?file=369295#file369295line89>
> >
> > return nullptr;
>
> Patrick Eigensatz wro
> On Mai 15, 2015, 2:27 nachm., Kai Uwe Broulik wrote:
> > plasma-workspace/klipper/historyitem.cpp, line 89
> > <https://git.reviewboard.kde.org/r/123797/diff/1/?file=369295#file369295line89>
> >
> > return nullptr;
>
> Patrick Eigensatz wro
Patrick Eigensatz.
Changes
---
Please have a look at the updated version of this patch. Issues should be fixed
now :)
Bugs: 192922
http://bugs.kde.org/show_bug.cgi?id=192922
Repository: kde-workspace
Description
---
[PATCH] kde-workspace: klipper: Fix #192922 Ignore blank
----------
On Mai 15, 2015, 2:24 nachm., Patrick Eigensatz wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123797/
> ---
Patrick Eigensatz.
Changes
---
Added kde-workspace group
Bugs: 192922
http://bugs.kde.org/show_bug.cgi?id=192922
Repository: kde-workspace
Description
---
[PATCH] kde-workspace: klipper: Fix #192922 Ignore blank entries
QString::trimmed() is used to check if the string only
51 matches
Mail list logo
