Re: openSUSE packagers' take on the 3 month release cycle

On Tue, Jul 9, 2013 at 9:14 AM, Vishesh Handa wrote: > On Tue, Jul 9, 2013 at 4:13 PM, Scott Kitterman wrote: >>> > These all have to be test compiled, checked for new or missing files, >>> > checked for files that have moved between packages, checked for >>> > license/copyright updates, etc. >>> >

Re: Review Request 110262: KRandomSequence::randomize: use the Fisher-Yates Algorithm to achieve O(N) complexity

> On May 1, 2013, 9:03 p.m., Parker Coates wrote: > > Since KRandomSequence is a class for generating a predictable random > > sequence, is it not possible that this change would break applications that > > relied on the code below producing a consistent result between

Re: Review Request 110262: KRandomSequence::randomize: use the Fisher-Yates Algorithm to achieve O(N) complexity

; - Parker Coates On May 1, 2013, 8:34 p.m., Frank Reininghaus wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.

Re: Review Request 110262: KRandomSequence::randomize: use the Fisher-Yates Algorithm to achieve O(N) complexity

; - Parker Coates On May 1, 2013, 8:34 p.m., Frank Reininghaus wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.

Re: Review Request 110262: KRandomSequence::randomize: use the Fisher-Yates Algorithm to achieve O(N) complexity

; - Parker Coates On May 1, 2013, 8:34 p.m., Frank Reininghaus wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.

Re: Review Request: Prevent Konqueror's address bar from being hidden by default

> On July 27, 2012, 8:50 a.m., David Faure wrote: > > I like the idea, but why the non-editable combo? What happens when > > navigating, in that window? Doesn't the combo then start to be messed up > > (the code assuming that it is editable, has history items, has completion, > > etc.) ... esp

Re: Review Request: Only show the "Find File" action for local URL in Dolphin's KPart

ration. - Parker Coates On July 18, 2012, 2:53 a.m., Dawit Alemayehu wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboar

Re: Review Request: Fix Bug 152156 - KDE help center does not respect window placement policy

> On April 18, 2012, 6 p.m., Parker Coates wrote: > > khelpcenter/mainwindow.cpp, line 170 > > <http://git.reviewboard.kde.org/r/104662/diff/1/?file=58010#file58010line170> > > > > I've seen a few applications use a certain fraction of the screen s

Re: Review Request: Fix Bug 152156 - KDE help center does not respect window placement policy

ttp://git.reviewboard.kde.org/r/104662/#comment9879> I've seen a few applications use a certain fraction of the screen size as the default. See http://websvn.kde.org/trunk/KDE/kdegames/kpat/mainwindow.cpp?view=markup#l118 . I'm not sure that's necessarily the best default, though. - Parker

Re: bugzilla situation

On Sat, Feb 25, 2012 at 03:06, dE . wrote: > I tend to think closing duplicate bugs and checking wish list issues can be > done by a non-developer contributers. In which case there should be an > option by which a particular user can be CCd to for a specific program(s). > There should be an entry a

Re: bugzilla situation

On Wed, Feb 22, 2012 at 10:23, Stefan Majewsky wrote: > On Wed, Feb 22, 2012 at 4:11 PM, David Faure wrote: >> "give rights to everyone, and remove rights when >> someone abuses them". This is also what we do for SVN/GIT, so why don't we do >> this for bugzilla? Presuming people are innocent upfron

Re: Please avoid noisy merge commits in frameworks

On Sun, Feb 19, 2012 at 11:58, Anne-Marie Mahfouf wrote: > I guess I should get used to using gitk. This is slightly off topic, but with all this talk of gitk, I thought it'd be a good time to recommend QGit [1]. It's an alternative git history viewer with a friendlier interface built on top of a

Re: Review Request: Support passing an argument to the Locale KCM tab to specify which tab to activate at load.

> On Oct. 23, 2011, 5:49 p.m., John Layt wrote: > > Hi Dave, as maintainer of the Locale KCM I'm happy for this to go in, but > > we do need to make the command line option consistent for all the KCM's. I > > suggest checking with Ben Cooksley who is overall maintainer of System > > Settings a

Re: Module layout proposal: Split kdegames-data from kdegames

On Fri, Oct 14, 2011 at 14:29, Stefan Majewsky wrote: > DETAILED PROPOSAL > > kdegames is among the few modules that have not yet switched to Git. > The main concern is that the kdegames source tree contains tons [1] of > binary data files, which Git is known not to handle well. All > dis

Re: Security Audit Request for Screenlocker Branch

On Sun, Oct 9, 2011 at 14:02, Martin Gräßlin wrote: > I want to request a security audit for the changes to ensure that the new > implementation is as secure as the existing one and that I did not forget an > important case which would compromise the security. > > The general concept of the new scr

Re: KImageCache, KPixmapCache and KSharedDataCache VS QPixmapCache and QCache

On Sat, May 14, 2011 at 15:51, Christoph Feck wrote: > On Saturday 14 May 2011 21:42:18 Mark wrote: >> Why is KDE having it's own image/pixmap caching classes >> when the Qt lib also has them (QPixmapCache and QCache). > > KDE's cache classes are on-disk caches and cross-application, while Qt's cac

Re: Review Request: Fix the layout of KNameAndUrlInputDialog (kfile)

> On May 8, 2011, 9:03 p.m., Michael Pyne wrote: > > kfile/knameandurlinputdialog.cpp, line 67 > > > > > > It is inappropriate to create QWidgets that have no parent, unless you > > have a different means of ensurin

Re: Review Request: Fix the layout of KNameAndUrlInputDialog (kfile)

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101312/#review3200 --- Adding some before and after screenshots would probably get you

Re: Help on .desktop files for oxygen

On Fri, May 6, 2011 at 05:50, Hugo Pereira Da Costa wrote: > Some follow-up. > > I coded locally the necessary changes to have "oxygen-settings" included > inside "systemsettings", even when through changing the various pages into > KCModules, and ... well ... it pretty much defeats the purpose (s

Re: Review Request: Proper "All files" option when using mime types as filters for KFileDialog's functions

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101075/#review2553 --- While I'm not really qualified to comment on the implementation,

Re: Review Request: Improvements to KFileDialog filtering

-- On April 2, 2011, 11:47 p.m., Parker Coates wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/101013/ > ---

Re: Review Request: Improvements to KFileDialog filtering

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101013/ --- (Updated April 2, 2011, 11:47 p.m.) Review request for kdelibs. Changes

Review Request: Improvements to KFileDialog filtering

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101013/ --- Review request for kdelibs. Summary --- This patch attempts to improv

Re: Review Request: Adding Ångström to KUnitConversion

> On March 22, 2011, 10:14 p.m., Parker Coates wrote: > > kunitconversion/length.cpp, line 146 > > <http://git.reviewboard.kde.org/r/100923/diff/1/?file=12695#file12695line146> > > > > You missed "Angstrom". Accents are too hard for some of

Re: Review Request: Adding Ångström to KUnitConversion

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100923/#review2109 --- kunitconversion/length.cpp

Re: 4.6 branches created in git again

On Sun, Mar 20, 2011 at 10:57, Ian Monroe wrote: > On Sun, Mar 20, 2011 at 09:45, John Tapsell wrote: >> Why do we let people create branches on the main git server anyway? > > Well for feature branches its fine and kind of the point of git. > There's no reason to let non-admins create version bran

Re: 4.6 branches created in git again

On Sun, Mar 20, 2011 at 10:09, Andreas Hartmetz wrote: > On Sunday 20 March 2011 14:38:40 Albert Astals Cid wrote: >> Can you please be careful and do not create incorrectly 4.6 branches in >> places where the branch is called KDE/4.6 (e.g kdelibs and kde-runtime) >> >> Ian can you kill them? > > M

Re: Git Workflow - Outstanding Issues

On Fri, Mar 18, 2011 at 23:25, Wolfgang Rohdewald wrote: > On Freitag 18 März 2011, John Layt wrote: >> * Commit Template >> I've finally committed the Commit Template into kdelibs, any >> Git project that  wants to use a different version can commit >> that to their own repo provided they follow t

Re: Git Commit Template

On Fri, Mar 4, 2011 at 10:58, John Layt wrote: > Below is one final draft of the Commit Template.  If no-one objects I will ask > the sysadmins to add it to the necessary repositories. NOTE: The following is bikeshedding. I support the idea of a commit template and do not object to the one you sug

Re: git workflow draft

On Fri, Feb 18, 2011 at 03:21, Johannes Sixt wrote: > I'm tired aguing, so I'll leave it at that. Just one point (because I > don't want to be called silly): > > Am 2/17/2011 21:56, schrieb Stephen Kelly: >>> Choose a starting point >>> that is convenient; but DO NOT CHANGE IT once you have done se

Re: prison - a barcode library now in kdereview

On Tue, Feb 15, 2011 at 03:45, Sune Vuorela wrote: > I have added prison (git clone kde:prison) to kdereview, targetting > kdesupport. Out of curiosity, what SC component is intended to use it? > Please review. > > I'm having a couple of doxygen warnings... Are there generated docs available som

Re: Merge or Cherry-Pick?

On Tue, Feb 1, 2011 at 06:29, Johannes Sixt wrote: > Am 2/1/2011 10:31, schrieb David Jarvie: >> On Mon, January 31, 2011 11:27 pm, Thiago Macieira wrote: >>> On Monday, 31 de January de 2011 23:34:39 Arno Rehn wrote: I guess that won't quite work when there are commits specific to 4.6 in

Re: Merge or Cherry-Pick?

On Wed, Feb 2, 2011 at 09:05, John Layt wrote: > On Wednesday 02 February 2011 13:43:04 Parker Coates wrote: >> My preferred workflow is to put all local commits intended for master >> in a single, local, long-lived "workmaster" branch instead of putting >> the

Re: irc meeting for kdelibs git workflow

On Wed, Feb 2, 2011 at 08:45, John Layt wrote: > On Wednesday 02 February 2011 09:19:29 Oswald Buddenhagen wrote: >> i'd suggest a look at http://qt.gitorious.org/qt/pages/CommitPolicy, in >> particular point 8 of the rules. the point it makes is independent from >> using git (in fact, we have a si

Re: Merge or Cherry-Pick?

On Wed, Feb 2, 2011 at 08:25, David Jarvie wrote: > I'd recommend maintaining a local 'master' branch which always mirrors the > remote repository. Never do development in your local 'master' branch - > always do your work in other local branches, and only merge/cherry-pick > changes from them int

Re: Merge or Cherry-Pick?

On Wed, Feb 2, 2011 at 00:35, Dawit A wrote: > I learned this the hard way, but it is even more problematic, at least > for me, when you attempt to learn how to adapt or re-learn how to do a > particular workflow with git. For example, let us take one of the > things Alexander mentioned in his emai

Re: Initial support for kde_projects.xml in kdesrc-build

On Mon, Jan 31, 2011 at 19:08, Michael Pyne wrote: > On Monday, January 31, 2011 18:19:12 Albert Astals Cid wrote: >> cons: >>  * There is black magic happening behind your back and once something >> breaks you won't know how to fix things by yourself. > > For instance even after using kdesrc-build

Re: Merge or Cherry-Pick?

On Mon, Jan 31, 2011 at 17:36, Stefan Majewsky wrote: > On Mon, Jan 31, 2011 at 11:34 PM, Arno Rehn wrote: >> >> (Feature branches are a different thing). > > Am I right that these should be rebased instead of merged? It's my understanding that rebasing is only allowed for private, local branches.

Re: Usefulness of Subject-header of git commit mails

On Fri, Jan 28, 2011 at 11:42, Andreas Hartmetz wrote: > On Monday 24 January 2011 00:13:26 Eike Hein wrote: >> >> Yep - for the benefit of those who aren't used to the git >> jargon (sorry for that), in git the convention is to for- >> mat the commit message like this: >> >> >> >> >> >> While d

Re: KDE git docs for dummies ? WAS: Re: splitting up kdebase in git

2011/1/20 Alexander Neundorf: > As long as there is no policy defined, I simply try to push/merge to the > respective master ? > I also think that really most/all new KDE git repositories should use a common > workflow. I think this is a reasonable expectation for all repositories that are part of

Re: Action icons in menus

On Mon, Dec 13, 2010 at 16:26, Miha Čančula wrote: > 2010/12/13 Albert Astals Cid >> A Dilluns, 13 de desembre de 2010, Miha Čančula va escriure: >> > Dne ponedeljek 13 decembra 2010 ob 21:32:30 je Albert Astals Cid >> > napisal(a): >> > > Does this break keyboard navigation in the menu? >> > >> >

Re: Hiding the statusbar

On Wed, Nov 17, 2010 at 20:28, Steven Sroka wrote: > How do you automatically hide or disable the statusbar in KXmlGuiWindow? Don't pass StandardWindowOption::StatusBar to KXmlGuiWindow::setupGUI(). Parker

Re: "-DQT_NO_CAST_FROM_ASCII -DQT_NO_CAST_TO_ASCII" as policy in kde

On Mon, Nov 15, 2010 at 13:25, David Faure wrote: > On Wednesday 06 October 2010, Parker Coates wrote: >>  But I just don't think wrapping every >> single literal with a constructor or conversion function is improving >> code quality. [2] > > Right. In the code y